August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: move remove env variables to own class
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: move remove env variables to own class ...................................................................... packaging: setup: move remove env variables to own class Change-Id: I8913a2864cfd850103dd7dd640ca0a65f91e90ab Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-remove/config/ca.py M packaging/setup/plugins/ovirt-engine-remove/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/files/simple.py 4 files changed, 36 insertions(+), 21 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8913a2864cfd850103dd7dd640ca0a65f91e90ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify boot sequence validation on run vm
by amureini＠redhat.com 18 Aug '13

18 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: simplify boot sequence validation on run vm ...................................................................... core: simplify boot sequence validation on run vm Simplified the boot sequence validation code that is being executed on run VM by reducing the number of nested levels in it. This patch also contains additional minor refactorings: inline fields and remove unnecessary call to "booleanValue" method. Change-Id: I456ce87acb67ad9d9e2de988088c3ff0c7463d46 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 22 insertions(+), 25 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I456ce87acb67ad9d9e2de988088c3ff0c7463d46 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: simplify iso path validation on run vm
by amureini＠redhat.com 18 Aug '13

18 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: simplify iso path validation on run vm ...................................................................... core: simplify iso path validation on run vm Simplified the iso path validation code that is being executed on run VM by extracting the code that iterate over the images in the iso domain looking for the floppy/disk path to separate method, and reduce the number of nested levels and redundant fields in it. Change-Id: I7c1734497fdb22093ec507243ef1ae6bc5006220 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 27 insertions(+), 48 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c1734497fdb22093ec507243ef1ae6bc5006220 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adjust validators on run vm for HA vm
by amureini＠redhat.com 18 Aug '13

18 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: adjust validators on run vm for HA vm ...................................................................... core: adjust validators on run vm for HA vm Change the validators which check that the storage pool is up and the VM images are valid on run VM such that they will always return ValidationResult.Valid for HA (auto started) VM. This change makes it possible to start HA VM when there is no SPM defined. Change-Id: I9db34952306bbd62e93501399ddfcf1548cfc4ed Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9db34952306bbd62e93501399ddfcf1548cfc4ed Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: restart httpd after engine start
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: restart httpd after engine start ...................................................................... packaging: setup: restart httpd after engine start Make apache httpd restart only after we started the engine service so that it manages to connect to it. Change-Id: If5bdb00adbb0f08edefc931c4fe629f589be1ae1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/system/apache.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5bdb00adbb0f08edefc931c4fe629f589be1ae1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: allinone: DC version
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: allinone: DC version ...................................................................... packaging: setup: allinone: DC version Before this change, the allinone plugin created a DC with version being the version of the ovirt-engine package. Currently this fails, because the engine's version was bumped to 3.4, while the maximum supported version is 3.3. In principal, we can now add a supported version '3.4', but there is no reason to do so as long as we do not have to for compatibility reasons. This change creates the DC with version being the minimum of the package version and the maximum supported version. Change-Id: I01054b74f26fc961633d8f0a55429569dcc8cc31 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 1 file changed, 17 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01054b74f26fc961633d8f0a55429569dcc8cc31 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RecoveryStoragePool - update domain format
by amureini＠redhat.com 18 Aug '13

18 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RecoveryStoragePool - update domain format ...................................................................... core: RecoveryStoragePool - update domain format After completing successfully the execution of reconstruct to the given pool using the given domain, the domain version should be updated if necessary. Note: the performed operation is aligned with the one perform in attach storage domain command. Change-Id: I99db93aee407d78141714416836f5778d1b141f2 Bug-Url: https://bugzilla.redhat.com/947805 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 7 files changed, 35 insertions(+), 31 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99db93aee407d78141714416836f5778d1b141f2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel P. Berrange <berrange(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactorings in RunVmValidtor#canRunVm
by ofrenkel＠redhat.com 18 Aug '13

18 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactorings in RunVmValidtor#canRunVm ...................................................................... core: refactorings in RunVmValidtor#canRunVm As a first stage in fixing regressions that were found in RunVmValidator causing HA VMs not to start when there is not SPM defined, this patch refactor the canRunVM method to be more concise and readable: - use RunVmValidator#validate within #canRunVm method to make it shorter and more organized. - changed #validateStorageDomains, #validateImagesForRunVm and #validateVdsStatus methods to return ValidationResult instead of boolean as the other validation methods In addition, validations that were executed only when the VM had images even though they check things which are not related to images were moved such that they will be always executed. Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 38 insertions(+), 80 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPE on add vm template ctor
by ofrenkel＠redhat.com 18 Aug '13

18 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE on add vm template ctor ...................................................................... core: fix NPE on add vm template ctor AddVmTemplateCommand ctor is using masterVm from parameters, without checking for null, this can happen when command is created during backend recovery - so added a null check. this is ok because the parameter is not needed in end action. in addition the 'isVmInDb' member initialized on endAction in order unlockVm will be called if source vm is in db. Change-Id: I9b870a89c337a47110aaa7d20d027ad8ef06cfe8 Bug-Url: https://bugzilla.redhat.com/994860 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b870a89c337a47110aaa7d20d027ad8ef06cfe8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleaned up setChangeProhibitionReason calls
by derez＠redhat.com 18 Aug '13

18 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: cleaned up setChangeProhibitionReason calls ...................................................................... webadmin: cleaned up setChangeProhibitionReason calls Cleaned up all setChangeProhibitionReason calls to use non-hardcoded strings. Fixed some spelling mistakes in some of the calls. Change-Id: I8002e0aa88c892475c74d264a72e0ec30fe2b7d6 Bug-Url: https://bugzilla.redhat.com/995754 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 5 files changed, 29 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8002e0aa88c892475c74d264a72e0ec30fe2b7d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0