August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: spec: cleanup
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: cleanup ...................................................................... packaging: spec: cleanup No functionality change! 1. fix alignments. 2. fix shell styles. 3. quote everything. 4. remove useless obvious comments. 5. reorder sections. 6. reorder %files to plain sort 7. reorder dependencies to plain sort 8. prefix internal variables to avoid conflict and confusion. 9. add / suffix for directories at %files. Change-Id: I284a640121874544e0c3e57f52bc1722e50af871 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 435 insertions(+), 538 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284a640121874544e0c3e57f52bc1722e50af871 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding migration related commands to the managed-allow...
by oourfali＠redhat.com 18 Aug '13

18 Aug '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding migration related commands to the managed-allowed commands ...................................................................... core: adding migration related commands to the managed-allowed commands This patch adds the InternalMigrateVm and MigrateVmToServer commands to the allowed commands for managed VMs. Change-Id: I319aebd42acc2397b51f9a340ab2e37747b22c18 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I319aebd42acc2397b51f9a340ab2e37747b22c18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Revert findbugs fix that caused regression
by alkaplan＠redhat.com 18 Aug '13

18 Aug '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Revert findbugs fix that caused regression ...................................................................... webadmin: Revert findbugs fix that caused regression A findbugs fix removed a "redundant" null check, which caused the Setup Host Networks dialog to malfunction. There was indeed a redundant null check, but not the one that was removed. Bug-Url: https://bugzilla.redhat.com/975886 Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change iso prefix command to be vds broker command
by ofrenkel＠redhat.com 18 Aug '13

18 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change iso prefix command to be vds broker command ...................................................................... core: change iso prefix command to be vds broker command Change IsoPrefixVDSCommand to query the iso prefix from the VDS with the given ID instead of from the SPM (all the storage pool information can be received from hsm as well). That way, we'll be able to run vm with floppy/cd-rom even when there is no SPM defined in the DC. Change-Id: I272ce7b0407bf83bd47646941630362ecf0b18cc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsAndPoolIDVDSParametersBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsoPrefixVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetISOPathVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IsoPrefixVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResetISOPathVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 14 files changed, 137 insertions(+), 62 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I272ce7b0407bf83bd47646941630362ecf0b18cc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: added help to README.branding.
by ecohen＠redhat.com 16 Aug '13

16 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal, webadmin: added help to README.branding. ...................................................................... userportal, webadmin: added help to README.branding. Added a section to README.branding describing how to add new branded messages. Change-Id: Ibf41e42151f4bc03241a4ef2a46a68f565760112 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M README.branding 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf41e42151f4bc03241a4ef2a46a68f565760112 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>

1 0

Change in otopi[master]: core: support resolve None as file
by Alon Bar-Lev 15 Aug '13

15 Aug '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support resolve None as file ...................................................................... core: support resolve None as file Change-Id: Ie27949f3b7ef75236adb67be8c1b38fd981ec75f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie27949f3b7ef75236adb67be8c1b38fd981ec75f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-scheduler-proxy[master]: Appending PYTHONPATH instead of overriding it
by lhornyak＠redhat.com 15 Aug '13

15 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: Appending PYTHONPATH instead of overriding it ...................................................................... Appending PYTHONPATH instead of overriding it So you can specify other paths to look for dependencies, for example, when you want to use non packaged deps (like ovirt-engine-sdk) Change-Id: I8dee7a560f66961402f07a7273ca38768108d371 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M Makefile 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved David Caro: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dee7a560f66961402f07a7273ca38768108d371 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: prevent to run VM with cd-rom with no iso domain
by ofrenkel＠redhat.com 15 Aug '13

15 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent to run VM with cd-rom with no iso domain ...................................................................... core: prevent to run VM with cd-rom with no iso domain Add canDoAction() check that forbids running VM which is defined with cd-rom when no active iso domain exists. This can-do-action check replace other check that was exists in attachCd method that throwed an exception in this case. Change-Id: Idad3c5b812ce4744d3d610341e76af4c24ce0bae Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idad3c5b812ce4744d3d610341e76af4c24ce0bae Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: space war
by lhornyak＠redhat.com 15 Aug '13

15 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: space war ...................................................................... space war replaced all tabs to spaces Change-Id: I705030ceb98c887f5636476476c30cdd1823a968 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M tests/java/src/main/java/org/ovirt/schedulerproxy/SchedulerProxy.java M tests/java/src/test/java/org/ovirt/schedulerproxy/SchedulerProxyTest.java 2 files changed, 191 insertions(+), 185 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I705030ceb98c887f5636476476c30cdd1823a968 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-scheduler-proxy[master]: Rework plugin structure
by lhornyak＠redhat.com 15 Aug '13

15 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: Rework plugin structure ...................................................................... Rework plugin structure - Change dummy to the new format - Rework the loader to the new structure Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Change-Id: I74f9ff426b3c07ad68e5feb91bc4845426de42fc --- M plugins/dummy.py M src/ovirtscheduler/loader.py M src/ovirtscheduler/utils.py 3 files changed, 36 insertions(+), 47 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f9ff426b3c07ad68e5feb91bc4845426de42fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0