August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: model setInfo cleanup
by derez＠redhat.com 18 Aug '13

18 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: model setInfo cleanup ...................................................................... webadmin: model setInfo cleanup Changed all instances of setInfo() calls on models to setChangeProhibitionReason(). If there was a hardcoded string passed to setInfo(), moved it to UIConstants. Change-Id: I93e67e8b75da1a8409f1229a25bbe514c92bc867 Bug-Url: https://bugzilla.redhat.com/995754 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 9 files changed, 38 insertions(+), 39 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e67e8b75da1a8409f1229a25bbe514c92bc867 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: always create answer file
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: always create answer file ...................................................................... packaging: setup: always create answer file handy for support, create answer file at: /var/lib/ovirt-engine/setup/answers Change-Id: I8fca502907c0c4769a3f22e34e0a288a1a7b5997 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py 4 files changed, 57 insertions(+), 27 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fca502907c0c4769a3f22e34e0a288a1a7b5997 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: cleanup
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: cleanup ...................................................................... packaging: spec: cleanup remove oneliner comment as it does not work with sort() Change-Id: I5b8d05c379dd360c2a9cece2caa58f3bb4ea067f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8d05c379dd360c2a9cece2caa58f3bb4ea067f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: avoid disconnecting from used connections
by amureini＠redhat.com 18 Aug '13

18 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: avoid disconnecting from used connections ...................................................................... core: avoid disconnecting from used connections When attempting to extend a LUN based storage domain, the engine attempts to connect all the hosts to the lun. If one or more hosts fail to see the chosen luns for the extension - the engine attempts to disconnect all the hosts from the target. In that scenario the connection isn't loaded from the DB, therefore it's id will be always null - which can cause to disconnection from targets that are used by other luns that are in use. Change-Id: I7008e64ebce57fbbdb350810a5ffca6e0a7800cc Bug-Url: https://bugzilla.redhat.com/982707 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 24 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7008e64ebce57fbbdb350810a5ffca6e0a7800cc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: API: Do not require root password for host operations
by oliel＠redhat.com 18 Aug '13

18 Aug '13

Ori Liel has submitted this change and it was merged. Change subject: API: Do not require root password for host operations ...................................................................... API: Do not require root password for host operations This allows using public key authentication, and set root_password as deprecated field. Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java 3 files changed, 5 insertions(+), 4 deletions(-) Approvals: Ori Liel: Looks good to me, approved Yaniv Bronhaim: Verified -- To view, visit http://gerrit.ovirt.org/18002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Don't set bootproto on VLAN attach to NIC
by masayag＠redhat.com 18 Aug '13

18 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Don't set bootproto on VLAN attach to NIC ...................................................................... restapi: Don't set bootproto on VLAN attach to NIC Setting the boot protocol on attaching a network to a host's NIC causes the new VLAN to get the same boot parameters as the NIC itself, which makes little sense as the VLAN is a different L2 network and it's boot protocol info should be set accordingly and not automatically. Change-Id: I78b415592e2bc1a9fea901cadb3ee928f2935a14 Bug-Url: https://bugzilla.redhat.com/980486 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java 3 files changed, 41 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78b415592e2bc1a9fea901cadb3ee928f2935a14 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: cleanup
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: cleanup ...................................................................... packaging: spec: cleanup minor leftovers since last cleanup. Change-Id: I9af68f2dbc1d8289e0a841fb04ba3a58e4a8e17d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af68f2dbc1d8289e0a841fb04ba3a58e4a8e17d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: show notification of disabled policy unit
by gchaplik＠redhat.com 18 Aug '13

18 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: show notification of disabled policy unit ...................................................................... webadmin: show notification of disabled policy unit When the external scheduler doesn't load an already loaded plugin, the ui will show notification foreach one, with disabled caption and graying it out. Change-Id: Ia9f33eb9305ca639d15717362f0590cb8445d13a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/FunctionPolicyUnitPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java 4 files changed, 29 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f33eb9305ca639d15717362f0590cb8445d13a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Modify vm_interface-vnic-profiles foreign key
by masayag＠redhat.com 18 Aug '13

18 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify vm_interface-vnic-profiles foreign key ...................................................................... engine: Modify vm_interface-vnic-profiles foreign key The patch modifies the FK of vm_interface on vnic-profiles to be set NULL in case of deletion of the vnic profiles. Removal of a vnic profile which is used by vnics is blocked by can-do-action, same for network removal which is used by vms. However, when forcibly removing a data-center, the removal of the vm interface is being executed in a different transaction than the network entities. This can be avoided if the logic of DC removal would have been implemented by code and not in a stored procedure. Change-Id: I2feef15a7460899979a78b357886bd1f027918af Bug-Url: https://bugzilla.redhat.com/996934 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A packaging/dbscripts/upgrade/03_03_0770_alter_vm_interface_vnic_profile_fk.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2feef15a7460899979a78b357886bd1f027918af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: cleanup dependencies
by oschreib＠redhat.com 18 Aug '13

18 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: cleanup dependencies ...................................................................... packaging: spec: cleanup dependencies bind-utils, cracklib-python, policycoreutils-python required for setup and no other. httpd, mod_ssl required by backend. all in one needs recent setup. Change-Id: Iba2977ed8d151af9dbefc75849e9f37d1540a3a8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba2977ed8d151af9dbefc75849e9f37d1540a3a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0