August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: OtherOS VM - NPE in basic view
by derez＠redhat.com 05 Aug '13

05 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: OtherOS VM - NPE in basic view ...................................................................... userportal: OtherOS VM - NPE in basic view When creating a VM with 'Other' OS, the VM is not displayed in basic view due to an NPE. * Modified ApplicationResourcesWithLookup to correspond "OsType(Small/Large)Image" convention; I.e: ** s/other_LargeImage/otherLargeImage ** s/other_SmallImage/otherSmallImage * Modified OsTypeImage -> defaultImageName() accordingly. Change-Id: Id56e218a9895fa2fbaef48586272acfe80f9b382 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/OsTypeImage.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmImageColumn.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id56e218a9895fa2fbaef48586272acfe80f9b382 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: disable auto refresh on VmBasicDiskListModel
by derez＠redhat.com 05 Aug '13

05 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: disable auto refresh on VmBasicDiskListModel ...................................................................... userportal: disable auto refresh on VmBasicDiskListModel Disable auto refresh in UserPortal's 'Drives' panel (on basic view). This solution is part of the effort to reduce resources consumption due to reoccurring invocation of getdisksvmguid() stored procedure. Change-Id: I92f9606bac0a3f78984a41146b5c7404ec6bd936 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmBasicDiskListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92f9606bac0a3f78984a41146b5c7404ec6bd936 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Add entry to AppErrors.java
by tjelinek＠redhat.com 05 Aug '13

05 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Add entry to AppErrors.java ...................................................................... userportal: Add entry to AppErrors.java Add VM_POOL_CANNOT_ATTACH_TO_MORE_VMS_FROM_POOL method to AppErrors.java Change-Id: I1279d2393741075e973e4c46ea17a95237e00354 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988036 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1279d2393741075e973e4c46ea17a95237e00354 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: ovirt-node-plugin-vdsm.spec: remove autoreconf
by mburns＠redhat.com 05 Aug '13

05 Aug '13

Michael Burns has submitted this change and it was merged. Change subject: ovirt-node-plugin-vdsm.spec: remove autoreconf ...................................................................... ovirt-node-plugin-vdsm.spec: remove autoreconf Not required to re-run autoreconf. Source .tar.gz (make dist) already executed autoreconf to generate the files. Change-Id: Ie0b3dd0f38e3cb7590cac1fbca8f0d97b41027ae Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0b3dd0f38e3cb7590cac1fbca8f0d97b41027ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: External events' audit logs has not...
by emesika＠redhat.com 04 Aug '13

04 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: External events' audit logs has not... ...................................................................... core: External events' audit logs has not... External events' audit logs has not records in AuditLogMessages.properties Adding missing messages to AuditLogMessages.properties In addition this patch moves initialization of those messages to their own method in AuditLogDirector Change-Id: Ie06d4bd179b077013116f7f9776827532ce05cea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987830 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06d4bd179b077013116f7f9776827532ce05cea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing findbugs errors
by lhornyak＠redhat.com 04 Aug '13

04 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fixing findbugs errors ...................................................................... core: fixing findbugs errors * fixing wrong caching * no refernce to field Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Using stored VDS.sshUsername instead of default ro...
by derez＠redhat.com 04 Aug '13

04 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Using stored VDS.sshUsername instead of default root in reinstall view ...................................................................... webadmin: Using stored VDS.sshUsername instead of default root in reinstall view When loading InstallHost model we launched InstallPopupView filled with root username in the ssh user name area. This patch uses the stored VDS object and places in the username field the SshUsername that was saved during first installation. Change-Id: Ia9870d35f7dbabb102a809d02c356c15dd1bebff Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9870d35f7dbabb102a809d02c356c15dd1bebff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Adding tooltip and style to PublicKey field
by derez＠redhat.com 04 Aug '13

04 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Adding tooltip and style to PublicKey field ...................................................................... webadmin: Adding tooltip and style to PublicKey field Change-Id: I6fab16684a9b1bb57587e672ff1ba7fbf7eae40b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextAreaLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 6 files changed, 28 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fab16684a9b1bb57587e672ff1ba7fbf7eae40b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: new icon to host PreparingForMaintenance
by derez＠redhat.com 04 Aug '13

04 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: new icon to host PreparingForMaintenance ...................................................................... webadmin: new icon to host PreparingForMaintenance Using unique icon when host is turned to PreparingForMaintenance Change-Id: Iacae2d58feab5c30813a1d8383ca1abdb356ca5d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/host_prepare_to_migrate.png 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacae2d58feab5c30813a1d8383ca1abdb356ca5d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: root: branding: integrate properly with apache proxy
by derez＠redhat.com 04 Aug '13

04 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: root: branding: integrate properly with apache proxy ...................................................................... root: branding: integrate properly with apache proxy Change-Id: I6b2f6bf069b14b47d8128d2739e965b33888c1c0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M packaging/branding/ovirt.brand/welcome_page.template M packaging/conf/ovirt-engine-proxy.conf.v2.in 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b2f6bf069b14b47d8128d2739e965b33888c1c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0