September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: hostname: correct interfaces RE
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: hostname: correct interfaces RE ...................................................................... packaging: setup: hostname: correct interfaces RE There was a tiny bug in http://gerrit.ovirt.org/18962 - it caused some interface names to not be recognized. Fixed. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009990 Change-Id: Id19851ac46307f413ddd7cb56c3f6d1d6c5627bf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id19851ac46307f413ddd7cb56c3f6d1d6c5627bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: tiny pep8 fix
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: tiny pep8 fix ...................................................................... packaging: setup: tiny pep8 fix Change-Id: If815c86e4978e9b17bd8089086637928cac858fb Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If815c86e4978e9b17bd8089086637928cac858fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Add 'values' to configfile.py
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Add 'values' to configfile.py ...................................................................... packaging: setup: Add 'values' to configfile.py Change-Id: Id27fcd1335a2a264d2f1f6000815c7ddec578fbe Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/configfile.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27fcd1335a2a264d2f1f6000815c7ddec578fbe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: support modifying java module path
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: support modifying java module path ...................................................................... packaging: support modifying java module path if a customer need to have more recent version of module, he currently have no way to apply except of replacing pre-installed files. this change allows customer to add his own module path to search path to shadow product modules. Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-prolog.sh.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 5 files changed, 71 insertions(+), 44 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: add manual reference
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add manual reference ...................................................................... packaging: add manual reference empty manual to allow application to handle using single execution path. as this is not really a manual, move out of /usr/share/doc/ Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002353 Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in A packaging/manual/DocumentationPath.csv A packaging/manual/UserPortalDocumentationPath.csv M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 3 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: remove unneeded var sent to build
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: remove unneeded var sent to build ...................................................................... packaging: spec: remove unneeded var sent to build this was used in the past before Makefile was re-written. now only EXTRA_BUILD_FLAGS is used. Change-Id: Ifeb705e336083614f0055271fc7dba82347b3dca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeb705e336083614f0055271fc7dba82347b3dca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: enable ut per default
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: enable ut per default ...................................................................... packaging: build: enable ut per default spec: disable when quick or minimal build are selected. Change-Id: Ib334c4c297dc093a5fe6d62d6f05937d9d0db72d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib334c4c297dc093a5fe6d62d6f05937d9d0db72d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: add ovirt_build_extra_flags
by oschreib＠redhat.com 30 Sep '13

30 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: add ovirt_build_extra_flags ...................................................................... packaging: spec: add ovirt_build_extra_flags ovirt_build_extra_flags can be used to append build flags without conflict of the other options of ovirt_build_*. Change-Id: If7f956150e9ffc61c25dfc454fc113b1d6998c85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7f956150e9ffc61c25dfc454fc113b1d6998c85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix unchecked cast
by ofrenkel＠redhat.com 30 Sep '13

30 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix unchecked cast ...................................................................... core: fix unchecked cast Coverity scan detected unchecked cast from VdcActionParametersBase to ImagesActionsParametersBase in CreateAllSnapshotsFromVmCommand class. This patch solved it by verifing with 'instanceof' check that the cast is safe. Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Elaborate java docs in FixturesTool.
by mlipchuk＠redhat.com 30 Sep '13

30 Sep '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Elaborate java docs in FixturesTool. ...................................................................... core: Elaborate java docs in FixturesTool. Add javadoc which references the images related to image id and also adding the image group id related to image. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Icd1f49780d529e508acebc00e7e0b72afa8fc938 --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd1f49780d529e508acebc00e7e0b72afa8fc938 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0