September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Expand nics filter criteria
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Expand nics filter criteria ...................................................................... engine: Expand nics filter criteria The engine query for retrieving the host nics should consider nics which aren't bonds either by VdsNetworkInterface.getBonded() being equal to null or to Boolean.False. Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Bug-Url: https://bugzilla.redhat.com/1011486 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Increased width of provider field
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Increased width of provider field ...................................................................... webadmin: Increased width of provider field Line would get broken in Japanese. Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Bug-Url: https://bugzilla.redhat.com/1009807 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Add vnic profile action groups to roles tree
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add vnic profile action groups to roles tree ...................................................................... webadmin: Add vnic profile action groups to roles tree The vnic profiles action groups were added to the roles tree in order to better describe the actions supported by an existing roles or to enable creation of a custom role which includes any of these action groups. Change-Id: I56ba098f8b0b8e1f94aa7ec82b3612a6a81365d6 Bug-Url: https://bugzilla.redhat.com/1002483 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 36 insertions(+), 16 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56ba098f8b0b8e1f94aa7ec82b3612a6a81365d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Refactor RoleTreeView
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Refactor RoleTreeView ...................................................................... webadmin: Refactor RoleTreeView RoleTreeView had too long and complicated method with too many indentation levels. The patch reduces the complexity and allows new entities to be added more easily to the Action Groups tree. Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Related-To: https://bugzilla.redhat.com/1002483 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 207 insertions(+), 341 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed provider name validation
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixed provider name validation ...................................................................... webadmin: Fixed provider name validation Frontend only made sure that the name was non-empty, while the backend enforced ASCII characters; now they're the same. Change-Id: I552ab44967789c9ffbbd4b05758a36223da17d43 Bug-Url: https://bugzilla.redhat.com/987294 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I552ab44967789c9ffbbd4b05758a36223da17d43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove unused class
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove unused class ...................................................................... webadmin: remove unused class Change-Id: I7c14e67453151dc44bf07d5083fb36d096f38319 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/configure/RolePresenterWidget.java 1 file changed, 0 insertions(+), 79 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c14e67453151dc44bf07d5083fb36d096f38319 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: failing to assign disk quota
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: failing to assign disk quota ...................................................................... core: failing to assign disk quota missing default c'tor in parameter class caused some of the parameters to be null. Change-Id: Id39828bf3116b26e85609488267b128a2dd5bab9 Bug-Url: https://bugzilla.redhat.com/1000399 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java 1 file changed, 25 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id39828bf3116b26e85609488267b128a2dd5bab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Increased width of provider field
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Increased width of provider field ...................................................................... webadmin: Increased width of provider field Line would get broken in Japanese. Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Bug-Url: https://bugzilla.redhat.com/1009807 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Prevent NPE when getting statistics
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Prevent NPE when getting statistics ...................................................................... restapi: Prevent NPE when getting statistics VDSM doesn't report statistics for all of the network interfaces (i.e. vlans, see [1] for more details) therefore the restapi shouldn't expect a wrapper not to be null and prevent autoboxing to avoid NPE. [1] https://bugzilla.redhat.com/675560 Change-Id: Iab3422ef11f35b7a75d39f62cc5caa6f827ac7f4 Bug-Url: https://bugzilla.redhat.com/993123 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/RxTxCalculator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab3422ef11f35b7a75d39f62cc5caa6f827ac7f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Expand nics filter criteria
by masayag＠redhat.com 29 Sep '13

29 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Expand nics filter criteria ...................................................................... engine: Expand nics filter criteria The engine query for retrieving the host nics should consider nics which aren't bonds either by VdsNetworkInterface.getBonded() being equal to null or to Boolean.False. Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Bug-Url: https://bugzilla.redhat.com/1011486 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0