December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: win32: Application list is not returned on 2K3 R2
by vfeenstr＠redhat.com 18 Dec '14

18 Dec '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Application list is not returned on 2K3 R2 ...................................................................... win32: Application list is not returned on 2K3 R2 The application list is not returned, as it seems that under Windows 2003 R2 the subsequent call to the OpenKey, after the parent key has been already opened, for some reason looses the correct WOW property, resulting in key not found error. Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1174853 --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Keep code DRY
by yzaslavs＠redhat.com 17 Dec '14

17 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Keep code DRY ...................................................................... engine: Keep code DRY Reuse same dao implementation to prevent code duplications. Change-Id: I52f52c292a0c1eedff84108d325a1adf17676525 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52f52c292a0c1eedff84108d325a1adf17676525 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Standardize action message parameters of cluster
by yzaslavs＠redhat.com 17 Dec '14

17 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Standardize action message parameters of cluster ...................................................................... engine: Standardize action message parameters of cluster The action messages parameters should be added for each cluster command invocation, notating the entity is cluster and a varying action type. Change-Id: I3b67dfef6dc6b2bd254631b4ecb1e62b9504c86a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java 5 files changed, 21 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b67dfef6dc6b2bd254631b4ecb1e62b9504c86a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use direct dao getter instead blown method
by yzaslavs＠redhat.com 17 Dec '14

17 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Use direct dao getter instead blown method ...................................................................... engine: Use direct dao getter instead blown method Instead of the blown method to obtain dao, i.e. DbFacade.getInstance().getXXXDao() use getXXXDao(). Change-Id: I325a9280a96adc5282b6088097c94257017465dd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java 1 file changed, 11 insertions(+), 15 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325a9280a96adc5282b6088097c94257017465dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Small cleanup in RestApiSessionManager
by awels＠redhat.com 17 Dec '14

17 Dec '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Small cleanup in RestApiSessionManager ...................................................................... webadmin: Small cleanup in RestApiSessionManager Acquiry of new session vs. keep-alive of existing session logical scenarios represented by two separate methods. REST CSRF token request header represented by a separate String constant to avoid confusion with JSESSIONID header containing actual REST session ID on HTTP response. Change-Id: I98ad53785726c4ed1a8b1eaaf4fd473052496c3e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 39 insertions(+), 37 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/35708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ad53785726c4ed1a8b1eaaf4fd473052496c3e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: Add explicit execution ID for maven-jar-plugin:test-jar
by vszocs＠redhat.com 17 Dec '14

17 Dec '14

Vojtech Szocs has submitted this change and it was merged. Change subject: build: Add explicit execution ID for maven-jar-plugin:test-jar ...................................................................... build: Add explicit execution ID for maven-jar-plugin:test-jar By default, maven-jar-plugin:test-jar is executed when building all child projects, resulting in "test JAR" file like following: target/${artifactId}-${version}-tests.jar This patch adds execution ID for maven-jar-plugin:test-jar so that some child projects may decide to skip creation of above mentioned "test JAR" file. As a side note, explicit execution IDs are always better than relying on Maven-generated (implicit) execution IDs. Change-Id: I1f22b179436f29ca8022f33607c10af6c6f2a9ef Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f22b179436f29ca8022f33607c10af6c6f2a9ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Added help tag to attach storage to data center di...
by tnisan＠redhat.com 17 Dec '14

17 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added help tag to attach storage to data center dialog ...................................................................... webadmin: Added help tag to attach storage to data center dialog Change-Id: I98530b5e3e774222e5fb38add850c087ee4d8194 Bug-Url: https://bugzilla.redhat.com/1174045 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98530b5e3e774222e5fb38add850c087ee4d8194 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add help tag for import storage domain
by tnisan＠redhat.com 17 Dec '14

17 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add help tag for import storage domain ...................................................................... webadmin: Add help tag for import storage domain Change-Id: Ic5955a050dc30b9a98b52a09e2603db0a657976b Bug-Url: https://bugzilla.redhat.com/1174042 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5955a050dc30b9a98b52a09e2603db0a657976b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Configurable Default for Wipe After Delete per Storage...
by tnisan＠redhat.com 17 Dec '14

17 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Configurable Default for Wipe After Delete per Storage Domain ...................................................................... core: Configurable Default for Wipe After Delete per Storage Domain This patch adds the ability to configure a default value for wipe after delete (WAD) per storage domain via the REST API. This way, each new disk will get the default value for WAD from its storage domain. Note that SANWipeAfterDelete will no longer be the WAD default value for disks, but for storage domains. Change-Id: I4e0d5a1c9158be1284ffe05d1bf1397c9113f6c0 Bug-Url: https://bugzilla.redhat.com/1073448 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/03_06_0630_add_wipe_after_delete_to_storage_domain_static.sql 20 files changed, 83 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e0d5a1c9158be1284ffe05d1bf1397c9113f6c0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: vdsm: update patches for libgfapi-rpms
by dcaroest＠redhat.com 17 Dec '14

17 Dec '14

David Caro has submitted this change and it was merged. Change subject: vdsm: update patches for libgfapi-rpms ...................................................................... vdsm: update patches for libgfapi-rpms Change-Id: Ib3f0fa86b7a09603fe39c6d0e7c79902ae3da763 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create_libgfapi-rpms.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f0fa86b7a09603fe39c6d0e7c79902ae3da763 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0