December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Stop constant synchronization of admin@internal
by yzaslavs＠redhat.com 17 Dec '14

17 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Stop constant synchronization of admin@internal ...................................................................... aaa: Stop constant synchronization of admin@internal The following changes are required - a. when reading group_ids from db - an empty string of group_ids should not become a a set containing the "zero" guid, but should be an empty set. b. group_ids should not have sub strings of "zero" guids c. equals of DbUser should not check isAdmin Bug-Url: https://bugzilla.redhat.com/1175046 Change-Id: I5a7660f813b7926b4193ebeb39b3c2a5f07550b4 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java A packaging/dbscripts/upgrade/03_06_0610_fix_admin_internal_constant_sync.sql 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7660f813b7926b4193ebeb39b3c2a5f07550b4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix error messages of basic authentication filter
by Alon Bar-Lev 17 Dec '14

17 Dec '14

Hello ovirt-engine-commits, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/36206 to review the following change. Change subject: aaa: fix error messages of basic authentication filter ...................................................................... aaa: fix error messages of basic authentication filter Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1174731 Change-Id: I3ec060ee36bc94a2c8b40501358b21e4da44c4ca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/36206/1 diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java index 4cb46e0..cab8a87 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java @@ -114,7 +114,7 @@ private void handleCredentials(HttpServletRequest request, String user, String password) { UserProfile userProfile = translateUser(user); if (userProfile == null || userProfile.profile == null) { - log.error("Error in obtaining profile {}", userProfile.profile); + log.error("Cannot obtain profile for user {}", user); } else { ExtMap outputMap = userProfile.profile.getAuthn().invoke(new ExtMap().mput( Base.InvokeKeys.COMMAND, @@ -146,10 +146,11 @@ userProfile.userName ); } - log.error("Failure in authentication to profile {}. Invocation Result code is {}. Authn result code is {}", - userProfile.profile, - outputMap.<Integer> get(Base.InvokeKeys.RESULT), - outputMap.<Integer> get(Authn.InvokeKeys.RESULT) + log.error("User {} authentication failed. profile is {}. Invocation Result code is {}. Authn result code is {}", + userProfile.userName, + userProfile.profile.getName(), + outputMap.<Integer> get(Base.InvokeKeys.RESULT), + outputMap.<Integer> get(Authn.InvokeKeys.RESULT) ); } } -- To view, visit http://gerrit.ovirt.org/36206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ec060ee36bc94a2c8b40501358b21e4da44c4ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org>

2 1

Change in ovirt-engine[master]: webadmin: save search query
by awels＠redhat.com 16 Dec '14

16 Dec '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: save search query ...................................................................... webadmin: save search query - Use the current search query when switching to a main tab from another main tab. Before it would use the default search query instead of the current used one. When selecting items in the system tree it will reset the current query to the default. Change-Id: I9f72f406e467ba90ad6800429492427c3f14a6a3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1172389 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f72f406e467ba90ad6800429492427c3f14a6a3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: two providers produce the same "domain id"
by oourfali＠redhat.com 16 Dec '14

16 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: two providers produce the same "domain id" ...................................................................... aaa: two providers produce the same "domain id" This may occur if two authz names have the same prefix that gets converted to the same Guid. This happens as the Guid ctor that receives an array of bytes needs only the first 16 bytes to consturct a guid and ignores the rest. The fix suggest an id that is based on base64 encoding of the entire string. Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb Bug-Url: https://bugzilla.redhat.com/1172187 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java 8 files changed, 46 insertions(+), 38 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: Replace oVirt Engine str with constant
by dougsland＠redhat.com 16 Dec '14

16 Dec '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Replace oVirt Engine str with constant ...................................................................... engine_page: Replace oVirt Engine str with constant Use constant for product name instead of static value. Change-Id: I989fec8c90c27bad4e8a3dca810ab492253929dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167246 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I989fec8c90c27bad4e8a3dca810ab492253929dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Replace oVirt Engine str with constant
by dougsland＠redhat.com 16 Dec '14

16 Dec '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Replace oVirt Engine str with constant ...................................................................... engine_page: Replace oVirt Engine str with constant Use constant for product name instead of static value. Change-Id: I989fec8c90c27bad4e8a3dca810ab492253929dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167246 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I989fec8c90c27bad4e8a3dca810ab492253929dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add help tag for import storage domain
by tnisan＠redhat.com 16 Dec '14

16 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add help tag for import storage domain ...................................................................... webadmin: Add help tag for import storage domain Change-Id: Ic5955a050dc30b9a98b52a09e2603db0a657976b Bug-Url: https://bugzilla.redhat.com/1174042 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5955a050dc30b9a98b52a09e2603db0a657976b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: two providers produce the same "domain id"
by oourfali＠redhat.com 16 Dec '14

16 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: two providers produce the same "domain id" ...................................................................... aaa: two providers produce the same "domain id" This may occur if two authz names have the same prefix that gets converted to the same Guid. This happens as the Guid ctor that receives an array of bytes needs only the first 16 bytes to consturct a guid and ignores the rest. The fix suggest an id that is based on base64 encoding of the entire string. Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb Bug-Url: https://bugzilla.redhat.com/1172187 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java 8 files changed, 46 insertions(+), 38 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix findbugs warning.
by awels＠redhat.com 16 Dec '14

16 Dec '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix findbugs warning. ...................................................................... webadmin: Fix findbugs warning. - Findbugs is unhappy with VmListModel, this patch fixes the findbugs issue. Change-Id: Idee9c50e88b73211616081128fa3f87b16e391bc Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idee9c50e88b73211616081128fa3f87b16e391bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: filter duplicate requests to migrate the same vm
by ahadas＠redhat.com 16 Dec '14

16 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: filter duplicate requests to migrate the same vm ...................................................................... core: filter duplicate requests to migrate the same vm Because of a bug in the UI, we might get several requests together to migrate the same VM. It produces an error message to the user saying the VM is already been migrated although it is actually being migrated because of his request. The solution is to override the hashCode and equals method in the parameters of migration so duplicate requests will be filtered by MultipleActionRunner. Change-Id: Idda26210b9cf4f2746e27a3291bab20b10aaf103 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmToServerParameters.java 2 files changed, 52 insertions(+), 1 deletion(-) Approvals: Arik Hadas: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idda26210b9cf4f2746e27a3291bab20b10aaf103 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0