December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add dummy setter for graphicsInfo
by ahadas＠redhat.com 18 Dec '14

18 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: add dummy setter for graphicsInfo ...................................................................... core: add dummy setter for graphicsInfo This patch adds a dummy setter for VmDynamic.grahicsInfo attribute to VM and VmDynamic classes. This is needed for serialization. Change-Id: Ifb385db955ab9e48ad2c8a063655957e8151ec63 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 2 files changed, 14 insertions(+), 1 deletion(-) Approvals: Frank Kobzik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb385db955ab9e48ad2c8a063655957e8151ec63 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: filter duplicate requests to run the same vm
by tnisan＠redhat.com 18 Dec '14

18 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: filter duplicate requests to run the same vm ...................................................................... core: filter duplicate requests to run the same vm If engine gets multiple requests to run the same VM at the same time (with MultipleActionRunner), we might get into a situation where the VM does not run and kept locked. Say we got 2 run requests for the same VM: - The first command acquires the lock for the VM - The second command fails to acquire the lock - The can-do-action phase of the first command succeed - We sort the commands before invoking them. As part of the sort, we map Id of VM to its run command. Since we iterate the commands in the same order they were received, we end up with mapping the second command - Since the second command didn't manage to acquire the lock, it won't run Since the first command does not run, it won't release its lock. The solution is to filter the given parameters from duplicate requests to run the same VM. We now override the hashCode and equals methods in RunVmParams class so if we will get duplicate instances, they will be filtered while we insert them to a Set in MultipleActionRunner. Change-Id: I91320cfd50fc7a12b01afae2885a783c0516a6df Bug-Url: https://bugzilla.redhat.com/1174815 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java 3 files changed, 103 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91320cfd50fc7a12b01afae2885a783c0516a6df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Prevents duplicates parameters in multiple actions
by tnisan＠redhat.com 18 Dec '14

18 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Prevents duplicates parameters in multiple actions ...................................................................... engine: Prevents duplicates parameters in multiple actions The multiple action runner api serves as a method for invoking multiple actions in a single call to the engine. However, it turns out that due to a mysterious bug, in few flows the UI provides the same parameter more than once which might lead to an unexpected behavior (i.e. infinite locked vm). By replacing the parameters collection type to set we prevent that from happen, and each parameter class will implement its own euqals() and hasCode() methods to enforce the uniqueness. Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Bug-Url: https://bugzilla.redhat.com/1174815 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java 3 files changed, 20 insertions(+), 12 deletions(-) Approvals: Arik Hadas: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: decrement pending vm on 'run in paused mode'
by tnisan＠redhat.com 18 Dec '14

18 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: decrement pending vm on 'run in paused mode' ...................................................................... core: decrement pending vm on 'run in paused mode' In a flow where VM is started in paused state neither of runningSucceeded nor runningFailed methods in RunVmCommand are called. The command is kept in the collection of async commands until the VM will be resumed. On resume, the reportCompleted method of the original RunVmCommand will be called and it will be removed from the async command collection. Thus, the pending resources are not cleared in this flow. The solution is to decrease the pending resources in the reportCompleted method if they were not decreased before. Change-Id: Icc931118a848c1c7507c407d955537761dd1a742 Bug-Url: https://bugzilla.redhat.com/1174816 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc931118a848c1c7507c407d955537761dd1a742 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: improve exception handling on run vm
by tnisan＠redhat.com 18 Dec '14

18 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: improve exception handling on run vm ...................................................................... core: improve exception handling on run vm In case an exception is thrown when calling the 'create' verb in VDSM and there is no point to retry to run the VM on other host, we used to just re-throw the exception in RunVmCommand to prevent the rerun mechanism from taking place. The problem is that this way the pending resources were not cleared in this flow. The solution is to improve the error handling: 1. If Done/exists exception was thrown, we call the reportCompleted to decrease the pending resources 2. If VDS_NETWORK_ERROR/PROVIDER_FAILURE exception was thrown, we call the runningFailed to decrease the pending resources (in this case, the VM should be treated as if it went down, we should remove its stateless snapshot if such snapshot exists for example). Change-Id: Iee3bdb65ca58c49de65770d4e9cf9435bbbe5070 Bug-Url: https://bugzilla.redhat.com/1174817 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee3bdb65ca58c49de65770d4e9cf9435bbbe5070 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Stop constant synchronization of admin@internal
by oourfali＠redhat.com 18 Dec '14

18 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Stop constant synchronization of admin@internal ...................................................................... aaa: Stop constant synchronization of admin@internal The following changes are required - a. when reading group_ids from db - an empty string of group_ids should not become a a set containing the "zero" guid, but should be an empty set. b. group_ids should not have sub strings of "zero" guids c. equals of DbUser should not check isAdmin Bug-Url: https://bugzilla.redhat.com/1175046 Change-Id: I5a7660f813b7926b4193ebeb39b3c2a5f07550b4 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java A packaging/dbscripts/upgrade/03_05_1200_fix_admin_internal_constant_sync.sql 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7660f813b7926b4193ebeb39b3c2a5f07550b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use specific method to find query class
by masayag＠redhat.com 18 Dec '14

18 Dec '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use specific method to find query class ...................................................................... engine: Use specific method to find query class Change-Id: I455aa90280ba71bd3ec2731f34a2f277b7b86d3d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I455aa90280ba71bd3ec2731f34a2f277b7b86d3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Order the Add Block Host List
by kmayilsa＠redhat.com 18 Dec '14

18 Dec '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Order the Add Block Host List ...................................................................... webadmin : Order the Add Block Host List Order the Add Block Host List Change-Id: Idcc47e29a5e54ff2bd76bb71fe8a56ebf4ff28ab Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1044124 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 3 files changed, 16 insertions(+), 2 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcc47e29a5e54ff2bd76bb71fe8a56ebf4ff28ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Add scheduling filter that prevents migration to same host
by gchaplik＠redhat.com 18 Dec '14

18 Dec '14

Gilad Chaplik has submitted this change and it was merged. Change subject: Add scheduling filter that prevents migration to same host ...................................................................... Add scheduling filter that prevents migration to same host Inhibit migration if destination hostname resolves to source host. In that case, libvirt will abort anyway, so this check just prevents libvirt error from happening. In addition, avoid migrations to a host which resolves to localhost, which is rarely, if ever, a good thing. Change-Id: I42021452205f3dc070388a43de92c8fd5ed6dbf2 Bug-Url: https://bugzilla.redhat.com/1107650 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_0640_add_migration_policy_unit.sql 8 files changed, 89 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42021452205f3dc070388a43de92c8fd5ed6dbf2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.5]: win32: Application list is not returned on 2K3 R2
by vfeenstr＠redhat.com 18 Dec '14

18 Dec '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Application list is not returned on 2K3 R2 ...................................................................... win32: Application list is not returned on 2K3 R2 The application list is not returned, as it seems that under Windows 2003 R2 the subsequent call to the OpenKey, after the parent key has been already opened, for some reason looses the correct WOW property, resulting in key not found error. Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1174853 --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0