May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.5.6
by msivak＠redhat.com 24 May '16

24 May '16

Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.5.6 ...................................................................... build: ovirt-hosted-engine-ha-1.3.5.6 Change-Id: I05ef22a1ed3120cc5fdd14c219e6f99bd4ed0d49 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05ef22a1ed3120cc5fdd14c219e6f99bd4ed0d49 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of Import VMs dialog
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of Import VMs dialog ...................................................................... webadmin: Fix of Import VMs dialog * Previously when there was no Data Center in state up, it was still possible to press "Load" button which caused FE exception. This patch binds enabled/disabled state of load button to enabled/disabled state of Data Center drop down to prevent that. * Load button to import VMs from external domain is now disabled when there is not external domain. Previously it was enabled all the time and clicking it without export domain caused frontend exception. * Error and warning panel shows relevant info right after opening the dialog. Previously there were no message after the dialog was opened and messages were updated when "Source" dropbox was changed. Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1336828 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 93 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: network: skip NetworkManager check/disable via answerfile
by stirabos＠redhat.com 24 May '16

24 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: network: skip NetworkManager check/disable via answerfile ...................................................................... network: skip NetworkManager check/disable via answerfile Adding the capability to skip NM check and disabling by host-deploy via answerfile (dafault enforcing). In the normal flow, host-deploy will disable NetworkManager if active. When host-deploy runs, the management bridge has already been created and the engine VM is already running so disabling NetworkManager on the fly can be risky for the engine VM networking. To avoid that, ovirt-hosted-engine-setup will check NetworkManager status and eventually ask the user to stop: this behavior wasn't configurable. On the other side Next Generation Node is based on Cockpit, which requires NetworkManager to report the network status. Next Generation Node comes with NetworkManager-config-server so NetworkManager there should be passive enough. With this patch we make its check optionally skippable via answerfile. Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d Bug-Url: https://bugzilla.redhat.com/1337050 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 3 files changed, 21 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: spagobi: drop jobs
by sbonazzo＠redhat.com 24 May '16

24 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spagobi: drop jobs ...................................................................... spagobi: drop jobs Change-Id: Ic905f49f97b0ebb998e5b6cfc9713524f965c5a5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D jobs/confs/projects/spagobi-dependencies/spagobi-dependencies.yaml D jobs/confs/projects/spagobi/spagobi_create-rpms.yaml D jobs/confs/yaml/scms/spagobi.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 4 files changed, 0 insertions(+), 77 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic905f49f97b0ebb998e5b6cfc9713524f965c5a5 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove org.ovirt.engine.core.utils.IPAddress
by amureini＠redhat.com 24 May '16

24 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove org.ovirt.engine.core.utils.IPAddress ...................................................................... core: Remove org.ovirt.engine.core.utils.IPAddress Remove the unused class org.ovirt.engine.core.utils.IPAddress. Change-Id: If4e1777bc67ea1df3038149516159dd8bbb52603 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/IPAddress.java 1 file changed, 0 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e1777bc67ea1df3038149516159dd8bbb52603 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix disk creation from within new VM popup
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disk creation from within new VM popup ...................................................................... webadmin: Fix disk creation from within new VM popup The disk creation parameters when creating a disk from the new VM popup had to be fixed since the VM id is not known until the actual creation of the VM and should be set accordingly just before the disks creation Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1338510 Change-Id: I54d788f8ee0303792abe24b144c567b93e7ff40b --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54d788f8ee0303792abe24b144c567b93e7ff40b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix NPE while trying to add a LUN disk to a VM
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE while trying to add a LUN disk to a VM ...................................................................... core: Fix NPE while trying to add a LUN disk to a VM Change-Id: I452d203175e8af6b60c6d7a3a299658260c9e0b8 Bug-Url: https://bugzilla.redhat.com/1337909 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452d203175e8af6b60c6d7a3a299658260c9e0b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix import external provider as template
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix import external provider as template ...................................................................... core: Fix import external provider as template Change-Id: I820e50267e9471a08c976c04c0b92cf763ff0ac2 Bug-Url: https://bugzilla.redhat.com/1338509 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I820e50267e9471a08c976c04c0b92cf763ff0ac2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SuperUser can not use virtio serial console
by tjelinek＠redhat.com 24 May '16

24 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: SuperUser can not use virtio serial console ...................................................................... core: SuperUser can not use virtio serial console The problem was that the query returning the list of VMs where the user has the CONNECT_TO_SERIAL_CONSOLE used the GetAllFromVmsForUserAndActionGroup stored procedure. This stored procedure was based on the user_vm_permissions_view which did not contain the admin roles. Fixed by creating a new view vm_permissions_view which contains both the admin and user roles. Change-Id: Ia5f07ab7fd89714b4ab3709639c6e15dfdba1d8e Bug-Url: https://bugzilla.redhat.com/1320343 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/create_views.sql M packaging/dbscripts/vms_sp.sql 2 files changed, 31 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f07ab7fd89714b4ab3709639c6e15dfdba1d8e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: build: post ovirt-engine-3.6.7 branching
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.7 branching ...................................................................... build: post ovirt-engine-3.6.7 branching Change-Id: I1387ae159164978fbc90da65e5c3a40790720800 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 56 files changed, 61 insertions(+), 55 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1387ae159164978fbc90da65e5c3a40790720800 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0