May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.7]: build: post ovirt-engine-3.6.7
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.7 ...................................................................... build: post ovirt-engine-3.6.7 Change-Id: Iabfaa8dcde7c304942cc1099f7a3668ac7c3d8e6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 58 files changed, 65 insertions(+), 62 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabfaa8dcde7c304942cc1099f7a3668ac7c3d8e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: build: ovirt-engine-3.6.7
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.6.7 ...................................................................... build: ovirt-engine-3.6.7 Change-Id: I18f23a7d231b6f22f3e67672b031cc7fbc2cc416 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 59 files changed, 64 insertions(+), 64 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18f23a7d231b6f22f3e67672b031cc7fbc2cc416 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RunVm.endAction() - do not create child params manually
by laravot＠redhat.com 24 May '16

24 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: RunVm.endAction() - do not create child params manually ...................................................................... core: RunVm.endAction() - do not create child params manually When reaching the endAction() the child commands are already populated by the infrastracture and they might contain info set by the infrastracture. Change-Id: Ie703b49cf3381b7264d2a2632104ef557d77bddc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie703b49cf3381b7264d2a2632104ef557d77bddc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Minor refactoring of AttachUserToVmFromPoolAndRunCommand
by ahadas＠redhat.com 24 May '16

24 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Minor refactoring of AttachUserToVmFromPoolAndRunCommand ...................................................................... core: Minor refactoring of AttachUserToVmFromPoolAndRunCommand * Removed redundant poolId parameters; * Removed redundant DbFacade references; * Removed redundant get/setVmPoolId() override; * Fixed formatting. Change-Id: Ife028ba761ae965ae0d49b254724795ff4a2245f Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 29 insertions(+), 36 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife028ba761ae965ae0d49b254724795ff4a2245f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: switch from 3.6.6 to 3.6.7
by sbonazzo＠redhat.com 24 May '16

24 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: switch from 3.6.6 to 3.6.7 ...................................................................... ovirt-engine: switch from 3.6.6 to 3.6.7 Change-Id: Id042af3c02f78bb9399f9327b9e54261ab86ae1e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me Sandro Bonazzola: Verified; Ready for merge Simone Tiraboschi: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id042af3c02f78bb9399f9327b9e54261ab86ae1e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of custom properties
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Import VM dialog - architecture
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Import VM dialog - architecture ...................................................................... frontend: Import VM dialog - architecture * The split table of the dialog shows VMs with architecture: "Name (arch)". * The dialog prevents from continuing to the next page and shows error dialog if the selection * contains VM with multiple architectures (because they can't be imported in one Cluster) * contains VM with architecture for which there is no corresponding Cluster in selected Data Center Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294451 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Set the vfsType glusterfs when importing HE domain
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set the vfsType glusterfs when importing HE domain ...................................................................... engine: Set the vfsType glusterfs when importing HE domain In HE flow, when importing a gluster domain we must set explicitly the domain type otherwise the mount will fail. This problem discovered when non HE hosts where connecting to that domain. HE hosts have the right mount options in a configuration file (they are connecting before there is an engine live) Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Bug-Url: https://bugzilla.redhat.com/1317699 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of custom properties
by tjelinek＠redhat.com 24 May '16

24 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add audit log for register disk.
by mlipchuk＠redhat.com 23 May '16

23 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add audit log for register disk. ...................................................................... core: Add audit log for register disk. Add audit log for regsiter disk. Change-Id: Ieb4b705b353dbc6f789b0e45f34834889e24f950 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/57844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4b705b353dbc6f789b0e45f34834889e24f950 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0