May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix broken test
by ahadas＠redhat.com 23 May '16

23 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix broken test ...................................................................... core: fix broken test Fix UpdateVmCommandTest#testCannotDisableVirtioScsi Change-Id: I148c0e6e2c80e5ca5ac2baefa3c80d934d37200f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 2 files changed, 14 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I148c0e6e2c80e5ca5ac2baefa3c80d934d37200f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused IrsProxyData#privateVersion
by laravot＠redhat.com 23 May '16

23 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Remove unused IrsProxyData#privateVersion ...................................................................... core: Remove unused IrsProxyData#privateVersion Change-Id: Ibcb36461a3b3122c8a27a4c37efe79ed56756870 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcb36461a3b3122c8a27a4c37efe79ed56756870 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.6
by sbonazzo＠redhat.com 23 May '16

23 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.6 ...................................................................... build: ovirt-live-3.6.6 Change-Id: Ica26978a6f0747430b0352031136956241a65f36 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica26978a6f0747430b0352031136956241a65f36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: pass mount options via answerfile
by stirabos＠redhat.com 23 May '16

23 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: pass mount options via answerfile ...................................................................... storage: pass mount options via answerfile Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file if a value has been supplied via answerfile. Doing it interactively will require to propose a reasonable default and validate the user input so it will addressed in a future patch. Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M templates/hosted-engine.conf.in 5 files changed, 35 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: pass mount options via answerfile
by stirabos＠redhat.com 23 May '16

23 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: pass mount options via answerfile ...................................................................... storage: pass mount options via answerfile Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file if a value has been supplied via answerfile. Doing it interactively will require to propose a reasonable default and validate the user input so it will addressed in a future patch. Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-setup/core/conf.py M src/plugins/gr-he-setup/storage/blockd.py M src/plugins/gr-he-setup/storage/storage.py M templates/hosted-engine.conf.in 5 files changed, 36 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: build: ovirt-release-3.6.6
by sbonazzo＠redhat.com 23 May '16

23 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release-3.6.6 ...................................................................... build: ovirt-release-3.6.6 Change-Id: I7a417a018b945e0ca7b58df9f3c9f60eb994634e --- M configure.ac M ovirt-release36.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a417a018b945e0ca7b58df9f3c9f60eb994634e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove notYetRemoved condition from removeTemplateImages.
by mlipchuk＠redhat.com 23 May '16

23 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove notYetRemoved condition from removeTemplateImages. ...................................................................... core: Remove notYetRemoved condition from removeTemplateImages. RemoveAllVmTemplateImageTemplatesCommand behaviour should be alligned with RemoveAllVmImagesCommand regarding the deletion of notYetRemoved flag which was introduced at commit 03abfef3798e026b5c4eb431b08724d5f46205de. RemoveAllVmTemplateImageTemplatesCommand shouldn't fail in case of failure to create a task for deletion. The engine should continue and try to delete the other images Change-Id: Iaa2051252cbc9a270102717787249e8885573290 Bug-Url: https://bugzilla.redhat.com/1328071 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa2051252cbc9a270102717787249e8885573290 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: RunVm - do not pass compensation context
by piotr.kliczewski＠gmail.com 23 May '16

23 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: RunVm - do not pass compensation context ...................................................................... core: RunVm - do not pass compensation context When running stateless vm, the RunVm command first creates a snapshot for the vm. When running the create snapshot command, the command context is passed to the child command - which means that the command compensation context is passed as well. The compensation in use is NoOp compensation context it causes the executed child command to use that compensation context as well, on case of failure the db changes won't be reverted which will leave us with inconsistent db state. Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122 Bug-Url: https://bugzilla.redhat.com/1334105 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/57848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Cell history graph doesn't overlap text
by tjelinek＠redhat.com 23 May '16

23 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Cell history graph doesn't overlap text ...................................................................... webadmin: Cell history graph doesn't overlap text It prevents overlapping of graph and text in columns Memory, CPU and Network in VM main tab. Space for text and column width were widened. Change-Id: Id00f77f35bed95863c86f0f60810624cb3c52341 Bug-Url: https://bugzilla.redhat.com/1296529 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractLineChartProgressBarColumn.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id00f77f35bed95863c86f0f60810624cb3c52341 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sending interface and index as changeCD parameters
by ahadas＠redhat.com 23 May '16

23 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Sending interface and index as changeCD parameters ...................................................................... core: Sending interface and index as changeCD parameters Modified ChangeDiskVDSCommand to support extended format of changeCD VDSM command that accepts driveSpec (interface name, index, ISO path) in place of just ISO path. Change-Id: I303bea437f71c712982e751e01be86539ebc96af Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ChangeDiskVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 10 files changed, 143 insertions(+), 34 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I303bea437f71c712982e751e01be86539ebc96af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0