[Engine-devel] Inconsistent model->entity mapping in VmSnapshotListModel
by Martin Betak
Hi all,
during some of my frontend patches I noticed that the properties
- singleQxlPci
- allowConsoleReconnect
- runAndPause
are not mapped from UnitVmModel to VM business entity in VmSnapshotListModel#onCloneVm method
while being mapped in all other fronted VM-related *ListModels (UserPortalListModel, VmListModel, TemplateListModel)
and also that the 'comment' property is not being mapped in UserPortalListModel#postVmNameUniqueCheck method.
Since I know that copy & pasting the appropriate setter to 6 different places when adding new VM property
can be tedious and very error prone I would like to ask the frontend maintainers if the above is desired behavior
or just bug caused by omission.
Best regards,
Martin
10 years, 10 months
[Engine-devel] oVirt 3.4.0 beta is now available
by Sandro Bonazzola
The oVirt team is pleased to announce that the 3.4.0 Release is now available in beta for testing.
Release notes and information on the changes for this update are still being worked on and will be available soon on the wiki[1].
Please ensure to follow install instruction from release notes if you're going to test it.
A new repository ovirt-3.4.0-prerelease has been added for delivering this beta and future refreshes until release candidate.
A new oVirt Node build will be available soon as well.
You're welcome to join us testing this beta release in tomorrow test day [2]!
[1] http://www.ovirt.org/OVirt_3.4.0_release_notes
[2] http://www.ovirt.org/OVirt_3.4_Test_Day
--
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
10 years, 10 months
[Engine-devel] find-bugs errors
by Einav Cohen
(1) @Moti: see [1] and [2]. it seems that they were caused by http://gerrit.ovirt.org/#/c/23507/
(2) @Vojtech[/UI Maintainers/others]: see [3] - it seems that the UI's AppErrors.java file
became too large for find-bugs to handle. Any ideas on how to handle this (add to ignore list/
divide to several files/...)?
[1] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsR...
[2] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsR...
[3] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsR...
----- Forwarded Message -----
From: "Jenkins ci oVirt Server" <jenkins(a)ovirt.org>
To: engine-patches(a)ovirt.org, fsimonce(a)redhat.com
Sent: Tuesday, January 21, 2014 4:11:24 PM
Subject: [Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6308 - Still Unstable!
Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/
Build Number: 6308
Build Status: Still Unstable
Triggered By: Started by an SCM change
-------------------------------------
Changes Since Last Success:
-------------------------------------
Changes for Build #6301
[Moti Asayag] engine: Extract AddNetworksByLabelParametersBuilder
[Moti Asayag] engine: Support attaching two labeled networks to a cluster
[Moti Asayag] engine: Extract RemoveNetworksByLabelParametersBuilder
[Moti Asayag] engine: Support detaching two labeled networks from a cluster
[Lior Vernia] webadmin: Replaced "Profiles" by "vNIC Profiles"
Changes for Build #6302
[Sergey Gotliv] engine, dao: Introduce ISCSI Bond entity, tables and dao
[Sergey Gotliv] engine: Introduce commands to manage iscsi bonds entities
[Sergey Gotliv] engine: Setup multiple iscsi sessions with the iscsi target
Changes for Build #6303
[Sergey Gotliv] webadmin: Allow to configure ISCSI multipathing in the dc context
[Martin Perina] tools: Adds more validations to MAIL_PORT in notifier
[Moti Asayag] engine: Fix findbugs warnings about Map values iteration
[Lior Vernia] webadmin: Hide content widget of boot protocol label
Changes for Build #6304
[Lior Vernia] webadmin: Integrate VM icon into Add/Edit Network dialog
Changes for Build #6305
[Alexander Wels] webadmin: Double click collapse system tree
Changes for Build #6306
[Daniel Erez] restapi: del storage conn if domain creation fails
Changes for Build #6307
[Moti Asayag] restapi: Preserve labels when setup networks is sent
Changes for Build #6308
[Federico Simoncelli] core: set local storage domain format
-----------------
Failed Tests:
-----------------
No tests ran.
_______________________________________________
Engine-patches mailing list
Engine-patches(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
10 years, 10 months
[Engine-devel] Change in Engine user session timeout options
by Vojtech Szocs
Hi guys,
this is just a small update, patch [1] was merged recently into
master branch and also made its way into ovirt-engine-3.4 branch.
This patch removes UserSessionTimeOutInvalidationInterval config
option, so there's only UserSessionTimeOutInterval option now.
You can use it to customize Engine user session expiration, which
is 30 mins by default.
[1] http://gerrit.ovirt.org/#/c/23113/
Regards,
Vojtech
10 years, 10 months
[Engine-devel] Application URI - saved anywhere?
by Ori Liel
Hi,
RSDL lists the possible links that the user can activate in Rest-API. The URI of A link looks something like this:
"/ovirt-engine/api/vms/{vm:id}/start"
My question is about the prefix: "/ovirt-engine/api/". Until now RSDL was generated at run-time, under a running application server, and this prefix was received by querying for the base-uri of the current user's request. I'm in the process of enabling RSDL generation at build time, and thus won't have a request to get this URI from. I'm thinking to add this constant: "/ovirt-engine/api" somewhere in pom.xml files, and use it. Does that sound reasonable? (if not, why, and what do you think I should do instead?)
Thanks,
Ori.
10 years, 10 months
[Engine-devel] proposing Alexander Wels as an ovirt-engine UI maintainer
by Einav Cohen
Hello UI Maintainers,
I would like to propose Alexander Wels as an ovirt-engine UI maintainer.
Alexander started his ovirt involvement more than a year ago,
contributing over 100 patches (to 'master' alone), including the
branding mechanism, Frontend refactoring (cleanup, unit-tests, requests
retry mechanism, requests-aggregation mechanism), cross-GUI refresh
synchronization and low-resolutions support.
Your response would be appreciated.
Thanks in advance.
----
Regards,
Einav
10 years, 10 months
[Engine-devel] Copy reviewer scores on trivial rebase/commit msg changes
by Itamar Heim
I'd like to enable these - comments welcome:
1. label.Label-Name.copyAllScoresOnTrivialRebase
If true, all scores for the label are copied forward when a new patch
set is uploaded that is a trivial rebase. A new patch set is considered
as trivial rebase if the commit message is the same as in the previous
patch set and if it has the same code delta as the previous patch set.
This is the case if the change was rebased onto a different parent. This
can be used to enable sticky approvals, reducing turn-around for trivial
rebases prior to submitting a change. Defaults to false.
2. label.Label-Name.copyAllScoresIfNoCodeChange
If true, all scores for the label are copied forward when a new patch
set is uploaded that has the same parent commit as the previous patch
set and the same code delta as the previous patch set. This means only
the commit message is different. This can be used to enable sticky
approvals on labels that only depend on the code, reducing turn-around
if only the commit message is changed prior to submitting a change.
Defaults to false.
https://gerrit-review.googlesource.com/Documentation/config-labels.html
10 years, 10 months
[Engine-devel] Fast Forward or Rebase if necessary policies
by Itamar Heim
Today we use the 'fast forward only' policy in gerrit.
It seems the 'rebase if necessary' policy may reduce some overhead, as
it will solve trivial rebases before the merge (it will fail on any
conflict, or any change to same file, even if no conflict).
I'm suggesting moving to try and move to 'rebase if necessary' for
ovirt-engine repo, and see if we think we are facing issues, or just
enjoying the benefits of not having to click merge, fail, rebase,
review+merge again.
the one caveat i can think of is if the patch is old, it should probably
be rebased for the various jenkins jobs to run on it again, but I think
for most patches that's not the case.
(vdsm is using an even less strict policy of cherry-pick)
thoughts?
Thanks,
Itamar
10 years, 10 months
