Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master

(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]). @Alexander - can you please take a look at it with Tomas and see what happened (original patch merged without running unit-tests / problem with the unit-test itself [1] / ...)? (b) non-English .properties files should typically not be modified as part of regular patches (i.e. patches that are not dedicated "translation updates" which include updates to the files pulled directly from Zanata). *However*, there is one exception for that, and the exception is compilation error that happens due to the reason that you mentioned above - changes in English message variable-placeholders. In this case - the patch author must change the matching messages in the non- English .properties files to include the exact same variable-placeholders as the (updated) English message (i.e. remove placeholders / add placeholders as necessary). [1] http://lists.ovirt.org/pipermail/engine-commits/2014-October/018907.html