Re: [Engine-devel] Changing Gerrit -1 message
On 19/02/13 11:51, Ofer Schreiber wrote:
I feel that the current "-1 I would prefer that you didn't
submit this" message in Gerrit is pretty rude, as usually those -1 reviews are just
small fix-ups in the code itself.
I think 'I would prefer that you didn't' is fine, I'm not sure why
'submit this' and not 'merge this'.
Y.
Any thoughts about a more suitable "-1" message?
I thought about "-1 Please fix your code" or something similar.
Thanks,
Ofer Schreiber
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel