[ovirt-devel] diskunmap hooks and oVirt Node

Hi, we just got Bug 1638317 <https://bugzilla.redhat.com/show_bug.cgi?id=1638317> - "missing VDSM hook diskunmap in Node NG releases" opened as a bug, not an RFE, because "Pass discard from guest to underlying storage <https://www.ovirt.org/develop/release-management/features/storage/pass-di... features introduced in oVirt 4.1 is not yet implemented for Cinder storage, for which Bug 1440230 <https://bugzilla.redhat.com/show_bug.cgi?id=1440230> - "[RFE] Allow "Pass discard from guest to underlying storage" for Cinder. " has been opened. I'm writing to people involved in the hook introduction ( https://gerrit.ovirt.org/#/c/29770/) to understand how safe is to include the hook in oVirt Node as default installed hook. I understand that the hook is going to add "discard=unmap" always, not only on Cinder. I don't know the implications of it being enabled other than supposedly fix the issue with Cinder storage. Looking at the feature page looks like this won't work with NFS storage, but other than not working, will it cause issues? I see Bug 1440230 <https://bugzilla.redhat.com/show_bug.cgi?id=1440230> is un-targeted, is there any plan to get it into oVirt 4.3? We support Cinder/Ceph since 3.6 and pass discard is supported since 4.1, not sure about what prevented the pass discard to be implemented for Cinder as well in 4.1. Can someone elaborate? Thanks, -- SANDRO BONAZZOLA MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV Red Hat EMEA <https://www.redhat.com/> sbonazzo(a)redhat.com <https://red.ht/sig> <https://www.redhat.com/en/events/red-hat-open-source-day-italia?sc_cid=70...