[Engine-devel] synthetic-access
by Laszlo Hornyak
Hi,
I am reviewing Allon's patches (e.g. http://gerrit.ovirt.org/#patch,sidebyside,2188,11,backend/manager/modules... ) and this is the first time I have met @SuppressWarnings("synthetic-access") annotations in the ovirt code. It is right, eclipse warns about the performance problem synthetic access (if turned on, by default it is turned off). This mostly happens in DAO's because rowmappers are private inner classes. What if, instead of adding an annotation to ignore this
- we could make the rowmapper classes package protected?
- or since most of these classes are stateless and thread safe, we can add a public final static rowmapper instance and instead of instantiating the rowmapper over and over again, use that single instance.
Please share your thoughts.
Thank you,
Laszlo
13 years
[Engine-devel] My experience using the UI
by Saggi Mizrahi
I recently had to use the Engine UI (GWT one).
The UI in my opinion is very unintuitve and, at some flows, even counter productive.
It took me a lot more time to figure out how to do even the simplest tasks.
Lets start with the rudimentary things.
These are agreed upon UI idioms that are not used currently thus causing needless confusion.
These idioms are ingrained into how users grasp a UI when they first it.
I did not invent these they are written in various Windows\MacOS\KDE\Gnome and many other UI\HI guidelines.
This is not a complete list of all the problems, just the things that annoyed me the most.
* Buttons\menu items that spawn dialog windows should end with an ellipsis ("edit..." vs "remove").
* Grayed out means disabled not "not selected" (eg. the domain creation dialog->the lun chooser).
* Never write things vertically only horizontally (eg. the domain creation dialog).
* The entire object be clickable not only the text (tabs).
* Clickable items should be either underlined in another color, or inside a box to differentiated between regular text (menu items).
* Buttons should be in the same group should be in the same width and height and the entire area clickable.
* Border toggling cannot be used as hover indicator only background and/or text color toggle.
* Don't use "/" in the column header."host/ip" should be "Host address"
* Everything should be arranged in relative proportions (The search bar looks weird on large screens)
* Everything about the error message windows
* Try and scale the browser window to 800x600 and see what happens.
* Icons that don't have text next to them have to have a tool tip (bookmark search icon)
* (This one is my personal preference) Everything that is clickable should have hover toggle that shows what is the entire object you are clicking.
* Color scheme!!! alerts(red on gray?) Where does the green on the logo fit into all of this?
There are tools to help you create an eye pleasing color scheme (eg. http://colorschemedesigner.com/)
Now that the basics are out of the way. These are my opinions and are debatable.
- Top panel:
* current user name should be next to the sign-out not on opposite ends of list.
* About and guide could be merged to "help" Non of them deserve that much prominence in the UI
* Configure? What who? Find somewhere contextual to put it.
- search:
This is a long standing gripe against the UI.
* First and foremost it doesn't work properly. Try navigating the Tree and then editing the search bar.
* The browser already has a bookmarks feature so reusing the name is confusing, maybe saved views? perspectives? I don't know.
* The search bar is change when I navigate, This is confusing. Imagine having the gmail search bar change when you navigate gmail.
To fix this I suggest that the search bar remains empty unless the user starts using it and the bookmark button moved to a place where it's obvious it relates to the current view\perspective.
- The Tree
* Tree? Really? Is that a proper title?
* Tree refresh annoyingly does collapse all
- Events
* What is the difference between the button on the right and the one on the bottom?
* I'd rather it'd be called log\messages because these are not really events
- All tabs
* The difference between "guide me" and "edit" is confusing and arbitrary.
* Buttons in the toolbar should be grouped, and spaced according to those groups.
* Buttons should utilized the above general UI guidelines
* Similar buttons like "run" and "run Once" or "new desktop" and "new server" might be better displayed as drop down button (http://bit.ly/xMAUbK)
* Stuff on less importance like "change CD" could be grouped under a drop down button as well so it's less cluttered.
* Paging is so 2000, everyone does continues scroll now (http://bit.ly/a8B9UC).
- Guide Me:
Does not guide and is utterly confusing.
* Some buttons are grayed out but you have no idea why until you figure out that there is a hint hidden in the tooltip (An allusion to XKCD?)
* Can't use existing entities! Only create new ones. Why?
* "Optional actions"? Really?
* "There are still unconfigured entities". What? I don't understand what is wrong. Unconfigured isn't even a proper word. Do you mean that I still have entities to set-up? What entities? What is an entity?
* "Configure later"? What is wrong with "close".
* Again, unify with edit, I kept clicking edit even after I realized that I need to click guide me.
Pet peeves:
* The green line under the black part of the top bar is just annoying.
* CPU Name -> CPU Architecture( name)?
* destroy (in storage domain) -> force remove
There are a lot more things that could be stream lined.
The lun selection screen for example is just plain confusing.
But that would require me to start drafting mockups and I have a lot of other work to do.
I recommend reading at least the WinXP and Apple HIG guidelines (http://bit.ly/djCHb8).
Finally when in doubt copy Google, they have the an excellent web UX team.
13 years
[Engine-devel] Agenda for todays meeting
by Livnat Peer
Hi All,
Today we'll discuss the following:
- Summary of mailing list discussions on networking: VM network and
optional network.
- Floating disks
- Snapshot behavior (and live snapshot if time allows)
Thanks, Livnat
13 years
[Engine-devel] Problem with log4j
by Juan Hernandez
Hello,
A patch related to log4j that I created was recently merged (commit
8ee5c9bb46bbff7a624a84a07ee6b2f9fa4ec9d4) and apparently is causing a
problem during the deployment of the engine for some developers (Moti
Asayag pointed that to me).
If you find this when deploying the engine:
Caused by: java.lang.NoClassDefFoundError: org/apache/log4j/Level
Them I am to be blamed and the short term solution is to undo part of my
patch in the root pom.xml file:
--- a/pom.xml
+++ b/pom.xml
@@ -244,7 +244,6 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<version>${log4j.version}</version>
- <scope>provided</scope>
</dependency>
</dependencies>
</dependencyManagement>
I can't reproduce this myself, so please let me know if you find it. If
this is common I think that the long term solution would be to add log4j
to the list of dependencies of the affected EJB:
--- a/backend/manager/modules/beans/scheduler/pom.xml
+++ b/backend/manager/modules/beans/scheduler/pom.xml
@@ -51,7 +51,7 @@
<addClasspath>false</addClasspath>
</manifest>
<manifestEntries>
-
<Dependencies>org.slf4j,deployment.engine.ear.engine-vdsbroker.jar</Dependencies>
+
<Dependencies>org.slf4j,org.apache.log4j,deployment.engine.ear.engine-vdsbroker.jar</Dependencies>
</manifestEntries>
</archive>
</configuration>
Regards,
Juan Hernandez
--
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
13 years
[Engine-devel] final fields on entities sent to client
by Tomas Jelinek
Hi all,
as the same entities as the ones used on the server are also sent to the client
(e.g. org.ovirt.engine.core.common.businessentities.VM), this entities will than
be serialized/deserialized using the GWT serialization. It means, this entities
should follow the restrictions given by the GWT serialization:
http://code.google.com/webtoolkit/doc/latest/DevGuideServerCommunication....
>From it I would like to point out this:
"Fields that are declared final are also not exchanged during RPCs, so they should generally be marked transient as well."
It means, that no fields which will be sent to client should be marked with the final keyword.
Thanks,
Tomas
13 years
[Engine-devel] [oVirt Jenkins] Dao test fails due to latest commits
by Eyal Edri
FYI,
there is a new failure in dao tests on jenkins.ovirt.org:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/lastCompletedBui...
Test: org.ovirt.engine.core.dao.DiskImageDAOTest.testSave
latest commits (that may have caused this):
Changes
engine: Add pre defined roles for consume quota (detail / gitweb)
engine: Create default unlimited quota for DC (detail / gitweb)
engine: Add quota to audit log (detail / gitweb)
engine: Add validation for quota name (detail / gitweb)
engine: Add/Edit quota commands (detail / gitweb)
engine: Remove quota command (detail / gitweb)
engine: Add quota id to VM parameters (detail / gitweb)
engine: Add quota id to disk image (detail / gitweb)
engine: Add quota id to vm static (detail / gitweb)
frontend: Add business entities to sharedGWT (detail / gitweb)
engine: Add search support for quota. (detail / gitweb)
engine: Add audit log messages (detail / gitweb)
engine: Add audit log messages to CRUD commands. (detail / gitweb)
engine: Adding fix to quota stored procedure (detail / gitweb)
engine: Add quota manager class (detail / gitweb)
engine: Add quota validation support commandBase (detail / gitweb)
engine: Add quota validation for AddVmCommand (detail / gitweb)
engine: Add quota validation for Add Disk to VM (detail / gitweb)
engine: Add quota validation for Add Vm Tempalte (detail / gitweb)
engine:Add quota validation for RunVmCommand (detail / gitweb)
Please check,
Eyal Edri
oVirt Infrastructure Team
13 years
