importing fixtures in ovirt-system-tests
by Yedidyah Bar David
Hi all,
We have several different styles of where/how to import fixtures in
ovirt-system-tests:
- import directly inside the test code
- import in conftest.py
- import in fixtures modules
- For all of above, both 'import *' and importing specific fixtures
I think we should try to agree on a specific style and then follow it.
One drawback of importing directly in test/fixtures code is that it's
then impossible to override them in conftest.py.
A drawback of importing '*' and/or doing this in conftest.py is that
you might inadvertently import more than you want, or this might
happen eventually (after more stuff are added), that this makes it
harder to find what uses what, and that it risks unintended collisions
in names - as opposed to intended overrides.
A related issue is having to update many places if you add/change something.
If there is some kind of "best practices" document somewhere that
people are happy with, perhaps we should follow it. Otherwise, we
should come up with our own.
Personally I think I'd like to have a single file with all the
imports, of specific fixtures (not '*'), and import this file from
conftest.py of all the suites. Didn't actually try this and no idea
what complications it might bring.
Comments/ideas/opinions/decisions are welcome :-)
Best regards,
--
Didi
1 year, 7 months
ppc64le mock environment is broken
by Sandro Bonazzola
Looking at
https://jenkins.ovirt.org/blue/organizations/jenkins/ovirt-release_standa...
It shows:
# /usr/bin/yum --installroot
/var/lib/mock/centos-stream-8-ppc64le-6cf77c626743751e199a195f6b050912-bootstrap-10125/root/
--releasever 8 install dnf dnf-plugins-core --setopt=tsflags=nocontexts
command being executed and failing with:
[2021-07-07T15:18:32.577Z] --> Finished Dependency Resolution
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python(abi) = 3.6
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python3-libdnf >= 0.61.1
[2021-07-07T15:18:32.577Z] Error: Package:
1:python3-dateutil-2.6.1-6.el8.noarch (centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python(abi) = 3.6
[2021-07-07T15:18:32.577Z] Error: Package:
python3-dnf-plugins-core-4.0.21-1.el8.noarch (centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python3-dbus
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python3-libcomps >= 0.1.8
[2021-07-07T15:18:32.577Z] Error: Package: dnf-data-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: libreport-filesystem
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: libmodulemd >= 2.9.3
[2021-07-07T15:18:32.577Z] Error: Package:
python3-dnf-plugins-core-4.0.21-1.el8.noarch (centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python(abi) = 3.6
[2021-07-07T15:18:32.577Z] Error: Package:
python3-dnf-plugins-core-4.0.21-1.el8.noarch (centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python3-hawkey >= 0.46.1
[2021-07-07T15:18:32.577Z] Error: Package: dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: /bin/sh
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.577Z] Requires: python3-rpm >= 4.14.2-35
[2021-07-07T15:18:32.577Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.578Z] Requires: python3-hawkey >= 0.61.1
[2021-07-07T15:18:32.578Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.578Z] Requires: python3-libdnf
[2021-07-07T15:18:32.578Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.578Z] Requires: /usr/libexec/platform-python
[2021-07-07T15:18:32.578Z] Error: Package: python3-six-1.11.0-8.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.578Z] Requires: python(abi) = 3.6
[2021-07-07T15:18:32.578Z] Error: Package: python3-dnf-4.7.0-1.el8.noarch
(centos-base-el8stream)
[2021-07-07T15:18:32.578Z] Requires: python3-gpg
[2021-07-07T15:18:32.578Z] You could try using --skip-broken to work
around the problem
[2021-07-07T15:18:32.578Z] You could try running: rpm -Va --nofiles
--nodigest
I initially thought it was a repo issue on centos stream side and reported
it at https://bugzilla.redhat.com/show_bug.cgi?id=1979601
But it sorted out it's a CI configuration issue. The proof repositories are
fine:
LC_ALL=C sudo dnf --disablerepo=* --repofrompath=baseos1,
http://mirror.centos.org/centos/8/BaseOS/ppc64le/os/ --enablerepo=baseos1
--releasever=8 --installroot=/tmp/test --nogpgcheck install :qdnf
dnf-plugins-core --setopt=tsflags=nocontexts --setopt=arch=ppc64le
correctly install the needed packages.
This is blocking CI on ppc64le architecture.
--
Sandro Bonazzola
MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV
Red Hat EMEA <https://www.redhat.com/>
sbonazzo(a)redhat.com
<https://www.redhat.com/>
*Red Hat respects your work life balance. Therefore there is no need to
answer this email out of your office hours.*
1 year, 7 months