VDSM have moved to github
by Nir Soffer
We are not using the gerrit project now, and it was changed to read-only.
We are accepting now pull requests on github:
https://github.com/oVirt/vdsm/pulls
To contribute, use the standard github flow:
1. Fork vdsm on github
Example: https://github.com/nirs/vdsm
(you need to create a github account if you don't have one)
2. Clone your fork
Example: git clone git@github.com:nirs/vdsm.git
3. Push changes to your fork and submit pull requests
Example: https://github.com/oVirt/vdsm/pull/28
4. Check the github CI for your pull request
Example: https://github.com/oVirt/vdsm/pull/28/checks
Note: We don't do squash merges. When addressing comments, force push
to your fork.
Example: https://github.com/oVirt/ovirt-imageio/pull/15
Common issues:
1. How do I add reviewers to my pull request?
Once https://github.com/oVirt/vdsm/pull/28 will be merged, we will have
a CODEOWNERS file:
https://github.com/oVirt/vdsm/blob/96320682a8b41e440fbbb8ca624fd73efa95bd...
so github will assign reviews automatically.
Regardless you can add a comment on you patch like:
@{reviewer} please review.
2. How do I run OST with my pull request?
OST does not run yet automatically. You have 2 choices:
- Run OST locally (ask here how to run it)
- Use the Red Hat OST runner
(ask on rhev-devel(a)redhat.com how to use it)
When running OST, you can use the built rpms from your pull request:
https://github.com/oVirt/vdsm/actions/runs/1673718827
(see the artifacts.zip at the bottom)
3. How to backport a patch to stable branches?
Backport your patch(es) on top of the right stable branch (e.g. ovirt-4.4.z).
When you create a pull request, please choose the right branch.
The stable branches maintainers will be added for review automatically.
4. How to compare changes when a contributor submitted a new version?
When contributor force pushes, github shows:
nirs *force-pushed* the inactivity-timeout branch 2 times, most
recently from *790cc4c* to *38d08c8* 22 days ago
Click the "force-pushed" link to see the differences:
https://github.com/oVirt/ovirt-imageio/compare/790cc4c44c9c6577dae0badb3f...
5. How to download a pull request to my machine?
You can use the github command lline tool "gh":
gh pr checkout 28
See https://cli.github.com/ for more info.
(note: I did not try it yet)
6. How do I comment on commit message?
Github does not have this feature, you can use the review comment, or
add a separate
comment.
7. How to run CI on a single patch in my PR?
Github runs the CI for the entire PR. If your PR have several commits,
issues in early commits
fixed in later commits are hidden. To verify that all commits pass the
tests you can post the
submit a new branch to your local fork.
Example flow:
git checkout -b testing-foobar commit-id
git push origin testing-foobar
(check CI on your fork)
Alternatively, use smaller pull requests. You can submit pull request
based on another pull
request.
Nir
7 months
Need help in dumping a table
by Matthew.Stier＠fujitsu.com
I'm planning a re-organization of my oVirt environment.
I need a Postgres command-line to dump a listing of VMs/disks/storage_domains.
7 months
Cannot build Engine rpm's on CentOS Stream 8
by Milan Zamazal
Hi,
I've been having trouble to build Engine rpm's locally on up-to-date
Stream 8 since about mid December, most likely due to javapackages-local
update to 6.0.0-1.4.el8s. Engine compiles fine but building the rpm's
fails on missing %add_maven_depmap rpm spec macro. There is a patch for
Stream 9: https://gerrit.ovirt.org/c/ovirt-engine/+/116811. But when I
rebase on it, I get the following error:
[INFO maven.req] input: ['/root/rpmbuild/BUILDROOT/ovirt-engine-4.5.0-0.2.master.20220104124402.el8.x86_64/usr/share/maven-metadata/ovirt-engine-base.xml']
Traceback (most recent call last):
File "/usr/lib/rpm/maven.req", line 393, in <module>
builder = TagBuilder()
File "/usr/lib/rpm/maven.req", line 71, in __init__
self.print_requires(metadata)
File "/usr/lib/rpm/maven.req", line 200, in print_requires
self._handle_unknown_deps(unknown_deps)
File "/usr/lib/rpm/maven.req", line 258, in _handle_unknown_deps
raise Exception(unknown_msg)
Exception: Following dependencies were not resolved and requires cannot be generated. Either remove the dependencies from pom.xml or add proper packages to BuildRequires:
commons-beanutils:commons-beanutils:1.9.4 required by org.ovirt.engine.core:utils
commons-lang:commons-lang:2.6 required by org.ovirt.engine.core:aaa
org.infinispan:infinispan-core:9.4.18.Final required by org.ovirt.engine.core:utils
commons-collections:commons-collections:3.2.2 required by org.ovirt.engine.core:bll
org.jboss.modules:jboss-modules:1.1.1.GA required by org.ovirt.engine.core:common
org.hibernate.validator:hibernate-validator:6.0.18.Final required by org.ovirt.engine.core:common
This happens with both maven 3.5 and 3.6. Any idea what's wrong and how
to fix it on Stream 8?
Thanks,
Milan
7 months
Re: [oVirt/ovirt-release] Failed repoclosure job (Issue #60)
by Yedidyah Bar David
On Wed, Jan 5, 2022 at 1:09 PM github-actions[bot] <notifications(a)github.com>
wrote:
> ❌ The repoclosure CI job is still failing. Please investigate.
> <https://github.com/oVirt/ovirt-release/actions/runs/1658041750>
>
It failed because we recently started building metrics and dwh on el9,
which require stuff we do not have:
- The engine, already discussed elsewhere, patches are WIP (apparently
waiting for Artur? Not sure).
- ansible. No idea why it's missing.
Perhaps better not build new stuff on el9 before we fix these, or stop
running repoclosure on el9 for now.
Best regards,
--
Didi
7 months
create a host using ssh
by Grace Chen
I am writing a script to create a host using public ssh key
the function I am using is add_using_ssh:
my ssh_key is a an Ssh type already
ssh_key = types.Ssh(public_key=my_ssh_key_string)
host = hosts_service.add_using_ssh(
types.Host(
name=name,
description='',
address=address,
root_password=None,
port=22,
ssh=ssh_key,
cluster=types.Cluster(
name=cluster,
),
),
)
When I choose from GUI, it doesn't ask me to put in root password, so I set
it as None (Not sure if this is correct)
I got error:
ovirtsdk4.Error: Fault reason is "Request syntactically incorrect.". Fault
detail is "For correct usage, see:
ovirt-engine/apidoc#services/hosts/methods/add". HTTP response code is 400.
looks like I didn't get all the parameters assigned?
Can anybody help with this?
7 months
