--Apple-Mail=_599C56CC-5DA3-4156-9A55-1ECEB68E2FF4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
On May 18, 2016, at 1:23 PM, Dan Kenigsberg <danken(a)redhat.com>
wrote:
=20
On Tue, May 17, 2016 at 08:44:11AM +0200, Piotr Kliczewski wrote:
> Nir,
>=20
> The warnings were added to annoy people so we could keep the schema =
align
> with the code.
> I think that we should use this opportunity to push fixes instead of
> disabling it.
>=20
> Thanks,
> Piotr
>=20
> On Mon, May 16, 2016 at 10:09 PM, Nir Soffer <nsoffer(a)redhat.com> =
wrote:
>=20
>> Hi all,
>>=20
>> Since data verification patches were merged, vdsm logs is spammed =
with
>> useless warnings (see bellow).
>>=20
>> This spam make it harder to debug vdsm.
>>=20
>> Please add configuration variable to enable this warnings, and make
>> them disabled by default.
>>=20
>> Thanks,
>> Nir
>>=20
>> ----
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,719::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Following parameters ['ksmMergeAcrossNodes', 'haStats'] were not
>> recognized
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter cpuUserVdsmd is not float type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter rxRate is not float type
=20
I'm officially annoyed ;-)
we can stop report rxRate and txRate now, as engine-3.6 computes them =
on
its own.
=20
Marcin, can you drop them from the code and schema?
=20
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter cpuLoad is not float type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter memUsed is not uint type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter cpuIdle is not float type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter txRate is not float type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter txDropped is not uint type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter elapsedTime is not uint type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter netConfigDirty is not boolean type
>> jsonrpc.Executor/0::WARNING::2016-05-16
>> 23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsistency)
>> Parameter rxErrors is not uint type
=20
Piotr, how can we specify in the schema the very common type of =
"string
that happens to include only unsigned decimal number=E2=80=9D?
I remember that we talked about that with Piotr and that the best =
solution would be a custom type for that, so that it can be checked
e.g. struint and strint as types, that means that those are integers =
(signed/unsigned however passed as string) (Due to historical XMLRPC =
reasons)
=20
_______________________________________________
Devel mailing list
Devel(a)ovirt.org <mailto:Devel@ovirt.org>
http://lists.ovirt.org/mailman/listinfo/devel =
<
http://lists.ovirt.org/mailman/listinfo/devel>
--Apple-Mail=_599C56CC-5DA3-4156-9A55-1ECEB68E2FF4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=utf-8
<html><head><meta http-equiv=3D"Content-Type"
content=3D"text/html =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" =
class=3D""><br class=3D""><div><blockquote
type=3D"cite" class=3D""><div =
class=3D"">On May 18, 2016, at 1:23 PM, Dan Kenigsberg <<a =
href=3D"mailto:danken@redhat.com"
class=3D"">danken(a)redhat.com</a>&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div
class=3D""><span =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">On Tue, May 17, 2016 at 08:44:11AM +0200, Piotr
=
Kliczewski wrote:</span><br style=3D"font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: =
normal; letter-spacing: normal; orphans: auto; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; widows: =
auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><blockquote type=3D"cite" style=3D"font-family:
Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D"">Nir,<br class=3D""><br
class=3D"">The warnings were added to =
annoy people so we could keep the schema align<br class=3D"">with the =
code.<br class=3D"">I think that we should use this opportunity to push =
fixes instead of<br class=3D"">disabling it.<br
class=3D""><br =
class=3D"">Thanks,<br class=3D"">Piotr<br
class=3D""><br class=3D"">On =
Mon, May 16, 2016 at 10:09 PM, Nir Soffer <<a =
href=3D"mailto:nsoffer@redhat.com"
class=3D"">nsoffer(a)redhat.com</a>&gt; =
wrote:<br class=3D""><br class=3D""><blockquote
type=3D"cite" =
class=3D"">Hi all,<br class=3D""><br
class=3D"">Since data verification =
patches were merged, vdsm logs is spammed with<br class=3D"">useless =
warnings (see bellow).<br class=3D""><br class=3D"">This
spam make it =
harder to debug vdsm.<br class=3D""><br class=3D"">Please
add =
configuration variable to enable this warnings, and make<br =
class=3D"">them disabled by default.<br class=3D""><br =
class=3D"">Thanks,<br class=3D"">Nir<br
class=3D""><br class=3D"">----<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,719::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Following parameters ['ksmMergeAcrossNodes', =
'haStats'] were not<br class=3D"">recognized<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter cpuUserVdsmd is not float type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter rxRate is not float type<br =
class=3D""></blockquote></blockquote><br
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: =
0px;" class=3D""><span style=3D"font-family: Helvetica;
font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">I'm officially annoyed
;-)</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
float: none; display: inline !important;" class=3D"">we can stop report
=
rxRate and txRate now, as engine-3.6 computes them on</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
float: none; display: inline !important;" class=3D"">its
own.</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><br
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: =
0px;" class=3D""><span style=3D"font-family: Helvetica;
font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">Marcin, can you drop them from the code
=
and schema?</span><br style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><blockquote
type=3D"cite" =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><blockquote
type=3D"cite" =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter cpuLoad is not float type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter memUsed is not uint type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,720::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter cpuIdle is not float type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter txRate is not float type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter txDropped is not uint type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter elapsedTime is not uint type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter netConfigDirty is not boolean type<br =
class=3D"">jsonrpc.Executor/0::WARNING::2016-05-16<br =
class=3D"">23:05:21,721::schemaapi::140::SchemaCache::(_report_inconsisten=
cy)<br class=3D"">Parameter rxErrors is not uint type<br =
class=3D""></blockquote></blockquote><br
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: =
0px;" class=3D""><span style=3D"font-family: Helvetica;
font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">Piotr, how can we specify in the schema
=
the very common type of "string</span><br style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: =
0px;" class=3D""><span style=3D"font-family: Helvetica;
font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">that happens to include only unsigned =
decimal number=E2=80=9D?</span><br style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""></div></blockquote><div><br
class=3D""></div><div>I remember =
that we talked about that with Piotr and that the best solution would be =
a custom type for that, so that it can be checked</div><div>e.g. struint =
and strint as types, that means that those are integers (signed/unsigned =
however passed as string) (Due to historical XMLRPC reasons)</div><br =
class=3D""><blockquote type=3D"cite"
class=3D""><div class=3D""><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
float: none; display: inline !important;" =
class=3D"">_______________________________________________</span><br
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
float: none; display: inline !important;" class=3D"">Devel mailing =
list</span><br style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><a =
href=3D"mailto:Devel@ovirt.org" style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D"">Devel(a)ovirt.org</a><br style=3D"font-family:
Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><a
href=3D"http://lists.ovirt.org/mailman/listinfo/devel" =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" =
class=3D"">http://lists.ovirt.org/mailman/listinfo/devel<...
uote></div><br class=3D""></body></html>=
--Apple-Mail=_599C56CC-5DA3-4156-9A55-1ECEB68E2FF4--