[ovirt-devel] Re: OST failure, bad comment

OST failed, and posted unprocessed comment: OST Verified -1 Patch Set 1: Verified-1 https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 : OST https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/$OST_NUMBER failed with: $OST_MESSAGE https://gerrit.ovirt.org/c/vdsm/+/115642#message-b2993761_adbc1b6a Looking at: https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 It looks like environment issue: ERROR: Build step failed with exception java.lang.NullPointerException: no workspace from node hudson.slaves.DumbSlave[hpe-bl280g6-12...] which is computer hudson.slaves.SlaveComputer@2e2cb321 and has channel null So we have 2 issues: 1. If build fails, error is not handled properly producing bad comment 2. the actual build failure

The first issue should be handled by posting a better comment: OST build error: https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 And OST should not mark the patch as verified -1, since it did not run any test. Marking a patch as -1 means some tests have failed, and the author needs to check why. A build error means OST or CI maintainers need to check why the error happened.