Re: [ovirt-devel] Moving forward our frontend stack

----- Original Message ----- > From: "Vojtech Szocs" <vszocs(a)redhat.com&gt; > To: "Martin Betak" <mbetak(a)redhat.com&gt; > Cc: devel(a)ovirt.org, "Einav Cohen" <ecohen(a)redhat.com&gt;, "Alexander Wels=

> <gshereme(a)redhat.com&gt;, "Tomas Jelinek" <tjelinek(a)redhat.com&gt;, "Lior Ver=

> <derez(a)redhat.com&gt; > Sent: Thursday, August 28, 2014 5:38:04 PM > Subject: Re: Moving forward our frontend stack >=20 > Hey Martin! >=20 > I've just reviewed your patch, looks good overall. >=20 > Here are my thoughts: >=20 > * Jenkins CI fails on patch due to missing dependencies, > we need to provide following new dependencies in order > to proceed with the upgrade: > =20 > org.aspectj:aspectjweaver:1.8.2 > org.aspectj:aspectjrt:1.8.2 > com.google.gwt:gwt-user:2.6.1 > com.google.gwt:gwt-dev:2.6.1 > com.google.gwt:gwt-servlet:2.6.1 > com.google.gwt:2.6.1 > org.codehaus.mojo:gwt-maven-plugin:2.6.1 > com.gwtplatform:gwtp-processors:1.3.1 > com.gwtplatform:gwtp-mvp-client:1.3.1 > com.google.gwt.inject:gin:2.1.2 >=20 > Who will take charge of that? =20 I already spoke to David Caro about the jenkins failure of=20 patch http://gerrit.ovirt.org/#/c/32135/. It seems the files for appropriate versions are there but the files are corrupted. =20 Let us hope this can be resolved easier than Node.js :-)

=20 Best regards, =20 Martin =20 >=20 > * patch itself looks quite harmless (not too risky) >=20 > * consolidating Java source & target version across > frontend and backend is nice! >=20 > -> this means we could use Java 7 features > also on the frontend (Java/GWT) side >=20 > * TODO-GWT tags [1] proved to be helpful [2] >=20 > -> reminder to all UI maintainers to use TODO-GWT > tags whenever we have some GWT(P) workaround, > so that the future upgrade will be safer w.r.t. > existing code >=20 > [1] https://www.mail-archive.com/devel@ovirt.org/msg00761.html > [2] > http://gerrit.ovirt.org/#/c/32135/1/frontend/webadmin/modules/webadmin/=

>=20 > Regards, > Vojtech >=20 > PS: I went through GWT-Platform release notes, > found an interesting new feature in recent GWTP > release, worth investigating: >=20 > https://github.com/ArcBees/GWTP/wiki/Release-Notes > #346 : Map more than one name token to presenter >=20 >=20 > ----- Original Message ----- > > From: "Martin Betak" <mbetak(a)redhat.com&gt; > > To: devel(a)ovirt.org > > Cc: "Vojtech Szocs" <vszocs(a)redhat.com&gt;, "Einav Cohen" <ecohen@redhat=

> > "Alexander Wels" <awels(a)redhat.com&gt;, > > "Greg Sheremeta" <gshereme(a)redhat.com&gt;, "Tomas Jelinek" > > <tjelinek(a)redhat.com&gt;, "Lior Vernia" <lvernia(a)redhat.com&gt;, > > "Daniel Erez" <derez(a)redhat.com&gt; > > Sent: Thursday, August 28, 2014 4:11:10 PM > > Subject: Moving forward our frontend stack > >=20 > > Hello oVirt developers! > >=20 > > I have prepared patch [1] that upgrades our frontend stack > > to use GWT version 2.6.1 (from previous 2.5.1). > >=20 > > This patch also updates GIN to version 2.1.2 and GWT-P to 1.3.1 > >=20 > > Since GWT 2.6 features support for Java 7 it was possible to increment > > language levels of all projects stuck at Java 6 (common, compat, > > searchbackend > > and entire of frontend). > >=20 > > To facilitate emitting bytecode compatible with Java 7 also upgrade of > > AspectJ was > > necessary. This patch upgrades it to AspectJ 1.8 that features even s=

> > for > > Java 8 which will save effort when upgrading to GWT 2.7/3.0 in the fu=

> >=20 > > Most of the changes in the patch are due to upgrade of GWT-P - i.e. > > changing > > packages of TokenFormatter and PlaceRequest. > >=20 > > Overall this patch is *MUCH* simpler than the previous > > http://gerrit.ovirt.org/#/c/16739/ > > which facilitated upgrade from 2.3 to 2.5.1, and hopefully much less =

> >=20 > > I have tested draft-compile, debug-mode and also tried to use the res=

> > application > > manually for some time. So far everything worked (surprisingly well!)=

> > have not > > detected any defects. Of course I invite anyone to test this patch on=

> > own > > since > > it is and upgrade of our core infrastructure. > >=20 > > That having said I think is comparatively simple and the benefits out=

> > the risks > > if this upgrade is done at the beginning of ovirt-3.6 development cyc=

> >=20 > > Reviews, comments and testing are very welcome :-) > >=20 > > Best regards, > >=20 > > Martin > >=20 > > [1] http://gerrit.ovirt.org/#/c/32135/ > >=20 >=20

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUAEjZAAoJEEBxx+HSYmnDR4IH/34lwKCRu+B3HhgQ+sBZuaGp JlK6W+ZBghZh7fgshb71K079FJ2I7KIlbO3OTI8YOpGk9jGklHQOkFNpzGllJR0F M6cmgCE3zw4o+teO7pWycFusyzl32FWDXPUWfflpv2GV+uAnoctyN8oEuRJHAvFl 6zqalHQGZJvGHJQfuS5LunNtWluDpofSQFyvqtK+/PdEzgHuXkBdD9MxwOnsGtOM kElLbc4tzwX4YXvJirlvPf5bR/+oteW/stZ4AGb4ixVaMlb1v+xrMv29aPyYb3PO S7QL0SoWmiumjq1vZ6yTPItXzci666kKTBg/OpVeKfnU7T2zXZKlK5ow+1v7ltI= =n+g1 -----END PGP SIGNATURE-----