Re: [Engine-devel] Revisiting Java7
Hi,
----- Original Message -----
From: "Allon Mureinik" <amureini(a)redhat.com>
To: "engine-devel" <engine-devel(a)ovirt.org>
Sent: Monday, December 3, 2012 3:03:21 PM
Subject: [Engine-devel] Revisiting Java7
Hi guys,
Earlier today, Java6 compatibility was broken
(http://gerrit.ovirt.org/#/c/9430/).
This was picked up on pretty quickly, and easily fixed
(http://gerrit.ovirt.org/#/c/9666/).
However, I think this is a good opportunity to revisit our policy
towards Java 7.
Currently, we have an "odd" setup, where we recommend running a
compiling /with/ Java 7 [1] but comply to Java 6 language level [2]
and JDK [3].
Inevitably, mistakes like the that happened today will happen.
I know we're holding back due to GWT issues, but looking forward to
oVirt 4.0, is Java 7 on our roadmap?
Last time I checked the latest checkstyle, it did not work with java 7 syntax
unfortunately...
Theoretically checkstyle already supports java 7, probably they only forgot about the
maven plugin.
I think this is blocking the way from using java 7 in the code that we do not share with
GWT.
-Allon
[1] http://wiki.ovirt.org/Building_oVirt_engine#Installing_OpenJDK
[2] maven-compiler-plugin section in ${OVIRT_GIT}/pom.xml
[3] http://jenkins.ovirt.org/job/ovirt_engine_animal_sniffer_check/
P.S.
If you want to check that you aren't breaking Java/JDK 6
compatibility locally without installing java 6, you can run "mvn
animal-sniffer:check". Note that animal sniffer analyzes binaries,
so this has to be done /after/ the project was built. Of course, you
can do this in a single line "mvn install animal-sniffer:check"
Nice :)
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel