--Apple-Mail=_DDF4476C-5018-428D-BCC2-B11C1161B03A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8
On 13 Mar 2018, at 22:24, Dafna Ron <dron@redhat.com> wrote: =20 =20 =20 On Tue, Mar 13, 2018 at 10:57 AM, Michal Skrivanek = <michal.skrivanek@redhat.com <mailto:michal.skrivanek@redhat.com>> = wrote: =20 =20
On 13 Mar 2018, at 09:27, Eyal Edri <eedri@redhat.com = <mailto:eedri@redhat.com>> wrote: =20 =20 =20 On Tue, Mar 13, 2018 at 9:29 AM, Dan Kenigsberg <danken@redhat.com = <mailto:danken@redhat.com>> wrote: On Mon, Mar 12, 2018 at 8:24 PM, Dafna Ron <dron@redhat.com = <mailto:dron@redhat.com>> wrote:
We just had a failure in master 002_bootstrap.add_mac_pool with the = same error on edit cluster. =20 Does it fail consistently? =20 yes.=20
that=E2=80=99s good
=20 =20 Did you narrow down the commit(s) where it started to happen? =20 First change reported failed by CQ on this issue is this one: = https://gerrit.ovirt.org/#/c/88738/2 = <https://gerrit.ovirt.org/#/c/88738/2>=20 - db: add func to turn table columns to empty string (this was = reported by Daniel at the beginning of this thread) =20 Was there any other update done at that time? =20 there are always other changes submitted. but CQ tries to isolate the = change that it believes is causing the failure by reducing the change it = tests until it gets to one single change.=20
=20 =20 We cannot have OST keep failing for a long time, especially on a big =
=20 Thanks,=20 Dafna =20 =20 Thanks, michal =20
=
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6259/testRep= ort/(root)/002_bootstrap/add_mac_pool/ = <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6259/testRe=
I meant changes like major update of packages or any other configuration = change project like ovirt-engine. if we cannot have a fix on this quickly I = think we should start skipping failed tests to allow changes to pass = successfully until the bug is fixed.=20 sure. But in this case you=E2=80=99re just going to hit the same problem = in the next test. Please enable back the one you commented out, and try = to revert that patch instead. There is a chance it changed the behavior = because somehow the tests using Default cluster somehow rely on = undefined values (not sure if that=E2=80=99s even intentional, but = that=E2=80=99s the way it is written), and that patch may have changed = it perhaps. Eli? Thanks, michal port/%28root%29/002_bootstrap/add_mac_pool/>
either I skipped the wrong test or we have a bigger issue.
=20 We certainly do. As before, the error pops up on an attempt to update the cluster (this time it is changing only the mac pool of the cluster). CPU is not specified by the command, so it should not have changed at all. Still, something fills a CPU, and chooses a wrong value. =20 cluster_service.update( cluster=3Dsdk4.types.Cluster( mac_pool=3Dsdk4.types.MacPool( id=3Dpool.id <http://pool.id/>, ) ) ) =20 2018-03-12 13:58:56,263-04 WARN [org.ovirt.engine.core.bll.UpdateClusterCommand] (default task-19) [79d12090-a8e8-438c-bbce-1bf09a42c5fb] Validation of action 'UpdateCluster' failed for user admin@internal-authz. Reasons: = VAR__TYPE__CLUSTER,VAR__ACTION__UPDATE,ACTION_TYPE_FAILED_CPU_NOT_FOUND,VA= R__TYPE__CLUSTER 2018-03-12 13:58:56,264-04 INFO [org.ovirt.engine.core.bll.UpdateClusterCommand] (default task-19) [79d12090-a8e8-438c-bbce-1bf09a42c5fb] Lock freed to object 'EngineLock:{exclusiveLocks=3D'[]', sharedLocks=3D'[]'}' 2018-03-12 13:58:56,264-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-19) [79d12090-a8e8-438c-bbce-1bf09a42c5fb] method: runAction, params: [UpdateCluster, = ManagementNetworkOnClusterOperationParameters:{commandId=3D'bebe80f7-f8ca-= 4d01-aed8-28e463d0f435', user=3D'null', commandType=3D'Unknown'}], timeElapsed: 50ms 2018-03-12 13:58:56,269-04 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-19) [] Operation Failed: [Cannot edit Cluster. The chosen CPU is not supported.] =20 So I guess we can't skip this test as well, and this issue has to be = fixed right?=20 =20 =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 =20 =20 --=20 EYAL EDRI =20 MANAGER RHV DEVOPS EMEA VIRTUALIZATION R&D =20 Red Hat=C2=A0EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. = <https://redhat.com/trusted> phone: +972-9-7692018 <tel:+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ) _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20
--Apple-Mail=_DDF4476C-5018-428D-BCC2-B11C1161B03A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On 13 Mar 2018, at 22:24, Dafna Ron <<a = href=3D"mailto:dron@redhat.com" class=3D"">dron@redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote">On Tue, Mar 13, 2018 at 10:57 AM, = Michal Skrivanek <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:michal.skrivanek@redhat.com" target=3D"_blank" = class=3D"">michal.skrivanek@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = style=3D"overflow-wrap: break-word;" class=3D""><br class=3D""><div = class=3D""><span class=3D"gmail-"><br class=3D""><blockquote type=3D"cite"= class=3D""><div class=3D"">On 13 Mar 2018, at 09:27, Eyal Edri <<a = href=3D"mailto:eedri@redhat.com" target=3D"_blank" = class=3D"">eedri@redhat.com</a>> wrote:</div><br = class=3D"gmail-m_-1623607510736288965Apple-interchange-newline"><div = class=3D""><div dir=3D"ltr" class=3D""><br class=3D""><div = class=3D"gmail_extra"><br class=3D""><div class=3D"gmail_quote">On Tue, = Mar 13, 2018 at 9:29 AM, Dan Kenigsberg <span dir=3D"ltr" = class=3D""><<a href=3D"mailto:danken@redhat.com" target=3D"_blank" = class=3D"">danken@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span = class=3D"">On Mon, Mar 12, 2018 at 8:24 PM, Dafna Ron <<a = href=3D"mailto:dron@redhat.com" target=3D"_blank" = class=3D"">dron@redhat.com</a>> wrote:<br class=3D""> > We just had a failure in master 002_bootstrap.add_mac_pool with the = same<br class=3D""> > error on edit cluster.<br = class=3D""></span></blockquote></div></div></div></div></blockquote><div = class=3D""><br class=3D""></div></span>Does it fail = consistently?</div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">yes. <br = class=3D""></div></div></div></div></div></blockquote><div><br = class=3D""></div>that=E2=80=99s good</div><div><br class=3D""><blockquote = type=3D"cite" class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><div class=3D""><br = class=3D""> <br class=3D""></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div style=3D"overflow-wrap: = break-word;" class=3D""><div class=3D"">Did you narrow down the = commit(s) where it started to happen?</div></div></blockquote><div = class=3D""><br class=3D""></div><div class=3D"">First change reported = failed by CQ on this issue is this one: <a = href=3D"https://gerrit.ovirt.org/#/c/88738/2" target=3D"_blank" = class=3D"">https://gerrit.ovirt.org/#/c/<wbr class=3D"">88738/2</a><span = class=3D"gmail-"> <br class=3D""></span> - db: add func to turn = table columns to empty string (this was reported by Daniel at the = beginning of this thread)<br class=3D""></div><div class=3D""><br = class=3D""></div><blockquote class=3D"gmail_quote" style=3D"margin:0px = 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div style=3D"overflow-wrap: = break-word;" class=3D""><div class=3D"">Was there any other update done = at that time?</div><div class=3D""><br = class=3D""></div></div></blockquote><div class=3D"">there are always = other changes submitted. but CQ tries to isolate the change that it = believes is causing the failure by reducing the change it tests until it = gets to one single change. <br = class=3D""></div></div></div></div></div></blockquote><div><br = class=3D""></div>I meant changes like major update of packages or any = other configuration change<br class=3D""><blockquote type=3D"cite" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><div class=3D""><br = class=3D""><br class=3D""></div><div class=3D"">We cannot have OST keep = failing for a long time, especially on a big project like ovirt-engine. = if we cannot have a fix on this quickly I think we should start skipping = failed tests to allow changes to pass successfully until the bug is = fixed. <br class=3D""></div></div></div></div></div></blockquote><div><br = class=3D""></div>sure. But in this case you=E2=80=99re just going to hit = the same problem in the next test. Please enable back the one you = commented out, and try to revert that patch instead. There is a chance = it changed the behavior because somehow the tests using Default cluster = somehow rely on undefined values (not sure if that=E2=80=99s even = intentional, but that=E2=80=99s the way it is written), and that patch = may have changed it perhaps. Eli?</div><div><br = class=3D""></div><div>Thanks,</div><div>michal<br class=3D""><blockquote = type=3D"cite" class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><div class=3D""><br = class=3D""></div><div class=3D"">Thanks, <br class=3D""></div><div = class=3D"">Dafna<br class=3D""><br class=3D""></div><div = class=3D""> <br class=3D""></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div style=3D"overflow-wrap: = break-word;" class=3D""><div class=3D""></div><div = class=3D"">Thanks,</div><div class=3D"">michal</div><div class=3D""><div = class=3D"gmail-h5"><div class=3D""><br class=3D""></div><div = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><span class=3D""> ><br class=3D""> > <a = href=3D"http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6259= /testReport/%28root%29/002_bootstrap/add_mac_pool/" rel=3D"noreferrer" = target=3D"_blank" class=3D"">http://jenkins.ovirt.org/job/o<wbr = class=3D"">virt-master_change-queue-teste<wbr = class=3D"">r/6259/testReport/(root)/002_<wbr = class=3D"">bootstrap/add_mac_pool/</a><br class=3D""> ><br class=3D""> > either I skipped the wrong test or we have a bigger issue.<br = class=3D""> <br class=3D""> </span>We certainly do. As before, the error pops up on an attempt to = update<br class=3D""> the cluster (this time it is changing only the mac pool of the<br = class=3D""> cluster). CPU is not specified by the command, so it should not have<br = class=3D""> changed at all. Still, something fills a CPU, and chooses a wrong<br = class=3D""> value.<br class=3D""> <br class=3D""> cluster_service.update(<br class=3D""> cluster=3Dsdk4.types.Cluster(<br= class=3D""> = mac_pool=3Dsdk4.types.MacPool(<br class=3D""> = id=3D<a href=3D"http://pool.id/" rel=3D"noreferrer" target=3D"_blank" = class=3D"">pool.id</a>,<br class=3D""> )<br class=3D""> )<br class=3D""> )<br class=3D""> <br class=3D""> 2018-03-12 13:58:56,263-04 WARN<br class=3D""> [org.ovirt.engine.core.bll.Upd<wbr class=3D"">ateClusterCommand] = (default task-19)<br class=3D""> [79d12090-a8e8-438c-bbce-1bf09<wbr class=3D"">a42c5fb] Validation of = action<br class=3D""> 'UpdateCluster' failed for user admin@internal-authz. Reasons:<br = class=3D""> VAR__TYPE__CLUSTER,VAR__ACTION<wbr = class=3D"">__UPDATE,ACTION_TYPE_FAILED_<wbr = class=3D"">CPU_NOT_FOUND,VAR__TYPE__<wbr class=3D"">CLUSTER<br class=3D"">= 2018-03-12 13:58:56,264-04 INFO<br class=3D""> [org.ovirt.engine.core.bll.Upd<wbr class=3D"">ateClusterCommand] = (default task-19)<br class=3D""> [79d12090-a8e8-438c-bbce-1bf09<wbr class=3D"">a42c5fb] Lock freed to = object<br class=3D""> 'EngineLock:{exclusiveLocks=3D'[<wbr class=3D"">]', = sharedLocks=3D'[]'}'<br class=3D""> 2018-03-12 13:58:56,264-04 DEBUG<br class=3D""> [org.ovirt.engine.core.common.<wbr = class=3D"">di.interceptor.DebugLoggingInt<wbr class=3D"">erceptor]<br = class=3D""> (default task-19) [79d12090-a8e8-438c-bbce-1bf09<wbr class=3D"">a42c5fb] = method:<br class=3D""> runAction, params: [UpdateCluster,<br class=3D""> ManagementNetworkOnClusterOper<wbr = class=3D"">ationParameters:{commandId=3D'be<wbr = class=3D"">be80f7-f8ca-4d01-aed8-28e463d0<wbr class=3D"">f435',<br = class=3D""> user=3D'null', commandType=3D'Unknown'}], timeElapsed: 50ms<br class=3D"">= 2018-03-12 13:58:56,269-04 ERROR<br class=3D""> [org.ovirt.engine.api.restapi.<wbr = class=3D"">resource.AbstractBackendResour<wbr class=3D"">ce]<br = class=3D""> (default task-19) [] Operation Failed: [Cannot edit Cluster. The<br = class=3D""> <span class=3D"gmail-m_-1623607510736288965im = gmail-m_-1623607510736288965HOEnZb">chosen CPU is not supported.]<br = class=3D""></span></blockquote><div class=3D""><br class=3D""></div><div = class=3D"">So I guess we can't skip this test as well, and this issue = has to be fixed right? </div><div class=3D""><br = class=3D""></div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex"><span = class=3D"gmail-m_-1623607510736288965im = gmail-m_-1623607510736288965HOEnZb"> </span><div class=3D"gmail-m_-1623607510736288965HOEnZb"><div = class=3D"gmail-m_-1623607510736288965h5">______________________________<wb= r class=3D"">_________________<br class=3D""> Devel mailing list<br class=3D""> <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""> <a href=3D"http://lists.ovirt.org/mailman/listinfo/devel" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman<wbr = class=3D"">/listinfo/devel</a><br class=3D""> </div></div></blockquote></div><br class=3D""><br clear=3D"all" = class=3D""><div class=3D""><br class=3D""></div>-- <br class=3D""><div = class=3D"gmail-m_-1623607510736288965gmail_signature"><div dir=3D"ltr" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D""><div dir=3D"ltr" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D""><div = style=3D"font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:= 14px;text-transform:uppercase;font-weight:bold" class=3D""><font = color=3D"#cc0000" class=3D"">Eyal edri</font></div><div = style=3D"font-family:overpass,sans-serif;font-weight:bold;margin:0px;paddi= ng:0px;font-size:14px;text-transform:uppercase" class=3D""><br = class=3D""></div><p = style=3D"font-family:overpass,sans-serif;font-size:10px;margin:0px 0px = 4px;text-transform:uppercase" class=3D"">MANAGER</p><p = style=3D"font-family:overpass,sans-serif;font-size:10px;margin:0px 0px = 4px;text-transform:uppercase" class=3D"">RHV DevOps</p><p = style=3D"font-family:overpass,sans-serif;font-size:10px;margin:0px 0px = 4px;text-transform:uppercase" class=3D"">EMEA VIRTUALIZATION = R&D</p><p = style=3D"font-family:overpass,sans-serif;font-size:10px;margin:0px 0px = 4px;text-transform:uppercase" class=3D""><br class=3D""></p><div = style=3D"font-family:overpass,sans-serif;margin:0px;font-size:10px;color:r= gb(153,153,153)" class=3D""><a href=3D"https://www.redhat.com/" = style=3D"color:rgb(0,136,206);margin:0px" target=3D"_blank" class=3D"">Red= Hat EMEA</a></div><table = style=3D"font-family:overpass,sans-serif;font-size:inherit" border=3D"0" = class=3D""><tbody class=3D""><tr class=3D""><td width=3D"100px" = class=3D""><a href=3D"https://red.ht/sig" style=3D"color:rgb(17,85,204)" = target=3D"_blank" class=3D""><img = src=3D"https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red= -hat-black.png" width=3D"90" height=3D"auto" class=3D""></a></td><td = style=3D"font-size:10px" class=3D""><a href=3D"https://redhat.com/trusted"= style=3D"color:rgb(204,0,0);font-weight:bold" target=3D"_blank" = class=3D"">TRIED. TESTED. = TRUSTED.</a></td></tr></tbody></table></div><div class=3D"">phone: <a = href=3D"tel:+972%209-769-2018" value=3D"+97297692018" target=3D"_blank" = class=3D"">+972-9-7692018</a><br class=3D"">irc: eedri (on #tlv = #rhev-dev = #rhev-integ)</div></div></div></div></div></div></div></div></div></div></= div> </div></div> ______________________________<wbr class=3D"">_________________<br = class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" target=3D"_blank" = class=3D"">http://lists.ovirt.org/<wbr = class=3D"">mailman/listinfo/devel</a></div></blockquote></div><br = class=3D""></div></div></div></blockquote></div><br = class=3D""></div></div> </div></blockquote></div><br class=3D""></body></html>= --Apple-Mail=_DDF4476C-5018-428D-BCC2-B11C1161B03A--