3:04 p.m.
--Apple-Mail=_38E4ED7D-BC7A-48E9-A049-18EF2EBCD325
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
On 20 Sep 2017, at 16:12, Viktor Mihajlovski =
<mihajlov(a)linux.vnet.ibm.com> wrote:
=20
On 20.09.2017 15:40, Michal Skrivanek wrote:
>=20
>> On 19 Sep 2017, at 14:08, Viktor Mihajlovski =
<mihajlov(a)linux.vnet.ibm.com> wrote:
>>=20
>> On 18.09.2017 17:52, Juan Hern=C3=A1ndez wrote:
>>> On 09/18/2017 05:31 PM, Viktor Mihajlovski wrote:
>>>> Hi,
>>>>=20
>>>> I have submitted a topic branch containing the changes necessary =
to
>>>> enable support for the s390 arch in VDSM and would
appreciate your
>>>> feedback, not only for the code, but also on the procedure:
>>>>=20
>>>> 1. I've submitted the patches as draft, following the suggestions =
on the
>>>> homepage. Not sure whether this is really required.
>>>>=20
>>>> 2. The individual commits are actually tiny, let me know whether =
this is
>>>> OK, or you prefer a single commit.
>>>>=20
>>>> 3. Topic branch here: https://gerrit.ovirt.org/#/q/topic:s390-base
>>>>=20
>>>=20
>>> Note that draft changes are generally OK, but they have the =
inconvenient
>>> that they are invisible for people that isn't
explicitly added as
>>> reviewers. So you will need to either promote them to regular =
patches,
>>> maybe adding a [WIP] prefix to the subject, or else
explicitly add
>>> reviewers, otherwise nobody will see them.
>>>=20
>> Thanks for the clarification, I have done as you suggested. Looking
>> forward for comments.
>=20
> Hi Viktor,
> thank you for the contribution! It looks good so far, some of the =
patches are
already in a good shape, feel free to remove the WIP prefix.
> Size of the patches is also quite matching the typical scope of
each =
patch, at least for vdsm.
>=20
> Do you intend to work on ovirt-engine component as well? If yes then =
it would
be great if you share the areas which you expect will need to =
change, or perhaps some other higher level overview of what kind of =
changes in general are required in oVirt to have a complete s390 support
Hi Michal,
=20
thanks for the feedback. I'll have to clean up the vdsm/libvirt stuff
first. There's still an issue with NUMA on s390 I have to solve=E2=80=A6=
sure, it=E2=80=99s the one to start with. Are other system dependencies =
(qemu, libvirt, other)?
=20
Once I'm done with vdsm, I'll provide patches for ovirt-engine. As a
that=E2=80=99s great!
prerequisite for that I need to update ovirt-engine-api-model (new
architecture and a new watchdog device type).
regarding watchdog=E2=80=A6we have an overdue plan/intent to use pvpanic =
instead of watchdog devices. They are not widely used anyway. So I =
wonder if there are plans to support pvpanic on s390 at the qemu/libvirt =
level and (separately) whether a watchdog is an important item for s390 =
users
Most of the changes have to do with the s390 cpu type handling, =
nothing
really fancy.
=20
Maybe a side discussion: I use ovirt-host-deploy to turn a Fedora
installation into a hypervisor. This worked (with minor changes) well
for Fedora 25, but fails for Fedora 26. This is because F26 uses DNF
version 3 whereas the otopi/python dnf plugin refuses to work with DNF
!=3D 1. Has anyone been hit by that before, and if so, any plans to =
fix that?
yeah, unfortunately we are a bit behind on moving to new dnf and due to =
qemu and libvirt features we are forced to move out of F25 to =
F26=E2=80=A6.which is not ideal - F25 is no longer enough to run, but =
you can=E2=80=99t really deploy ovirt on F26. A fix is not expected to =
happen for some time and I=E2=80=99m afraid for the timebeing you=E2=80=99=
d need to work around that manually, perhaps deploying on F25 and then =
upgrading to F26 would work.=20
We=E2=80=99re mostly focusing on EL platform, it may also make sense to =
work on top of EL 7.4 with custom QEMU/libvirt (I=E2=80=99m assuming you =
do need some bleeding edge changes there)
Thanks,
michal
[...]
--=20
=20
Mit freundlichen Gr=C3=BC=C3=9Fen/Kind Regards
Viktor Mihajlovski
--Apple-Mail=_38E4ED7D-BC7A-48E9-A049-18EF2EBCD325
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=utf-8
<html><head><meta http-equiv=3D"Content-Type"
content=3D"text/html =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" =
class=3D""><br class=3D""><div><blockquote
type=3D"cite" class=3D""><div =
class=3D"">On 20 Sep 2017, at 16:12, Viktor Mihajlovski <<a =
href=3D"mailto:mihajlov@linux.vnet.ibm.com" =
class=3D"">mihajlov(a)linux.vnet.ibm.com</a>&gt;
wrote:</div><br =
class=3D"Apple-interchange-newline"><div class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">On 20.09.2017 15:40, Michal =
Skrivanek wrote:</span><br style=3D"font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: =
normal; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><blockquote
type=3D"cite" =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
orphans: auto; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; widows: auto; word-spacing: 0px; =
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" =
class=3D""><br class=3D""><blockquote
type=3D"cite" class=3D"">On 19 Sep =
2017, at 14:08, Viktor Mihajlovski <<a =
href=3D"mailto:mihajlov@linux.vnet.ibm.com" =
class=3D"">mihajlov(a)linux.vnet.ibm.com</a>&gt; wrote:<br
class=3D""><br =
class=3D"">On 18.09.2017 17:52, Juan Hern=C3=A1ndez wrote:<br =
class=3D""><blockquote type=3D"cite" class=3D"">On
09/18/2017 05:31 PM, =
Viktor Mihajlovski wrote:<br class=3D""><blockquote
type=3D"cite" =
class=3D"">Hi,<br class=3D""><br class=3D"">I
have submitted a topic =
branch containing the changes necessary to<br class=3D"">enable support =
for the s390 arch in VDSM and would appreciate your<br =
class=3D"">feedback, not only for the code, but also on the =
procedure:<br class=3D""><br class=3D"">1. I've
submitted the patches as =
draft, following the suggestions on the<br class=3D"">homepage. Not sure
=
whether this is really required.<br class=3D""><br
class=3D"">2. The =
individual commits are actually tiny, let me know whether this is<br =
class=3D"">OK, or you prefer a single commit.<br
class=3D""><br =
class=3D"">3. Topic branch here: <a =
href=3D"https://gerrit.ovirt.org/#/q/topic:s390-base" =
class=3D"">https://gerrit.ovirt.org/#/q/topic:s390-base</... =
class=3D""><br class=3D""></blockquote><br
class=3D"">Note that draft =
changes are generally OK, but they have the inconvenient<br =
class=3D"">that they are invisible for people that isn't explicitly =
added as<br class=3D"">reviewers. So you will need to either promote =
them to regular patches,<br class=3D"">maybe adding a [WIP] prefix to =
the subject, or else explicitly add<br class=3D"">reviewers, otherwise =
nobody will see them.<br class=3D""><br
class=3D""></blockquote>Thanks =
for the clarification, I have done as you suggested. Looking<br =
class=3D"">forward for comments.<br
class=3D""></blockquote><br =
class=3D"">Hi Viktor,<br class=3D"">thank you for the
contribution! It =
looks good so far, some of the patches are already in a good shape, feel =
free to remove the WIP prefix.<br class=3D"">Size of the patches is also
=
quite matching the typical scope of each patch, at least for vdsm.<br =
class=3D""><br class=3D"">Do you intend to work on
ovirt-engine =
component as well? If yes then it would be great if you share the areas =
which you expect will need to change, or perhaps some other higher level =
overview of what kind of changes in general are required in oVirt to =
have a complete s390 support<br class=3D""></blockquote><span =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">Hi Michal,</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"
class=3D""><br=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">thanks for the feedback. I'll have to clean
up =
the vdsm/libvirt stuff</span><br style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">first. There's still an
issue =
with NUMA on s390 I have to
solve=E2=80=A6</span></div></blockquote><div><=
br class=3D""></div>sure, it=E2=80=99s the one to start with. Are other
=
system dependencies (qemu, libvirt, other)?<br class=3D""><blockquote
=
type=3D"cite" class=3D""><div class=3D""><br
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">Once I'm done with vdsm,
I'll =
provide patches for ovirt-engine. As a</span><br style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""></div></blockquote><div><br
class=3D""></div>that=E2=80=99s =
great!</div><div><br class=3D""><blockquote
type=3D"cite" class=3D""><div =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">prerequisite for that I need to update =
ovirt-engine-api-model (new</span><br style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">architecture and a new watchdog
=
device type).</span><br style=3D"font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: =
normal; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;"
class=3D""></div></blockquote><div><br =
class=3D""></div>regarding watchdog=E2=80=A6we have an overdue =
plan/intent to use pvpanic instead of watchdog devices. They are not =
widely used anyway. So I wonder if there are plans to support pvpanic on =
s390 at the qemu/libvirt level and (separately) whether a watchdog is an =
important item for s390 users</div><div><br
class=3D""><blockquote =
type=3D"cite" class=3D""><div class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">Most of the changes have to do with the
=
s390 cpu type handling, nothing</span><br style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">really fancy.</span><br
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"
class=3D""><br=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">Maybe a side discussion: I use ovirt-host-deploy
=
to turn a Fedora</span><br style=3D"font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: =
normal; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D"">installation into a hypervisor. This =
worked (with minor changes) well</span><br style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">for Fedora 25, but fails for =
Fedora 26. This is because F26 uses DNF</span><br style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><span
=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">version 3 whereas the =
otopi/python dnf plugin refuses to work with DNF</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">!=3D 1. Has anyone been hit by that before, and
=
if so, any plans to fix that?</span><br style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""></div></blockquote><div><br
class=3D""></div>yeah, =
unfortunately we are a bit behind on moving to new dnf and due to qemu =
and libvirt features we are forced to move out of F25 to F26=E2=80=A6.whic=
h is not ideal - F25 is no longer enough to run, but you can=E2=80=99t =
really deploy ovirt on F26. A fix is not expected to happen for some =
time and I=E2=80=99m afraid for the timebeing you=E2=80=99d need to work =
around that manually, perhaps deploying on F25 and then upgrading to F26 =
would work. </div><div>We=E2=80=99re mostly focusing on EL =
platform, it may also make sense to work on top of EL 7.4 with custom =
QEMU/libvirt (I=E2=80=99m assuming you do need some bleeding edge =
changes there)</div><div><br =
class=3D""></div><div>Thanks,</div><div>michal</div><div><br
=
class=3D""><blockquote type=3D"cite"
class=3D""><div class=3D""><span =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; =
display: inline !important;" class=3D"">[...]</span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">--<span =
class=3D"Apple-converted-space"> </span></span><br =
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"
class=3D""><br=
style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" =
class=3D""><span style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; float: none; display: inline =
!important;" class=3D"">Mit freundlichen Gr=C3=BC=C3=9Fen/Kind =
Regards</span><br style=3D"font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px;" class=3D""><span
style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: normal; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: =
inline !important;" class=3D""> Viktor =
Mihajlovski</span></div></blockquote></div><br
class=3D""></body></html>=
--Apple-Mail=_38E4ED7D-BC7A-48E9-A049-18EF2EBCD325--