Re: [Engine-devel] Network related hooks in vdsm

----- Original Message ----- > On 10/10/12 16:47, Igor Lvovsky wrote: >> Hi everyone, >> As you know vdsm has hooks mechanism and we already support dozen >> of hooks for different needs. >> Now it's a network's time. >> We would like to get your comments regarding our proposition for >> network related hooks. >> >> In general we are planning to prepare framework for future support >> of bunch network related hooks. >> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2]. >> >> Below you can find the additional hooks list that we propose: >> > > Many of the API calls bellow are deprecated. Why do we want to add > hooks > before/after to deprecated APIs? They are actually still very much in use with the REST API.

Perhaps we should address just the logical entry points instead of specific commands. A command such as setup networks can trigger multiple logical events in which hooks can be planted (same goes for edit network in a smaller scale).

> >> Note: In the first stage we can implement these hooks without any >> parameters, just to provide an entry point >> for simple hooks. >> >> Networks manipulation: >> - before_add_network(conf={}, customProperty={}) >> - after_add_network(conf={}, customProperty={}) >> - before_del_network(conf={}, customProperty={}) >> - after_del_network(conf={}, customProperty={}) >> - before_edit_network(conf={}, customProperty={}) >> - after_edit_network(conf={}, customProperty={}) >> - TBD >> >> Bondings manipulations: >> - before_add_bond(conf={}, customProperty={}) >> - after_add_bond(conf={}, customProperty={}) >> - before_del_bond(conf={}, customProperty={}) >> - after_del_bond(conf={}, customProperty={}) >> - before_edit_bond(conf={}, customProperty={}) >> - after_edit_bond(conf={}, customProperty={}) >> - TBD >> >> General purpose: >> - before_persist_network >> - after_persist_network >> >> >> Now we just need to figure out the use cases. >> >> Your input more than welcome... >> >> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for >> NIC hotplug >> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX >> support >> >> >> Regards, >> Igor Lvovsky >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >