I'm trying to add a github action workflow for ovirt-imageio. The yml file is simple: https://github.com/nirs/ovirt-imageio/commit/21da91274b7b4722167c2415d1c1b5d... And all the jobs run, but tons of tests are failing: https://github.com/nirs/ovirt-imageio/actions/runs/1527728851 The typical failure is: 2021-12-01T20:50:07.6424921Z address = ('::', 43001), timeout = <object object at 0x7f2cb7d16270> 2021-12-01T20:50:07.6425749Z source_address = None 2021-12-01T20:50:07.6425985Z 2021-12-01T20:50:07.6426421Z def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT, 2021-12-01T20:50:07.6426954Z source_address=None): ... 2021-12-01T20:50:07.6435579Z host, port = address 2021-12-01T20:50:07.6435942Z err = None 2021-12-01T20:50:07.6436563Z for res in getaddrinfo(host, port, 0, SOCK_STREAM): 2021-12-01T20:50:07.6437402Z af, socktype, proto, canonname, sa = res 2021-12-01T20:50:07.6437834Z sock = None 2021-12-01T20:50:07.6438146Z try: 2021-12-01T20:50:07.6438522Z sock = socket(af, socktype, proto) 2021-12-01T20:50:07.6439032Z if timeout is not _GLOBAL_DEFAULT_TIMEOUT: 2021-12-01T20:50:07.6439538Z sock.settimeout(timeout) 2021-12-01T20:50:07.6440109Z if source_address: 2021-12-01T20:50:07.6440522Z sock.bind(source_address) 2021-12-01T20:50:07.6440916Z > sock.connect(sa) 2021-12-01T20:50:07.6441573Z E OSError: [Errno 99] Cannot assign requested address I guess that ipv6 is disabled, and google confirms that github actions and ipv6 is an issue. In travis we enabled ipv6 in docker using this script: https://github.com/oVirt/ovirt-imageio/blob/master/travis/configure-docker.p... Run before starting the job: https://github.com/oVirt/ovirt-imageio/blob/61f023bf1e45da4e98593278451030f4... I did not try to run this script yet, since I'm not sure we have a way to run stuff *before* the container runs in github actions. I hope someone has some insight on a way to solve this. Nir
On Wed, Dec 1, 2021 at 11:11 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to add a github action workflow for ovirt-imageio.
The yml file is simple: https://github.com/nirs/ovirt-imageio/commit/21da91274b7b4722167c2415d1c1b5d...
And all the jobs run, but tons of tests are failing: https://github.com/nirs/ovirt-imageio/actions/runs/1527728851
Solved by not using github "container" option. Instead, just run docker manually like we did in travis. https://github.com/nirs/ovirt-imageio/commit/6fb94e9423c1642af716e3327038835... Notes for others that my have the same issue: docker run -it ... fails in github action with: "the input device is not a TTY" Removing the "-it" options solves this problem. The output of the command running in the container logged to stdout. I don't know why we always run the container with -it. So we have working github CI for ovirt-imageio: https://github.com/nirs/ovirt-imageio/actions/runs/1528026365 Running tests on centos stream 8, centos stream 9, and fedora 34 in 4 minutes. I think the only thing missing to move to github, is to build the rpms in a way that can be used by OST. Nir
On Wed, Dec 1, 2021 at 11:28 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Dec 1, 2021 at 11:11 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to add a github action workflow for ovirt-imageio.
The yml file is simple:
https://github.com/nirs/ovirt-imageio/commit/21da91274b7b4722167c2415d1c1b5d...
And all the jobs run, but tons of tests are failing: https://github.com/nirs/ovirt-imageio/actions/runs/1527728851
Solved by not using github "container" option. Instead, just run docker manually like we did in travis.
https://github.com/nirs/ovirt-imageio/commit/6fb94e9423c1642af716e3327038835...
Notes for others that my have the same issue:
docker run -it ...
fails in github action with:
"the input device is not a TTY"
Removing the "-it" options solves this problem. The output of the command running in the container logged to stdout. I don't know why we always run the container with -it.
So we have working github CI for ovirt-imageio: https://github.com/nirs/ovirt-imageio/actions/runs/1528026365
Running tests on centos stream 8, centos stream 9, and fedora 34 in 4 minutes.
I think the only thing missing to move to github, is to build the rpms in a way that can be used by OST.
Nir
AFAIK enabling ipv6 can be done inside the container by running: sysctl -w net.ipv6.conf.all.disable_ipv6=0 Might be worth doing this instead of the additional docker configuration and restarting the whole service. Regards, Ales -- Ales Musil Software Engineer - RHV Network Red Hat EMEA <https://www.redhat.com> amusil@redhat.com IM: amusil <https://red.ht/sig>
On Thu, Dec 2, 2021 at 8:02 AM Ales Musil <amusil@redhat.com> wrote:
On Wed, Dec 1, 2021 at 11:28 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Dec 1, 2021 at 11:11 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to add a github action workflow for ovirt-imageio.
The yml file is simple:
https://github.com/nirs/ovirt-imageio/commit/21da91274b7b4722167c2415d1c1b5d...
And all the jobs run, but tons of tests are failing: https://github.com/nirs/ovirt-imageio/actions/runs/1527728851
Solved by not using github "container" option. Instead, just run docker manually like we did in travis.
https://github.com/nirs/ovirt-imageio/commit/6fb94e9423c1642af716e3327038835...
Notes for others that my have the same issue:
docker run -it ...
fails in github action with:
"the input device is not a TTY"
Removing the "-it" options solves this problem. The output of the command running in the container logged to stdout. I don't know why we always run the container with -it.
So we have working github CI for ovirt-imageio: https://github.com/nirs/ovirt-imageio/actions/runs/1528026365
Running tests on centos stream 8, centos stream 9, and fedora 34 in 4 minutes.
I think the only thing missing to move to github, is to build the rpms in a way that can be used by OST.
Nir
AFAIK enabling ipv6 can be done inside the container by running: sysctl -w net.ipv6.conf.all.disable_ipv6=0
Looks simpler, I will try it once github CI is merged.
Might be worth doing this instead of the additional docker configuration and restarting the whole service.
Regards, Ales
--
Ales Musil
Software Engineer - RHV Network
Red Hat EMEA <https://www.redhat.com>
amusil@redhat.com IM: amusil <https://red.ht/sig>
participants (2)
-
Ales Musil -
Nir Soffer