From: "Itamar Heim" <iheim(a)redhat.com&gt; To: "Robert Middleswarth" <robert(a)middleswarth.net&gt; Cc: engine-devel(a)ovirt.org, "infra" <infra(a)ovirt.org&gt; Sent: Thursday, August 9, 2012 8:37:03 AM Subject: Re: [Engine-devel] Jenkins testing of patch what do we want to check? On 08/09/2012 05:05 AM, Robert Middleswarth wrote: > Unlike vdsm were the entire unit test takes 2 min to process the > Engine > has several jobs many that take longer then 15 min to run. So here > is > the questions. > > What current jobs do we want to run on each patch submission? > all... developers should verify the default unitests, or specific tests for areas they are touching. but jenkins should run the findbugs, gwt compilation and enable all unitests.

_______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

On 08/09/2012 03:26 AM, Eyal Edri wrote: > > ----- Original Message ----- >> From: "Itamar Heim" <iheim(a)redhat.com&gt; >> To: "Robert Middleswarth" <robert(a)middleswarth.net&gt; >> Cc: engine-devel(a)ovirt.org, "infra" <infra(a)ovirt.org&gt; >> Sent: Thursday, August 9, 2012 8:37:03 AM >> Subject: Re: [Engine-devel] Jenkins testing of patch what do we want >> to check? >> >> On 08/09/2012 05:05 AM, Robert Middleswarth wrote: >>> Unlike vdsm were the entire unit test takes 2 min to process the >>> Engine >>> has several jobs many that take longer then 15 min to run. So here >>> is >>> the questions. >>> >>> What current jobs do we want to run on each patch submission? >>> >> all... >> developers should verify the default unitests, or specific tests for >> areas they are touching. >> but jenkins should run the findbugs, gwt compilation and enable all >> unitests. >> > like itamar said. > we should run every job we can to verify code with to avoid > regressions and errors pre-commit. > > - create/upgrade db > - checkstyle, findbugs, unit-tests, dao-tests... > - maybe animal sniffer - to verify backward compatibility to jdk6 > > We can't do it with current jenkins resources, that's the main reason why > we need more slaves. Ok I will start testing a pre patch processing of the diff test on ovirt-engine. Please be aware of the fact I will be testing today so if you get a fail on something today it might be a fails positive until I have a change to confirm the process. I will send out an email when I feel I have all to bugs worked out.