June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Cleanup LUN pathes parsing
by mkublin＠redhat.com 14 Jun '12

14 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Cleanup LUN pathes parsing ...................................................................... core: Cleanup LUN pathes parsing This patch unifies the code that parses LUN paths from the two places it was separated in GetDeviceListVDSCommand. A unit test for the path parsing was also added to make sure no functionallity was harmed. In addition, some general cleanups (replacing FQCNs with imports, extracting constants, etc.) was done in that area. Change-Id: Ife28fb2d0326fbaaf4a8562d2d709351c75aee81 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 2 files changed, 84 insertions(+), 27 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife28fb2d0326fbaaf4a8562d2d709351c75aee81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Un-mock GetDeviceListVDSCommandTest
by mkublin＠redhat.com 14 Jun '12

14 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Un-mock GetDeviceListVDSCommandTest ...................................................................... core: Un-mock GetDeviceListVDSCommandTest GetDeviceListVDSCommandTest uses Mockito to mock XmlRpcStruct, which is quite redundent - it's a simple data-object, with no underlying logic. This patch removed the mocking and uses XmlRpcStruct directly, which makes the test easier to read and maintain. Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 1 file changed, 10 insertions(+), 15 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Adding in memory lock to RunVmCommand
by mkublin＠redhat.com 14 Jun '12

14 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Adding in memory lock to RunVmCommand ...................................................................... core : Adding in memory lock to RunVmCommand The following fix should provide locking solution for RunVmCommand scenarios. The lock will solve races between RemoveVm and RunVmCommand scenarious Change-Id: I1b0718d45f58d3b2004960a40501b1ddf07478af Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b0718d45f58d3b2004960a40501b1ddf07478af Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [rmd] VdsManager
by lhornyak＠redhat.com 14 Jun '12

14 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: [rmd] VdsManager ...................................................................... core: [rmd] VdsManager Removed RefObject usage from VdsManager. Change-Id: Ice6776fef644762a1ba13f03e83dfc6699c077e8 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 11 insertions(+), 13 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6776fef644762a1ba13f03e83dfc6699c077e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: minor cleanup in VdsSelector
by lhornyak＠redhat.com 14 Jun '12

14 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor cleanup in VdsSelector ...................................................................... core: minor cleanup in VdsSelector Removed vds.getvds_group_compatibility_version() call since it does not change state and the returned value was not used. Change-Id: Id27f2cd9e49f9232eb262fd559c7d93e0e0b58e1 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27f2cd9e49f9232eb262fd559c7d93e0e0b58e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use ValidationResult singleton in succesful validation
by lhornyak＠redhat.com 14 Jun '12

14 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: use ValidationResult singleton in succesful validation ...................................................................... core: use ValidationResult singleton in succesful validation Use a single ValidationResult.valid field when returning a 'valid' result. Change-Id: Ica997570b6976d0c72ada6fb3a5712271db96f4d Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 5 files changed, 13 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica997570b6976d0c72ada6fb3a5712271db96f4d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: refactor capabilities resource to behave as restful...
by mpastern＠redhat.com 13 Jun '12

13 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: refactor capabilities resource to behave as restfull collection ...................................................................... restapi: refactor capabilities resource to behave as restfull collection 1. to versions described in /capabilites collection added id/href 2. capabilites version can be reached via resource pattern /api/capabilities/xxx (tests temporary disabled) Change-Id: I3584dda1482bcef05ea14a8bf38d4809c15c4e12 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/DefaultCapabilitiesResource.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabilitiesResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabiliyResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java 10 files changed, 657 insertions(+), 529 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3584dda1482bcef05ea14a8bf38d4809c15c4e12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add <permits> and <scheduling_policies> to VersionC...
by mpastern＠redhat.com 13 Jun '12

13 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add <permits> and <scheduling_policies> to VersionCaps ...................................................................... restapi: add <permits> and <scheduling_policies> to VersionCaps currently these two elements defined under /Capabilities collection while they should be version specific, this patch adds both elements to VersionCaps and future versions will not have them under /Capabilities Change-Id: I36591e6f6637a0d30e91a2fd7e14accd84deda3a Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36591e6f6637a0d30e91a2fd7e14accd84deda3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't validate MTU on host NIC
by mkolesni＠redhat.com 13 Jun '12

13 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Don't validate MTU on host NIC ...................................................................... core: Don't validate MTU on host NIC No need to validate the MTU field of VdsNetworkInterface since it is not used in network commands (what is used is the MTU on the network). A test needed to be fixed since it relied on this field (being a unit test, it shouldn't have in the first place). Change-Id: I6f5734480acdbe5603ab6b84a358479903ea5dfc Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java 2 files changed, 16 insertions(+), 15 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f5734480acdbe5603ab6b84a358479903ea5dfc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added net_config_dirty to caps (#830488)
by mkolesni＠redhat.com 13 Jun '12

13 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added net_config_dirty to caps (#830488) ...................................................................... core: Added net_config_dirty to caps (#830488) https://bugzilla.redhat.com/830488 When calling getVdsCaps, if this field is reported by the Host then set it in the values to save to the DB. Change-Id: I2ef8da4c590699285684d25b015f5a28aa8af768 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 31 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ef8da4c590699285684d25b015f5a28aa8af768 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0