December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Corrected the resolve action for copy mode
by kmayilsa＠redhat.com 03 Dec '13

03 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: Corrected the resolve action for copy mode ...................................................................... restapi: Corrected the resolve action for copy mode Modified to correctly copy the hook content from a provided node to others in case of resolve from host content option. Earlier it was always copying the engine version of the hook content to all the nodes in case a resolve from a specific node was executed. Usage: api/clusters/<cluster-id>/glusterhooks/<hook-id>/resolve Input Parameters: <action> <resolution_type>COPY</resolution_type> <host id="<Host-Id>"/> </action> or <action> <resolution_type>COPY</resolution_type> <host> <name>Host-Name</name> </host> </action> Change-Id: I412e582addc2bcb8d7176634db7eafaa4686668b Bug-Url: https://bugzilla.redhat.com/1033772 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHookResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I412e582addc2bcb8d7176634db7eafaa4686668b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: update remote DB creation instructions
by ydary＠redhat.com 02 Dec '13

02 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update remote DB creation instructions ...................................................................... packaging: setup: update remote DB creation instructions This patch fixed a regression introduced by the patch e92aa3cd Change-Id: If88e10e5632269a69347a4e2ff4a27b2f30a8b5b Bug-Url: https://bugzilla.redhat.com/1021556 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If88e10e5632269a69347a4e2ff4a27b2f30a8b5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename method RunAdAction to lowercase in LdapBroker
by yzaslavs＠redhat.com 02 Dec '13

02 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: rename method RunAdAction to lowercase in LdapBroker ...................................................................... core: rename method RunAdAction to lowercase in LdapBroker Rename method and its usages to lowercase. Solves a findbug warning. Change-Id: I2369a54c7db1bf0d32681d295839fb900debc57a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeUserPasswordCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LdapSearchQueryTestBase.java 12 files changed, 22 insertions(+), 22 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2369a54c7db1bf0d32681d295839fb900debc57a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juana Garcia <garciajuana81(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: version in feedback url.
by iheim＠redhat.com 02 Dec '13

02 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: version in feedback url. ...................................................................... webadmin: version in feedback url. - Added the ability to specify the version of ovirt in the feedback url. - Added version retrieval to get the configuration from the cache. - Renamed getRpmVersionFromPublic to be non public. Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=968511 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M packaging/branding/ovirt.brand/external_resources.properties 6 files changed, 38 insertions(+), 22 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix feedback image visiblity issue
by iheim＠redhat.com 02 Dec '13

02 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fix feedback image visiblity issue ...................................................................... webadmin: fix feedback image visiblity issue 'Feedback' section in the right-top will be hidden if there is no feedback-url is available. But that section is a collection images and text, not all of them were hidden when no feedback-url supplied. This is fixed by making the whole feedback panel invisible if there is no feedback-url available. Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=968511 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml 3 files changed, 17 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove unused method in SyntaxContainer
by derez＠redhat.com 02 Dec '13

02 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: remove unused method in SyntaxContainer ...................................................................... engine: remove unused method in SyntaxContainer Remove unused method ToStringBr, cleans a findbug warning. Change-Id: Icd4acb0f6ef51ed1af4b0d1506f171cf0d77e568 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java 1 file changed, 0 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd4acb0f6ef51ed1af4b0d1506f171cf0d77e568 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename Init method to init in IrsProxyData
by derez＠redhat.com 02 Dec '13

02 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: core: rename Init method to init in IrsProxyData ...................................................................... core: rename Init method to init in IrsProxyData Solves a findbug warning. Change-Id: I4b2cf7ede61fb40da5dd3f5abce31147f93b8adf Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b2cf7ede61fb40da5dd3f5abce31147f93b8adf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Deprecate replace brick from API
by iheim＠redhat.com 02 Dec '13

02 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Deprecate replace brick from API ...................................................................... restapi: Deprecate replace brick from API The replace brick action is no longer supported in gluster. User needs to migrate and remove brick instead. Marking the API as deprecated. Change-Id: I5ce8126324a6e9575d978cbdd136e78a6bd90626 Bug-Url: https://bugzilla.redhat.com/957602 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ce8126324a6e9575d978cbdd136e78a6bd90626 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent, broker: handle manual migration of vm
by gpadgett＠redhat.com 02 Dec '13

02 Dec '13

Greg Padgett has submitted this change and it was merged. Change subject: agent, broker: handle manual migration of vm ...................................................................... agent, broker: handle manual migration of vm If a vm is migrated manually, the broker will now detect this status, propagate it to the agent, and the agent will switch state to monitor the migration rather than simply waiting for a timeout due to bad vm health. Change-Id: Ic5024210e89a61d724bae191b8ccd913b78f1d31 Bug-Url: https://bugzilla.redhat.com/1026377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 2 files changed, 149 insertions(+), 110 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5024210e89a61d724bae191b8ccd913b78f1d31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: explain internal DC usage
by sbonazzo＠redhat.com 02 Dec '13

02 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: explain internal DC usage ...................................................................... packaging: setup: explain internal DC usage Change-Id: Iada050cc14393381a79819cddce0a49b74fe311c Bug-Url: https://bugzilla.redhat.com/1034802 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iada050cc14393381a79819cddce0a49b74fe311c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0