Change in ovirt-engine[master]: engine: Export/import monitors count fixed
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Export/import monitors count fixed
......................................................................
engine: Export/import monitors count fixed
Templates exported and imported back from the export storage domain
(using clone) end up with 0 monitors (VM cannot be created
from the template since we do not support headless vms).
The template to be exported didn't update managed devices from db
during the export and the XML didn't contain information about monitors.
Change-Id: Ie833ee6de83fad82932e252e8ed83df71b5c495c
Bug-Url: https://bugzilla.redhat.com/917375
Signed-off-by: Libor Spevak <lspevak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie833ee6de83fad82932e252e8ed83df71b5c495c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove unused GetAllNotReadonlyTagsQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused GetAllNotReadonlyTagsQuery
......................................................................
core: Remove unused GetAllNotReadonlyTagsQuery
GetAllNotReadonlyTagsQuery is not used anywhere in the code.
This patch removes it and the corresponding VdcQueryType constant.
Change-Id: I10af151ab98d1091e7d84a3002bf8eb7b6c51c06
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNotReadonlyTagsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 0 insertions(+), 23 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10af151ab98d1091e7d84a3002bf8eb7b6c51c06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove GetTagUserGroupMapByTagNameQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetTagUserGroupMapByTagNameQuery
......................................................................
core: Remove GetTagUserGroupMapByTagNameQuery
GetTagUserGroupMapByTagNameQuery not used anywhere in the code.
This patch removes it, its parameter class
(GetTagUserGroupMapByTagNameParameters), the corresponding
VdcQueryType constant, the DAO method only it used to use, the
corresponding test for the DAO and the corresponding stored procedure.
Change-Id: Ia30bcc3a9bdf1df87074497819e8750b8929f1be
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/tags_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagUserGroupMapByTagNameQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagUserGroupMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java
7 files changed, 0 insertions(+), 75 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia30bcc3a9bdf1df87074497819e8750b8929f1be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove unused GetTagUserMapByTagNameQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused GetTagUserMapByTagNameQuery
......................................................................
core: Remove unused GetTagUserMapByTagNameQuery
GetTagUserMapByTagNameQuery not used anywhere in the code.
This patch removes it, its parameter class
(GetTagUserMapByTagNameParameters), the corresponding VdcQueryType
constant, the DAO method only it used to use, the corresponding test
for the DAO and the corresponding stored procedure.
Change-Id: I12f3cff1fa6864a85cf8a357aeff39f762c46c90
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/tags_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagUserMapByTagNameQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagUserMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java
7 files changed, 7 insertions(+), 78 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12f3cff1fa6864a85cf8a357aeff39f762c46c90
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove VdcQueryType.GetTagIdAndChildrenIds
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove VdcQueryType.GetTagIdAndChildrenIds
......................................................................
core: Remove VdcQueryType.GetTagIdAndChildrenIds
This constant had no corresponding query class, and is thus redundant.
Change-Id: I9413049f1b60746f0b4bdef6fc9a03dd330468f4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9413049f1b60746f0b4bdef6fc9a03dd330468f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove GetTagVdsMapByTagNameQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetTagVdsMapByTagNameQuery
......................................................................
core: Remove GetTagVdsMapByTagNameQuery
GetTagVdsMapByTagNameQuery not used anywhere in the code.
This patch removes it, its parameter class
(GetTagVdsByTagNameParameters), the corresponding
VdcQueryType constant, the DAO method only it used to use, the
corresponding test for the DAO and the corresponding stored procedure.
Change-Id: Ib54ee7c2974cc049e326e04893909fc0862a0ab5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/tags_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagVdsMapByTagNameQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagVdsMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java
7 files changed, 0 insertions(+), 74 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib54ee7c2974cc049e326e04893909fc0862a0ab5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Removed GetTagIdsAndChildrenIdsByRegExp refs
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed GetTagIdsAndChildrenIdsByRegExp refs
......................................................................
core: Removed GetTagIdsAndChildrenIdsByRegExp refs
GetTagIdsAndChildrenIdsByRegExp seems to have been a useful function in
oVirt 3.0, but it has since been (partially) removed, and is not called
from anywhere.
This patch removes the leftovers of that partial cleanup.
This patch removes:
* The function in TagsDirector (was only used by the function of the
same name in TagsHandler and in tests)
* The function in TagsHandler and its interface, ITagsHandler (wasn't
used anywhere)
* The constant in VdcQueryType (useless, has no corresponding query
object)
Change-Id: I1f7a7ab04a5c1a9fc1104d0ddb2d3a3a8ec0f1e0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ITagsHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
5 files changed, 4 insertions(+), 80 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f7a7ab04a5c1a9fc1104d0ddb2d3a3a8ec0f1e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove GetTagVmMapByTagNameQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetTagVmMapByTagNameQuery
......................................................................
core: Remove GetTagVmMapByTagNameQuery
GetTagVmMapByTagNameQuery not used anywhere in the code.
This patch removes it, its parameter class
(GetTagVmByTagNameParameters), the corresponding
VdcQueryType constant, the DAO method only it used to use, the
corresponding test for the DAO and the corresponding stored procedure.
Change-Id: I6c502ffbc5381cb08dd64e8702330baf0371fd25
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/tags_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagVmMapByTagNameQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagVmMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java
7 files changed, 0 insertions(+), 74 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c502ffbc5381cb08dd64e8702330baf0371fd25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-guest-agent[master]: agent: datadir as default home for the ovirtagent user
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: datadir as default home for the ovirtagent user
......................................................................
agent: datadir as default home for the ovirtagent user
Solves the issue with starting the service when polyinstantiated
namespaces are used on the system.
Following the Fedora guideline:
http://fedoraproject.org/wiki/Packaging:UsersAndGroups
Bug-Url: https://bugzilla.redhat.com/883124
Change-Id: I08cd6e8ca4341c62c0e5f18b6c6226a103873f62
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent.spec
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified
Barak Azulay: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08cd6e8ca4341c62c0e5f18b6c6226a103873f62
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: no quota refresh when vm stopped
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: no quota refresh when vm stopped
......................................................................
core: no quota refresh when vm stopped
Currently the vm statuses on which we are calculating quota consumtion
isn't consistent with db (managed in 2 places).
In this patch I've sync-ed all places, that use vm status to decide whether
to count the quota, to a single stored proc that is being used by server
and other stored procs.
Change-Id: Ie2bd42a8431325ddbe552363b299fb80dbd7f3c5
Bug-Url: https://bugzilla.redhat.com/908834
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/dbscripts/create_functions.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java
7 files changed, 51 insertions(+), 14 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2bd42a8431325ddbe552363b299fb80dbd7f3c5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 10 months