March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: doc: update changelog
by Alon Bar-Lev 06 Mar '13

06 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: update changelog ...................................................................... doc: update changelog Change-Id: I53da37add0175f72352f436eb6ae21043abb1e6a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53da37add0175f72352f436eb6ae21043abb1e6a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: hardware: do not fail if msr cannot be read
by Alon Bar-Lev 06 Mar '13

06 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: do not fail if msr cannot be read ...................................................................... vdsm: hardware: do not fail if msr cannot be read Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916589 Change-Id: I96ff8f98b58f34ff2b1af4c0232150fd357ac018 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/hardware.py 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96ff8f98b58f34ff2b1af4c0232150fd357ac018 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: hardware: cleanup
by Alon Bar-Lev 06 Mar '13

06 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: cleanup ...................................................................... vdsm: hardware: cleanup Change-Id: I753ce4a301d227400b2477e9bc4043eb3d8cc35d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/hardware.py 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I753ce4a301d227400b2477e9bc4043eb3d8cc35d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: cleanup example
by Alon Bar-Lev 06 Mar '13

06 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: cleanup example ...................................................................... packagers: yum: cleanup example Change-Id: I3006e31fdfde9fb1d3e72b1f4a6d9c4930c920de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3006e31fdfde9fb1d3e72b1f4a6d9c4930c920de Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: miniyum: we only need system_r
by Alon Bar-Lev 06 Mar '13

06 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: miniyum: we only need system_r ...................................................................... packagers: miniyum: we only need system_r rpm_t type is added automatically by the rpm_execcon(), question is why the system_r is not added... the rpm_t conflict with other tasks install should do such as interactive with dbus. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904153 Change-Id: Iebc0c3fb20c5720a5e05ba0cfda8931ab80a152a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc0c3fb20c5720a5e05ba0cfda8931ab80a152a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed sorting of bonds in bond popup
by alkaplan＠redhat.com 06 Mar '13

06 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed sorting of bonds in bond popup ...................................................................... webadmin: Fixed sorting of bonds in bond popup Added sorting using LexoNumericComparator. Change-Id: Ief91fe080d1642d25eca43be9506250892ce746b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=891061 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 4 files changed, 47 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief91fe080d1642d25eca43be9506250892ce746b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change can-do checks for resume action
by ofrenkel＠redhat.com 06 Mar '13

06 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change can-do checks for resume action ...................................................................... core: change can-do checks for resume action Currently resume is done as a special flow of run-vm command when the previous state of the VM is paused. the can-do-action checks in that case were the same as those that are made for regular run-vm action (for VM which are down). This patch changes the can-do-action checks in case of resume action such that they will only check that the VM exists. there is no need to do further checks as the VM was already created (thus was found to be valid before) if its state is paused. Change-Id: I772377045d5c6d694e00006c9b12e210c52ab353 Bug-Url: https://bugzilla.redhat.com/885994 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 26 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772377045d5c6d694e00006c9b12e210c52ab353 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix vm pop-up host tab logic
by gchaplik＠redhat.com 06 Mar '13

06 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix vm pop-up host tab logic ...................................................................... webadmin: Fix vm pop-up host tab logic The logic of the host tab in the VM pop-up view was inconsistent. The EntityModel of the UnitVmModel migration support was changed to match the other models. UI was changed - instead of checkboxs which mutually exclude each other, a new list-box was added to select the migration mode. Change-Id: Ib4da1be4919913b7739f4139299d2c88958488d0 Bug-Url: https://bugzilla.redhat.com/905831 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 14 files changed, 63 insertions(+), 197 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4da1be4919913b7739f4139299d2c88958488d0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000369 Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup- removing static from singleton members
by gchaplik＠redhat.com 06 Mar '13

06 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: cleanup- removing static from singleton members ...................................................................... core: cleanup- removing static from singleton members QuotaManager is singleton so its members shouldn't be static. Change-Id: I1383d509bab0e99114ad30da264d1ec4e7fd388d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1383d509bab0e99114ad30da264d1ec4e7fd388d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change failCanDoAction method's comment
by ofrenkel＠redhat.com 06 Mar '13

06 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change failCanDoAction method's comment ...................................................................... core: change failCanDoAction method's comment Change the comment of CommandBase#failCanDoAction(VdcBllMessages) to conform the javadoc standard. Change-Id: I3a22a7673908ef8e665efa519629e1b4a8f2cbb6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a22a7673908ef8e665efa519629e1b4a8f2cbb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0