Change in otopi[master]: core: print environment when error detected
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: print environment when error detected
......................................................................
core: print environment when error detected
this will help to analyze current state from logs
Change-Id: Ia7cfbabe815bac4935967feb59fd36c50d04d646
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/context.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7cfbabe815bac4935967feb59fd36c50d04d646
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: NewEditStorageModelBehavior refactor
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: NewEditStorageModelBehavior refactor
......................................................................
webadmin: NewEditStorageModelBehavior refactor
- Refactor items availability logic in NewEditStorageModelBehavior
(I.e. extract the numerous conditions into boolean flags).
- Remove the deprecated export Iscsi/FCP models from the
items list (simplifies the availability conditions).
Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 19 insertions(+), 27 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: engine: Configure management network at host activation
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Configure management network at host activation
......................................................................
engine: Configure management network at host activation
If the engine detects a host which has no management network (either
due to new installation or misconfiguration), the host activation
command will attempt to configure a management network on top of that
interface.
The network configuration on the host will relies on the same
information as reported by VDSM for the host (boot protocol, IP
address and subnet mask).
Change-Id: Ia82e594b888b84b3aa079cc9aa76fa0dddc59f1d
Bug-Url: http://bugzilla.redhat.com/891056
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
7 files changed, 153 insertions(+), 15 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia82e594b888b84b3aa079cc9aa76fa0dddc59f1d
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: AddVmFromTemplate - remove redundant logic
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: AddVmFromTemplate - remove redundant logic
......................................................................
webadmin: AddVmFromTemplate - remove redundant logic
Removing redundant logic from VmListModel -> onSave():
for getting selected storage domains / allocation policies,
DisksAllocationModel -> getImageToDestinationDomainMap()
should be passed to AddVmFromTemplateParameters.
Change-Id: I1eb9157cbf692a8de4e5751390ed925310bdf4a0
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 4 insertions(+), 46 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1eb9157cbf692a8de4e5751390ed925310bdf4a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Enable column resizing in Network main tab
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Enable column resizing in Network main tab
......................................................................
webadmin: Enable column resizing in Network main tab
1. Enabled column resizing in Network main tab table,
to keep it consistent with other table-based main
tabs
2. Removed maxTextLength restriction since the column
resizing makes it unnecessary (the user can simply
resize the column)
Change-Id: Ib89d494a26a7fb48a5525057ab89e86f2ac07ad6
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib89d494a26a7fb48a5525057ab89e86f2ac07ad6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Modified model logic to support adding new bonds
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Modified model logic to support adding new bonds
......................................................................
webadmin: Modified model logic to support adding new bonds
The model used to check that there were actually free bonds reported by
the host; this is no longer necessary once we enable the user to add new
bonds. Also deleted the corresponding error message.
Change-Id: I7d3c2377ff9d95dfff1c3c416e7fc9242795e227
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
2 files changed, 1 insertion(+), 14 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d3c2377ff9d95dfff1c3c416e7fc9242795e227
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Added default created bond to comply with SuggestB...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Added default created bond to comply with SuggestBox
......................................................................
webadmin: Added default created bond to comply with SuggestBox
Since when performing a bonding action, the user may now create a
newly-named bond, it doesn't make much sense to choose one of the
existing free bonds by default. The solution is to put a "bond" prefix
as default, and let the user either proceed to add an arbitrary number
or choose one of the suggested existing bonds.
Change-Id: I6b68f6b5f89089a7f78609b78df2e3e92827234d
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b68f6b5f89089a7f78609b78df2e3e92827234d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Added frontend bond name validation
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Added frontend bond name validation
......................................................................
webadmin: Added frontend bond name validation
Now that the user may add new bond names, it is necessary to check that
the given name is of the correct format; added a specific validation
class, as well as the code to actually perform the check on the popup
window.
Change-Id: I8f5ea2b582f3117817ef72f7d3350977a124681f
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BondNameValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
4 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f5ea2b582f3117817ef72f7d3350977a124681f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Added SuggestBox bond name widget
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Added SuggestBox bond name widget
......................................................................
webadmin: Added SuggestBox bond name widget
When creating a new bond or editing an existing one through the newer
bond popup window, the widget for picking a bond name is now a
SuggestBox rather than a ValueListBox. This enables the user to input a
new bond name, as well as choose between suggested bond names that
already exist on the host and are free (as was customary historically).
Change-Id: I130586dc4787abecf81566a8d3b723d093f6fca2
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBoxEditor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
7 files changed, 194 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I130586dc4787abecf81566a8d3b723d093f6fca2
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Changed bond list models to hold String
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Changed bond list models to hold String
......................................................................
webadmin: Changed bond list models to hold String
The models all used to hold VdsNetworkInterface entities, but only ever
used the NICs' names, so they really should have held String entities
all along. This will facilitate adding new bonds in following patches.
Change-Id: I4ede413e9c6fdc4b117eb10d6e7ff580f65324d1
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
6 files changed, 22 insertions(+), 25 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ede413e9c6fdc4b117eb10d6e7ff580f65324d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
11 years, 2 months
