April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove GetAvailableClustersByServerCpu
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetAvailableClustersByServerCpu ...................................................................... core: Remove GetAvailableClustersByServerCpu GetAvailableClustersByServerCpuQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAvailableClustersByServerCpuQuery class. 2. The GetAvailableClustersByServerCpu constant representing it in VdcQueryType. 3. The GetAvailableClustersByServerCpuParameters class only used by the aforementioned query. 4. Methods in CpuFlagsManagerHandler only used by the aforementioned query: GetAllServerCpusBelowCpu(String, Version) and GetAllServerCpusBelowCpu(String). Change-Id: Id8bca65412e18c2c62ead41825b08cddd9506c11 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableClustersByServerCpuQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableClustersByServerCpuParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 100 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8bca65412e18c2c62ead41825b08cddd9506c11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove RegisterSearch and UnregisterSearch
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove RegisterSearch and UnregisterSearch ...................................................................... core: Remove RegisterSearch and UnregisterSearch Removed the RegisterSearch and UnregisterSearch constants from VdcQueryType, as the corresponding queries no longer exists, making these constants useless. Change-Id: I2a1bb82d7096fa7cc6ef807739fec10cb44e1cbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a1bb82d7096fa7cc6ef807739fec10cb44e1cbe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove CanUpdateFieldGeneric
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove CanUpdateFieldGeneric ...................................................................... core: Remove CanUpdateFieldGeneric CanUpdateFieldGenericQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The CanUpdateFieldGenericQuery class 2. The CanUpdateFieldGeneric constant representing it in VdcQueryType 3. The CanUpdateFieldGenericParameters class which was only used by the removed query class. Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 52 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove HasFreeVmsInPool
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove HasFreeVmsInPool ...................................................................... core: Remove HasFreeVmsInPool HasFreeVmsInPoolQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The HasFreeVmsInPoolQuery class 2. The HasFreeVmsInPool constant representing it in VdcQueryType 3. The HasFreeVmsInPoolParameters class which was only used by the removed query class. 4. Moved several static methods from VmPoolCommandBase which were used by HasFreeVmsInPoolQuery and AttachUserToVmFromPoolAndRunCommand to AttachUserToVmFromPoolAndRunCommand, as it is now the only command that uses them - getVmToAttach(NGuid), getPrestartedVmToAttach(NGuid), getNonPrestartedVmToAttach(NGuid). These methods' visibility was also reduced to private, as they no longer need to be used outside this class. Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasFreeVmsInPoolQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasFreeVmsInPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 5 files changed, 37 insertions(+), 67 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAllVmPools
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetAllVmPools ...................................................................... core: Remove GetAllVmPools GetAllVmPoolsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAllVmPoolsQuery class 2. The GetAllVmPools constant representing it in VdcQueryType Change-Id: I09730eba7e90bc1372569ca8389ff346c099aa23 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09730eba7e90bc1372569ca8389ff346c099aa23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove VdcUtils
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove VdcUtils ...................................................................... core: Remove VdcUtils This class is not used at all. Change-Id: I7de5666a260ad57a30534adc1ea86a5ef5642886 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/VdcUtils.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de5666a260ad57a30534adc1ea86a5ef5642886 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVmPoolMapByVmPoolId
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetVmPoolMapByVmPoolId ...................................................................... core: Remove GetVmPoolMapByVmPoolId GetVmPoolMapByVmPoolIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmPoolMapByVmPoolIdQuery class 2. The GetVmPoolMapByVmPoolId constant representing it in VdcQueryType 3. The GetVmPoolMapByVmPoolIdParameters class which was only used by the removed query class. Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 31 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVmsByUserid
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetVmsByUserid ...................................................................... core: Remove GetVmsByUserid GetVmsByUseridQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmsByUseridQuery class 2. The GetVmsByUserid constant representing it in VdcQueryType 3. The GetVmsByUseridParameters class which was only used by the removed query class. Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 39 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: java: do not fail set environment with null
by Alon Bar-Lev 11 Apr '13

11 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: java: do not fail set environment with null ...................................................................... java: do not fail set environment with null Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/java/MachineDialogParser.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: core: support more complex sequence relationships
by Alon Bar-Lev 11 Apr '13

11 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support more complex sequence relationships ...................................................................... core: support more complex sequence relationships perform before/after multiple times to allow list to be synchronized. Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 32 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0