January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: history: Removes ad_domain column from vm_configuration table
by ydary＠redhat.com 30 Jan '14

30 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: Removes ad_domain column from vm_configuration table ...................................................................... history: Removes ad_domain column from vm_configuration table This patch removes ad_domain column from vm_configuration table. Change-Id: I4047a8eedae7160fa634125f7c5864703c3cdaab Related-To: https://bugzilla.redhat.com/1051041 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_4/ConfigurationSync.java M packaging/dbscripts/create_views_3_0.sql M packaging/dbscripts/create_views_3_1.sql M packaging/dbscripts/create_views_3_2.sql M packaging/dbscripts/create_views_3_3.sql M packaging/dbscripts/create_views_3_4.sql A packaging/dbscripts/upgrade/03_04_0040_drop_ad_domain_from_vm_configuration.sql M tos_project/process/ConfigurationSync_3.4.item M tos_project/process/ConfigurationSync_3.4.properties 9 files changed, 134 insertions(+), 288 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4047a8eedae7160fa634125f7c5864703c3cdaab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: Remove of datacenter storage_type
by ydary＠redhat.com 30 Jan '14

30 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: Remove of datacenter storage_type ...................................................................... history: Remove of datacenter storage_type This patch removes the storage type of a datacenter, instead a datacenter can be marked as is_local_storage - contains local on host storage or shared - contains shared storages of various types. Change-Id: I948a8b15fdfb5c8fd9dd9f272a371a48657c0113 Related-To: https://bugzilla.redhat.com/1038053 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_4/ConfigurationSync.java M packaging/dbscripts/create_views_3_0.sql M packaging/dbscripts/create_views_3_1.sql M packaging/dbscripts/create_views_3_2.sql M packaging/dbscripts/create_views_3_3.sql M packaging/dbscripts/create_views_3_4.sql A packaging/dbscripts/upgrade/03_04_0030_drop_storage_pool_type.sql M tos_project/process/ConfigurationSync_3.4.item M tos_project/process/ConfigurationSync_3.4.properties 9 files changed, 409 insertions(+), 306 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I948a8b15fdfb5c8fd9dd9f272a371a48657c0113 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Execute clear tasks with new thread.
by mlipchuk＠redhat.com 30 Jan '14

30 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Execute clear tasks with new thread. ...................................................................... core: Execute clear tasks with new thread. clearAsyncTasksWithOutVdsmId is executed at the finally step when executing a vdc command. If the execute phase encountered a problem, the engine sets the transaction to rollback only and we can not use it any more. Since the clearAsyncTasksWithOutVdsmId uses calls to the DB, the engine throws an EJBTransactionRolledbackException, and the original exception does not seep to the user. The proposed solution is to clear the async tasks with a new transaction, so it will not be dependent on the related execute phase. Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant else
by mlipchuk＠redhat.com 30 Jan '14

30 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant else ...................................................................... core: Remove redundant else There is no use for the else phase since when the if condition is true we already throw an exception. Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Propagate the exception from VDSM to the user
by mlipchuk＠redhat.com 30 Jan '14

30 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Propagate the exception from VDSM to the user ...................................................................... core: Propagate the exception from VDSM to the user Propagate the exception got from VDSM instead replacing it every time. Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use shorter scope for try catch block
by mlipchuk＠redhat.com 30 Jan '14

30 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use shorter scope for try catch block ...................................................................... core: Use shorter scope for try catch block There is no need to put try catch block on createTask since it is already swallows the exception in CommandBase. Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Support custom message to appear in case of expired pa...
by yzaslavs＠redhat.com 30 Jan '14

30 Jan '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Support custom message to appear in case of expired password ...................................................................... core: Support custom message to appear in case of expired password The bug description stays that in case of failed login, the user may get a URL to change the passord, or a custom message. In order to support that, the following changes were introduced: a. manage-domains code -changePasswordUrl was changed to -changePasswordMsg. b. The input is done in interactive mode. c. The read value is encoded (as may contain characters like space, : and ,) d. The manage-domains script was changed accordingly e. The vdc_options relevant entry was changed (so was the ConfigValues relevant enum literal). f. ProsivinalAuthenticationResult reads the entry from the configuration and decodes it. g. A proper VDC BLL message is used depending on whether the content is URL or not (a new VdcBllMessage was introduced). Bug-Url: https://bugzilla.redhat.com/1053601 Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticationResult.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M packaging/bin/engine-manage-domains.sh M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 9 files changed, 92 insertions(+), 55 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: remove system localstate
by sbonazzo＠redhat.com 30 Jan '14

30 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remove system localstate ...................................................................... packaging: setup: remove system localstate these issues are per 3.2 issues, will not exist post 3.3. should have been in legacy. Change-Id: Ie998aa70853464d60e4f0573e5fe1cd437d9d948 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/setup/ovirt_engine_setup/config.py.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/localstate.py 5 files changed, 0 insertions(+), 98 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie998aa70853464d60e4f0573e5fe1cd437d9d948 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: conf: re-add retry to apache proxy
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: conf: re-add retry to apache proxy ...................................................................... packaging: conf: re-add retry to apache proxy removed at 734ba5516ae8 with no apparent reason. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Change-Id: Ic43c8f10a38c5606ad59a92f05f7354ee6cd6287 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic43c8f10a38c5606ad59a92f05f7354ee6cd6287 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: services: ovirt-engine: move deployments to tmpdir
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: move deployments to tmpdir ...................................................................... packaging: services: ovirt-engine: move deployments to tmpdir the deployments' content is controlled by ENGINE_APPS, we should run these applications and only these. much easier to re-create on every startup than syncing with existing. this removes the need to remove markers, sync symlinks and other tasks. I failed to make jboss substitute system property within the configuration and within the paths configuration, so I use template substitution. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059480 Change-Id: I17e7bc91229e9b05e6fb719a9c15c1036a3ba19b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/localstate.py 6 files changed, 29 insertions(+), 84 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17e7bc91229e9b05e6fb719a9c15c1036a3ba19b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0