November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: packaging: remove log4j requirment from spec file
by ydary＠redhat.com 16 Nov '14

16 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: remove log4j requirment from spec file ...................................................................... packaging: remove log4j requirment from spec file removed log4j requirment from reports spec file since we provide it. Change-Id: Ic06600ae62e6af2acdc04431d067430dbe3c052f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Verified Yaniv Dary: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic06600ae62e6af2acdc04431d067430dbe3c052f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: enable icmp
by oourfali＠redhat.com 16 Nov '14

16 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: enable icmp ...................................................................... host-deploy: enable icmp Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1162180 Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Jaša <djasa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Nullity check in GetVmTemplateQuery
by laravot＠redhat.com 16 Nov '14

16 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: Nullity check in GetVmTemplateQuery ...................................................................... core: Nullity check in GetVmTemplateQuery Nullity check added to VM template- the query tries to get a template from the DB and didn't check if the returned value is null which will result in NullPointerException thrown from the query. Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Amit Aviram: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix NPE on Template creation
by ofrenkel＠redhat.com 16 Nov '14

16 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix NPE on Template creation ...................................................................... core: Fix NPE on Template creation Change-Id: I0d9ed1719db7129be1f560068f8b8c2c707f3efa Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d9ed1719db7129be1f560068f8b8c2c707f3efa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap
by tnisan＠redhat.com 14 Nov '14

14 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: provide UI error for builtin krbldap ...................................................................... aaa: provide UI error for builtin krbldap Bug-Url: https://bugzilla.redhat.com/1106435 Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java 2 files changed, 17 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondřej Macháček: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: postgresql: avoid to crash with numerical passwords
by sbonazzo＠redhat.com 14 Nov '14

14 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: postgresql: avoid to crash with numerical passwords ...................................................................... postgresql: avoid to crash with numerical passwords Issue: https://github.com/sosreport/sos/issues/433 Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133993 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/postgresql.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: use env instead of command line for password
by sbonazzo＠redhat.com 14 Nov '14

14 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: use env instead of command line for password ...................................................................... sos: use env instead of command line for password use an env variable instead of a command line option for passing the postgresql password to sos. Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: postgresql: avoid to crash with numerical passwords
by sbonazzo＠redhat.com 14 Nov '14

14 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: postgresql: avoid to crash with numerical passwords ...................................................................... postgresql: avoid to crash with numerical passwords Issue: https://github.com/sosreport/sos/issues/433 Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133993 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/postgresql.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Petr Benas <pbenas(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: sos: use env instead of command line for password
by sbonazzo＠redhat.com 14 Nov '14

14 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: use env instead of command line for password ...................................................................... sos: use env instead of command line for password use an env variable instead of a command line option for passing the postgresql password to sos. Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ef847d3bc420d279195ee9ac56a8d4266e5936 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Change init type of BackwardCompatibilityTaskCreationTest
by yzaslavs＠redhat.com 14 Nov '14

14 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: Change init type of BackwardCompatibilityTaskCreationTest ...................................................................... Change init type of BackwardCompatibilityTaskCreationTest Since this test fails sporadically, added an after method to run after each test that resets the DbFacade static reference to avoid it from affecting other tests This is the failure log from the tests: Tests in error: testConcreateCreateTaskBackwardsComaptibility(org.ovirt.engine.core.bll. BackwardCompatibilityTaskCreationTest): testConcreateCreateTaskBackwardsComaptibility(data[6]) Change-Id: Ic51dcdbe554844698d1897c5323b0a4290ba10c9 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51dcdbe554844698d1897c5323b0a4290ba10c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0