November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: utils: fix compiler warnings (unit test)
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: fix compiler warnings (unit test) ...................................................................... utils: fix compiler warnings (unit test) Some HashMaps were unintentionally subclassed, which generated a warning about missing serialVersionUID. Change-Id: I7b9b149dc43bc0d60cf0bbfcb530f642d4128820 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java 1 file changed, 20 insertions(+), 26 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b9b149dc43bc0d60cf0bbfcb530f642d4128820 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: Remove unused LinqUtils.transformToSet
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: Remove unused LinqUtils.transformToSet ...................................................................... utils: Remove unused LinqUtils.transformToSet Remove LinqUtils.transformToSet, which is unused, and cuases compiler warnings Change-Id: I646707625f139572333ee626c6613f46c35d70c6 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I646707625f139572333ee626c6613f46c35d70c6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: Avoid compiler warnings for missing Enum values
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: Avoid compiler warnings for missing Enum values ...................................................................... utils: Avoid compiler warnings for missing Enum values Change-Id: I882f2196a13ec6cea4d0398d0c1b842bcca0af9b Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I882f2196a13ec6cea4d0398d0c1b842bcca0af9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract balloon validation in import vm
by ahadas＠redhat.com 13 Nov '14

13 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: extract balloon validation in import vm ...................................................................... core: extract balloon validation in import vm It is better to extract the validation from the canDoAction command for 2 reasons: 1. Readability - to make the canDoAction method more readable 2. Testability - to make the command more testable Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: SnapshotModel - remove unused method
by derez＠redhat.com 13 Nov '14

13 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SnapshotModel - remove unused method ...................................................................... webadmin: SnapshotModel - remove unused method SnapshotModel -> updateModelBySnapshot: unused, hence removed. Change-Id: I616e0eed78c1320cc098984c60f09cda58a682b1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616e0eed78c1320cc098984c60f09cda58a682b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: create snapshot - filter out non-snapable disks
by derez＠redhat.com 13 Nov '14

13 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: create snapshot - filter out non-snapable disks ...................................................................... webadmin: create snapshot - filter out non-snapable disks Create snapshot dialog: Filter out non-snapable disks (shareable/DirectLUN) from list (a relevant validation and warning already exists). Change-Id: I7bfc4fbaa254ca7ac8c5f37decbcd78fcf991636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bfc4fbaa254ca7ac8c5f37decbcd78fcf991636 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: minor cleanup in import vm
by ofrenkel＠redhat.com 13 Nov '14

13 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in import vm ...................................................................... core: minor cleanup in import vm Change-Id: Ie27dfe490bcf76aa1425416f1d37524562ac22df Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie27dfe490bcf76aa1425416f1d37524562ac22df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: prevent possible deadlock between monitoring threads
by tnisan＠redhat.com 13 Nov '14

13 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: prevent possible deadlock between monitoring threads ...................................................................... core: prevent possible deadlock between monitoring threads If VM went down during migration in the source host, the monitoring (VURTI) thread of the source host tries to destroy the VM in the destination host. In order to destroy the VM in the destination host, it tries to lock the destination host. When we have two monitoring threads that try to do it, we end-up in a deadlock because each of them locks the host it monitors and tries to lock the other one. This patch solves this problem by postponing the destroy operation on the destination host to take place after the lock on the monitored host is released. It is safe to do it that way because the status of the VM in the destination host must be either Down or MigratingTo. If the status is MigratingTo, the monitoring of the destination host just ignores the VM. If the status is Down, the monitoring of the destination host will just destroy the VM and the second destroy operation will fail. Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Bug-Url: https://bugzilla.redhat.com/1142776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 35 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: set cmdContext sessionId on CommandBase ctr
by tnisan＠redhat.com 13 Nov '14

13 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: set cmdContext sessionId on CommandBase ctr ...................................................................... core: set cmdContext sessionId on CommandBase ctr Set session ID on CommandContext at CommandBase constructor when not available. Needed for SEAT mechanism since session ID is available only on parameters upon command re-instantiation (when moving between task handlers). Change-Id: I99bfbf7af491ec01e2dcc7d18b27c84d881c241f Bug-Url: https://bugzilla.redhat.com/1159632 Bug-Url: https://bugzilla.redhat.com/1148495 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99bfbf7af491ec01e2dcc7d18b27c84d881c241f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: detailed error message on OVF import error
by ahadas＠redhat.com 13 Nov '14

13 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: detailed error message on OVF import error ...................................................................... core: detailed error message on OVF import error The patch fixes the error message given when importing a corrupted OVF file, added the actual exception message to the audit log. Change-Id: I8fdfd50fe4e956a95d05a70dac7391c39245c9f8 Bug-Url: https://bugzilla.redhat.com/1036635 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 8 insertions(+), 6 deletions(-) Approvals: Eldan Shachar: Verified Shahar Havivi: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fdfd50fe4e956a95d05a70dac7391c39245c9f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0