November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed UI for popup New CPU QoS
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed UI for popup New CPU QoS ...................................................................... webadmin: Fixed UI for popup New CPU QoS In the popup "New CPU Qos", the scroll bar was removed and also, margin was added for the "Limit" textbox so it will be aligned with the rest of the textboxes. Color for the "Limit" row wasn't changed(It was decided to leave it as is). Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Bug-Url: https://bugzilla.redhat.com/1142813 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosPopupView.ui.xml 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed out of frame load balancer boxes.
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed out of frame load balancer boxes. ...................................................................... webadmin: Fixed out of frame load balancer boxes. In the "New Scheduling Policy" dialog, extended the height of the frame. Also, Added new css style "separatorStyle" with margins for the seperators to adjust the style to the height change. Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Bug-Url: https://bugzilla.redhat.com/1142897 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "core: Improve performance of getdisksvmguid"
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: Improve performance of getdisksvmguid" ...................................................................... Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: doc: README: update fakeqemu section
by Alon Bar-Lev 09 Nov '14

09 Nov '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: README: update fakeqemu section ...................................................................... doc: README: update fakeqemu section Change-Id: I7c8a5598ae4d0ac5213f626e8b51d7aebbfd871e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8a5598ae4d0ac5213f626e8b51d7aebbfd871e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "core: Improve performance of getdisksvmguid"
by amureini＠redhat.com 09 Nov '14

09 Nov '14

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "core: Improve performance of getdisksvmguid" ...................................................................... Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: hook: Start vdsmd explicitly again
by fabiand＠redhat.com 07 Nov '14

07 Nov '14

Fabian Deutsch has submitted this change and it was merged. Change subject: hook: Start vdsmd explicitly again ...................................................................... hook: Start vdsmd explicitly again It's not really clear, but … If a dependency is brought down during a service is queued, then the start job is canceled. And even if the depdendency comes up again, the unit is not enqueued again. Change-Id: I4796c96a8cd97d19beeafabc6c2a52b3817b9d12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156369 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M configure.ac M hooks/Makefile.am A hooks/on-boot/90-start-vdsm M ovirt-node-plugin-vdsm.spec.in 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4796c96a8cd97d19beeafabc6c2a52b3817b9d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: page: Use package name everywhere
by fabiand＠redhat.com 07 Nov '14

07 Nov '14

Fabian Deutsch has submitted this change and it was merged. Change subject: page: Use package name everywhere ...................................................................... page: Use package name everywhere Change-Id: Ifee0293d0b7521e254a619e76f1a0255d65e4418 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152428 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M src/engine_page.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee0293d0b7521e254a619e76f1a0255d65e4418 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: hooks: Move sanlock upgrade hook to post-upgrade
by fabiand＠redhat.com 07 Nov '14

07 Nov '14

Fabian Deutsch has submitted this change and it was merged. Change subject: hooks: Move sanlock upgrade hook to post-upgrade ...................................................................... hooks: Move sanlock upgrade hook to post-upgrade Previously the sanlock upgrade loogic was run on boot, and that broken vdsm's boot on el7/systemd based systems. Now the logic is run post-upgrade and not at boot time. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156369 Change-Id: I53d63c393e884901eb45f1ac38e8bf2795dbaeb7 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M hooks/Makefile.am R hooks/on-boot/02-vdsm-sebool-config R hooks/post-upgrade/01-sanlock-check M ovirt-node-plugin-vdsm.spec.in 4 files changed, 11 insertions(+), 4 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53d63c393e884901eb45f1ac38e8bf2795dbaeb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: hook: Start vdsmd explicitly again
by fabiand＠redhat.com 07 Nov '14

07 Nov '14

Fabian Deutsch has submitted this change and it was merged. Change subject: hook: Start vdsmd explicitly again ...................................................................... hook: Start vdsmd explicitly again It's not really clear, but … If a dependency is brought down during a service is queued, then the start job is canceled. And even if the depdendency comes up again, the unit is not enqueued again. Change-Id: I4796c96a8cd97d19beeafabc6c2a52b3817b9d12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156369 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M configure.ac M hooks/Makefile.am A hooks/on-boot/90-start-vdsm M ovirt-node-plugin-vdsm.spec.in 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4796c96a8cd97d19beeafabc6c2a52b3817b9d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: page: Use package name everywhere
by fabiand＠redhat.com 07 Nov '14

07 Nov '14

Fabian Deutsch has submitted this change and it was merged. Change subject: page: Use package name everywhere ...................................................................... page: Use package name everywhere Change-Id: Ifee0293d0b7521e254a619e76f1a0255d65e4418 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152428 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M src/engine_page.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee0293d0b7521e254a619e76f1a0255d65e4418 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0