November 2014 - Engine-commits - oVirt List Archives

Change in jenkins[master]: changed jpackage mirror
by dcaroest＠redhat.com 10 Nov '14

10 Nov '14

David Caro has submitted this change and it was merged. Change subject: changed jpackage mirror ...................................................................... changed jpackage mirror ftp://jpackage.hmdc.harvard.edu is not mirroring jpackage repo anymore moved to another mirror. Related-To: http://jenkins.ovirt.org/job/repos_3.5_check-closure_merged/DISTRIBUTION=ce… Change-Id: I3f2af8a3e9e97f7b4025b35de1c181ad9142d20f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve David Caro: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f2af8a3e9e97f7b4025b35de1c181ad9142d20f Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: spec: add support for EL7 builds
by sradco＠redhat.com 10 Nov '14

10 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds - add support for EL7 builds - avoid to require both java and java-1.7.0-openjdk since java is already provided by java-1.7.0-openjdk Change-Id: Ia3bf3df726a5092637e2e0b8e2dd95625f7f89da Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3bf3df726a5092637e2e0b8e2dd95625f7f89da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: spec: add support for EL7 builds
by sradco＠redhat.com 10 Nov '14

10 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds - add support for EL7 builds - avoid to require both java and java-1.7.0-openjdk since java is already provided by java-1.7.0-openjdk Change-Id: Ia3bf3df726a5092637e2e0b8e2dd95625f7f89da Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3bf3df726a5092637e2e0b8e2dd95625f7f89da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: glance domain - fix images tab
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: glance domain - fix images tab ...................................................................... webadmin: glance domain - fix images tab Glance storage domain are unattached, hence, shouldn't be checked against Active status (change has been introduced in change-Id Idb29eb14a07a8084b62bda5ac41769ce964bac16 to prevent query on inactive domains). Change-Id: I5cdad6f443b19ad240b3c60c0f8f62798aca7bd8 Bug-Url: https://bugzilla.redhat.com/1161941 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/34977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cdad6f443b19ad240b3c60c0f8f62798aca7bd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: glance domain - fix images tab
by derez＠redhat.com 09 Nov '14

09 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: glance domain - fix images tab ...................................................................... webadmin: glance domain - fix images tab Glance storage domain are unattached, hence, shouldn't be checked against Active status (change has been introduced in change-Id Idb29eb14a07a8084b62bda5ac41769ce964bac16 to prevent query on inactive domains). Change-Id: I5cdad6f443b19ad240b3c60c0f8f62798aca7bd8 Bug-Url: https://bugzilla.redhat.com/1161941 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/34976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cdad6f443b19ad240b3c60c0f8f62798aca7bd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: RFE: sysprep file name should be according to its version
by shavivi＠redhat.com 09 Nov '14

09 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: RFE: sysprep file name should be according to its version ...................................................................... RFE: sysprep file name should be according to its version We are using sysprep inside a floppy by the filename: sysprep.inf, - which is what sysprep is looking for in .ini file format that was in xp and 2003. The new format is xml and the filename should be "Unattend.xml" for this versions. Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Bug-Url: https://bugzilla.redhat.com/1145999 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/conf/osinfo-defaults.properties 6 files changed, 39 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Date formatting when deleting a snapshot
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Date formatting when deleting a snapshot ...................................................................... webadmin: Date formatting when deleting a snapshot When deleting a VM's snapshot a formatted date is now shown based on a constant taken from another component in the system (DiskGeneralModel) for system consistency. this constant is intended to be exported to some util class later on. Bug-Url: https://bugzilla.redhat.com/1158959 Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/34966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: history: updated required changes 3.5.1
by ydary＠redhat.com 09 Nov '14

09 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: updated required changes 3.5.1 ...................................................................... history: updated required changes 3.5.1 Change-Id: I251e39973901c25cb997ababb8b9ebc40e5b790b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/minimalversioncheck_3_5/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_3_5/contexts/Default.properties M etl_export/ovirt_engine_dwh/validateinstallation_3_5/contexts/Default.properties M tos_project/context/connectionJDBC_3.5.item M tos_project/process/HistoryETL_3.5.item M tos_project/process/MinimalVersionCheck_3.5.item M tos_project/process/ParallelRun_3.5.item M tos_project/process/ValidateInstallation_3.5.item 8 files changed, 8 insertions(+), 8 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I251e39973901c25cb997ababb8b9ebc40e5b790b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Clear Inactive ISO Domain Images List
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Clear Inactive ISO Domain Images List ...................................................................... frontend: Clear Inactive ISO Domain Images List When an ISO domain is not active, navigating to its images subtab should not query for the images, but show an empty list. Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Bug-Url: https://bugzilla.redhat.com/1155191 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Avoid NPE in request for CDROMs of wrong VM
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Avoid NPE in request for CDROMs of wrong VM ...................................................................... restapi: Avoid NPE in request for CDROMs of wrong VM Currently when we receive a request for the collection of CDROMs of a VM we don't take into account that the query performed to find the VM can return null if there isn't such a VM (the identifier is wrong, or the VM has been removed). To avoid that NPE this patch checks the result of the query and will respond with an empty list in those cases. Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3 Bug-Url: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit f1dc8f77e611a2b8f40ddac822032632833d4eb0) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0