November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: spec: add support for EL7 builds
by sbonazzo＠redhat.com 07 Nov '14

07 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: codegen, sdk: Fix propagation of context
by juan.hernandez＠redhat.com 07 Nov '14

07 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen, sdk: Fix propagation of context ...................................................................... codegen, sdk: Fix propagation of context The patch that replaced the Python HTTP library with pycurl introduced a bug in the propagation of the context key from the entry point to the connections pool. This patch fixes it. Change-Id: I71c4fc009b629195a9e154b8ecd3db741e7e89d5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py 3 files changed, 8 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/34893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c4fc009b629195a9e154b8ecd3db741e7e89d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Fix typo for 'timeout'
by sbonazzo＠redhat.com 07 Nov '14

07 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix typo for 'timeout' ...................................................................... Fix typo for 'timeout' Change-Id: I8a8205dcac7453eebb6705e5de3d3862122e8f1e Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a8205dcac7453eebb6705e5de3d3862122e8f1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforcing required networks configuration ...
by sbonazzo＠redhat.com 07 Nov '14

07 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enforcing required networks configuration additional hosts ...................................................................... packaging: setup: enforcing required networks configuration additional hosts On additional hosts, waiting for the user to configure the additional required networks before checking host status. Change-Id: I259b78e6a5c3009c29a7e3c8573500f12247acbc Bug-Url: https://bugzilla.redhat.com/1086032 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 57 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/34789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I259b78e6a5c3009c29a7e3c8573500f12247acbc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: provide UI error for builtin krbldap
by yzaslavs＠redhat.com 07 Nov '14

07 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: provide UI error for builtin krbldap ...................................................................... aaa: provide UI error for builtin krbldap Bug-Url: https://bugzilla.redhat.com/1106435 Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java 2 files changed, 17 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondřej Macháček: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: readonly label editors
by awels＠redhat.com 06 Nov '14

06 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: readonly label editors ...................................................................... webadmin: readonly label editors - Modified readonly label editors to not use a parser as they are readonly. This fixes potential issues different locales as the values in different locales will not properly parse back into their original values. Change-Id: I5d485f40d574df26ab4b4a0f6f60679e2c2b2506 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ManageGlusterSwiftPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 4 files changed, 5 insertions(+), 54 deletions(-) Approvals: Alexander Wels: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d485f40d574df26ab4b4a0f6f60679e2c2b2506 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: notifier: extend event filter documentation at config file.
by oourfali＠redhat.com 06 Nov '14

06 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: extend event filter documentation at config file. ...................................................................... notifier: extend event filter documentation at config file. Change-Id: Ie1596a00cf079227020167e519a5287c6d5f9cca Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1596a00cf079227020167e519a5287c6d5f9cca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainI...
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType ...................................................................... core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool ...................................................................... core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Objections: automation(a)ovirt.org: Fails -- To view, visit http://gerrit.ovirt.org/34864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed the getStorageDomainId Method
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed the getStorageDomainId Method ...................................................................... core: Renamed the getStorageDomainId Method The method's name implies that it's a simple getter, even though it does not always return the expected storage domain even if it exists (permissions issues for example). Thus, renamed to getStorageDomainIdForQuery. Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0