Change in ovirt-node-plugin-vdsm[master]: hooks: Move sanlock upgrade hook to post-upgrade
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: hooks: Move sanlock upgrade hook to post-upgrade
......................................................................
hooks: Move sanlock upgrade hook to post-upgrade
Previously the sanlock upgrade loogic was run on boot, and that broken
vdsm's boot on el7/systemd based systems.
Now the logic is run post-upgrade and not at boot time.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156369
Change-Id: I53d63c393e884901eb45f1ac38e8bf2795dbaeb7
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M configure.ac
M hooks/Makefile.am
R hooks/on-boot/02-vdsm-sebool-config
R hooks/post-upgrade/01-sanlock-check
M ovirt-node-plugin-vdsm.spec.in
5 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53d63c393e884901eb45f1ac38e8bf2795dbaeb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: restapi: Avoid NPE in request for CDROMs of wrong VM
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid NPE in request for CDROMs of wrong VM
......................................................................
restapi: Avoid NPE in request for CDROMs of wrong VM
Currently when we receive a request for the collection of CDROMs of a VM
we don't take into account that the query performed to find the VM can
return null if there isn't such a VM (the identifier is wrong, or the VM
has been removed). To avoid that NPE this patch checks the result of the
query and will respond with an empty list in those cases.
Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3
Bug-Url: https://bugzilla.redhat.com/1150953
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: jsonrpc: version bump
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: jsonrpc: version bump
......................................................................
jsonrpc: version bump
Bug-Url: https://bugzilla.redhat.com/1154398
Change-Id: Ib69768ab2b384136308e16624a365c98583fba63
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib69768ab2b384136308e16624a365c98583fba63
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in mom[master]: build: Fix mom.spec.in changelog
by alitke＠redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: build: Fix mom.spec.in changelog
......................................................................
build: Fix mom.spec.in changelog
During the rewrite of the mom build process (707326d4) an old bug in our
spec file crept back in. The 12th of January in 2011 was on a
Wednesday.
Change-Id: Ic50c5f6ff5c9841cc22c3d5be5e118e2d65f5806
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34937
Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M mom.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic50c5f6ff5c9841cc22c3d5be5e118e2d65f5806
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: add support for EL7 builds
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: spec: add support for EL7 builds
......................................................................
packaging: spec: add support for EL7 builds
Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f
Bug-Url: https://bugzilla.redhat.com/1159293
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-scheduler-proxy[master]: packaging: spec: add support for EL7 builds
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: packaging: spec: add support for EL7 builds
......................................................................
packaging: spec: add support for EL7 builds
Change-Id: Ibd5ab8617a1a98b9973b28cfc3b8ebda414198ce
Bug-Url: https://bugzilla.redhat.com/1159293
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-scheduler-proxy.spec.in
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd5ab8617a1a98b9973b28cfc3b8ebda414198ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: Empty Change CD List when ISO is Inactive
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Empty Change CD List when ISO is Inactive
......................................................................
core: Empty Change CD List when ISO is Inactive
The VM's Change CD list should be empty when the ISO domain in the DC is
inactive.
Change-Id: I784be2510e2f51be277f7ee06a5bd5573ab23d66
Bug-Url: https://bugzilla.redhat.com/1085398
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/storages_sp.sql
9 files changed, 159 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I784be2510e2f51be277f7ee06a5bd5573ab23d66
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.5]: packaging: spec: add support for EL7 builds
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: spec: add support for EL7 builds
......................................................................
packaging: spec: add support for EL7 builds
Change-Id: I1672e50c4977b4fb1ad97da9e661d5794b11d1e9
Bug-Url: https://bugzilla.redhat.com/1159293
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
1 file changed, 14 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1672e50c4977b4fb1ad97da9e661d5794b11d1e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.5]: packaging: fixes a warning while building
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: fixes a warning while building
......................................................................
packaging: fixes a warning while building
[WARNING]
[WARNING] Some problems were encountered while building the effective
model for
org.ovirt.engine.sdk:ovirt-engine-sdk-java:jar:3.6.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-eclipse-plugin is missing. @ line 143,
column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they
threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
Change-Id: I2924b7deb5b712e472721ea53bfa8d87513e2516
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine-sdk-java/pom.xml
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2924b7deb5b712e472721ea53bfa8d87513e2516
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.5]: packaging: spec: update spec syntax
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: spec: update spec syntax
......................................................................
packaging: spec: update spec syntax
Solves:
***************************************************************
* WARNING! mvn-rpmbuild is deprecated and it will be removed *
* in future. Users should migrate to using %mvn_build macro *
* or call XMvn directly if greater flexibility is required. *
***************************************************************
Change-Id: Ib81f345772db5da4d23cf1ee917b3d11e85b3ed6
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib81f345772db5da4d23cf1ee917b3d11e85b3ed6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month