November 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine : query execution failed due to insufficient permissions

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine : query execution failed due to insufficient permissions ...................................................................... engine : query execution failed due to insufficient permissions Adding a disk using a user with DiskCreator privileges logs insufficient permissions message in the log Change-Id: I11adfe9c49d1e57ecc88d1828ed63884016c33e8 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11adfe9c49d1e57ecc88d1828ed63884016c33e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Add User Id to async tasks table

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine : Add User Id to async tasks table ...................................................................... engine : Add User Id to async tasks table Add user id to async tasks table, the user id will be used to determine if the user has permissions to see the tasks for which the user requested statuses When tasks are retrieved from vdsm after server restart the user id information is not available and will be set to Guid.Empty when tasks are created Change-Id: Ib5b9f3dfb38d6d56f186aa87f3ff75007a0d3997 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTask.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M packaging/dbscripts/async_tasks_sp.sql A packaging/dbscripts/upgrade/03_05_1150_add_user_id_to_async_tasks.sql 7 files changed, 73 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b9f3dfb38d6d56f186aa87f3ff75007a0d3997 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: spec: add support for EL7 builds

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds Change-Id: I5faef659a862f720fd02ef219d6a178e099ab66d Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4b1608d13ccd07fcc0c488d0b36ffe915e94d59f) --- M ovirt-engine-dwh.spec.in 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5faef659a862f720fd02ef219d6a178e099ab66d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Check live snapshot capabilities in live storage migra...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Check live snapshot capabilities in live storage migration CDA ...................................................................... core: Check live snapshot capabilities in live storage migration CDA Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Bug-Url: https://bugzilla.redhat.com/1158049 Bug-Url: https://bugzilla.redhat.com/1105846 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 4 files changed, 56 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Check live snapshot capabilities in live storage migra...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Check live snapshot capabilities in live storage migration CDA ...................................................................... core: Check live snapshot capabilities in live storage migration CDA Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Bug-Url: https://bugzilla.redhat.com/1158049 Bug-Url: https://bugzilla.redhat.com/1105846 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 4 files changed, 56 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: osinfo: Add rhel7/ppc64 into osinfo

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: osinfo: Add rhel7/ppc64 into osinfo ...................................................................... osinfo: Add rhel7/ppc64 into osinfo Change-Id: Ifb39e75a583e17703369bb07221b6d1f50ab2cf8 Bug-Url: https://bugzilla.redhat.com/1151053 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java M packaging/conf/osinfo-defaults.properties 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb39e75a583e17703369bb07221b6d1f50ab2cf8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: osinfo: Add rhel7/ppc64 into osinfo

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: osinfo: Add rhel7/ppc64 into osinfo ...................................................................... osinfo: Add rhel7/ppc64 into osinfo Change-Id: Ifb39e75a583e17703369bb07221b6d1f50ab2cf8 Bug-Url: https://bugzilla.redhat.com/1151053 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java M packaging/conf/osinfo-defaults.properties 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb39e75a583e17703369bb07221b6d1f50ab2cf8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Stop remote dwh

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Stop remote dwh ...................................................................... packaging: setup: Stop remote dwh Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a Bug-Url: https://bugzilla.redhat.com/1024028 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 191752b556ee40de5e43f193dbc45bb64da1e54e) --- A packaging/setup/ovirt_engine_setup/engine_common/dwh_history_timekeeping.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 3 files changed, 226 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Shirly Radco: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/34817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Drop legacy SysPrep paths from config

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: Drop legacy SysPrep paths from config ...................................................................... core: Drop legacy SysPrep paths from config Change-Id: I675340ae90aa724b935b0cf0a25544c06b0177eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1086768 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 3 files changed, 10 insertions(+), 61 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I675340ae90aa724b935b0cf0a25544c06b0177eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: osinfo - fail backend startup on coliding os id error

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: osinfo - fail backend startup on coliding os id error ...................................................................... core: osinfo - fail backend startup on coliding os id error fail loading the backend by throwing a RuntimeException if an osinfo properties have colliding id's. e.g os.linux.id.value = 12345 os.windows.id.value = 12345 obviously wrong and should fail with logged exception "java.lang.RuntimeException: colliding os id 12345 at node /os/windows/id" Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d Bug-Url: https://bugzilla.redhat.com/996055 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2014