Change in ovirt-engine[master]: frontend: Correct RunOnce Iso selection
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Correct RunOnce Iso selection
......................................................................
frontend: Correct RunOnce Iso selection
RunOnceDialog ignored persistent configuration of selected CD and
also didn't support unchecking the CD. (Frontend would display as not
attached CD but would run with attached CD anyway)
Now we support that by defaulting the RunVmParams#diskPath to be null
when the user explicitly uncheck the "Attach CD" checkbox.
We also pre-select the value of VmBase#isoPath in the iso listbox.
Change-Id: I714d8fad60673608d58ade4463c4abbcb5eb3f08
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026306
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054743
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
3 files changed, 19 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/25957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I714d8fad60673608d58ade4463c4abbcb5eb3f08
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: frontend: Generify RunOnceModel & VmInitModel
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Generify RunOnceModel & VmInitModel
......................................................................
frontend: Generify RunOnceModel & VmInitModel
Utilize generic EntityModels in RunOnceModel and VmInitModel and
associated widgets.
In order to generify the ComboBox class used int both models also the
VolumeParameterModel was generified to be consistent with the new
generic ComboBox usage.
Also removed now unused deprecated EntityModelTextArea and
EntityModelTextAreaEditor.
Change-Id: I378b2151bda422ec5997cc82cbeb3ef24f940416
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.ui.xml
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextArea.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextAreaEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.ui.xml
16 files changed, 425 insertions(+), 491 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/26052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I378b2151bda422ec5997cc82cbeb3ef24f940416
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: use engine package env for versionlock
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: use engine package env for versionlock
......................................................................
packaging: setup: use engine package env for versionlock
Compliment Ibad05b1e0283b0b27fb278a0ba15b3f7e95d747c
Bug-Url: https://bugzilla.redhat.com/1076046
Change-Id: I5bcd649ee872269b9e687e0517a5b6de6f81284d
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py
2 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/26102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bcd649ee872269b9e687e0517a5b6de6f81284d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: packaging: setup: use engine package env for versionlock
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: use engine package env for versionlock
......................................................................
packaging: setup: use engine package env for versionlock
Compliment Ibad05b1e0283b0b27fb278a0ba15b3f7e95d747c
Bug-Url: https://bugzilla.redhat.com/1076046
Change-Id: I5bcd649ee872269b9e687e0517a5b6de6f81284d
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py
2 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/26100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bcd649ee872269b9e687e0517a5b6de6f81284d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: api: Wrong parameter is passed to GetDomainsListQuery
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: api: Wrong parameter is passed to GetDomainsListQuery
......................................................................
api: Wrong parameter is passed to GetDomainsListQuery
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080247
Change-Id: Iedf209e561789b344fc89e223f79a3992310675c
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedf209e561789b344fc89e223f79a3992310675c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: core: change domains status to unknown when there are no rep...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: change domains status to unknown when there are no reporting hosts
......................................................................
core: change domains status to unknown when there are no reporting hosts
Currently the monitored pool domains 'change' their statuses according to
the reports received by the pool hosts that are in status UP.
When there are no reporting hosts - the status of the pool domains that are
monitored should be changed to unknown, because otherwise nothing will trigger
the status change. In that case (an example) we might be left with a domain
in 'active' status although there are no reporting hosts.
Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=975742
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java
5 files changed, 90 insertions(+), 48 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Ar: Verified
--
To view, visit http://gerrit.ovirt.org/26077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: filter out unsupported architectures
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: filter out unsupported architectures
......................................................................
webadmin: filter out unsupported architectures
Unsupported architecture is one that doesn't have a configured cpu to
support it (its a vdc_options). Those archs are useless effectively so
no point showing them in the dropdown.
Change-Id: I7568e61882478f10bec614ddf514b32d23adc199
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 13 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Roy Golan: Verified
--
To view, visit http://gerrit.ovirt.org/26078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7568e61882478f10bec614ddf514b32d23adc199
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core : Upgrading a hypervisor automatically puts it into an ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core : Upgrading a hypervisor automatically puts it into an Up state
......................................................................
core : Upgrading a hypervisor automatically puts it into an Up state
When upgrading a hypervisor via the admin portal, once
the install is finished the hypervisor returns (or tries
to return) to an Up state
Change-Id: Ib94ba543b347aab4eafe326e7fce84aac163be25
Bug-Url: https://bugzilla.redhat.com/1073070
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
4 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/25853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib94ba543b347aab4eafe326e7fce84aac163be25
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-hosted-engine-ha[master]: Fix ommision in the backend API refactoring
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Fix ommision in the backend API refactoring
......................................................................
Fix ommision in the backend API refactoring
The get_all_host_stats_direct used the old dom_path attribute.
Change-Id: Ia52a66836d9bf5a0cd9980d497b56ddceab8f7ca
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
M ovirt_hosted_engine_ha/client/client.py
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jiří Moskovčák: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia52a66836d9bf5a0cd9980d497b56ddceab8f7ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: core: fix import of cloned template
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix import of cloned template
......................................................................
core: fix import of cloned template
When importing template as clone, it set wrong template base id,
as the id of the template is re-generated.
cloned import is a new entity so it should always be a base template
Change-Id: Ia8cdd44a1803995d28b806668dfdb6ea8e59597e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073019
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/25892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8cdd44a1803995d28b806668dfdb6ea8e59597e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years