March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: Fix setup of additional host - it used the old backend API
by sbonazzo＠redhat.com 26 Mar '14

26 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix setup of additional host - it used the old backend API ...................................................................... Fix setup of additional host - it used the old backend API Change-Id: I57143f2104232aecf1fc92bbe32b07e8cdf4c9ad Bug-Url: https://bugzilla.redhat.com/1079956 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 2 files changed, 8 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Verified Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57143f2104232aecf1fc92bbe32b07e8cdf4c9ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typos in canDo messages
by ofrenkel＠redhat.com 26 Mar '14

26 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix typos in canDo messages ...................................................................... core: fix typos in canDo messages Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080356 Change-Id: If7deb6de9bb3c2bc84bf9911104391fdf50d9fc0 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7deb6de9bb3c2bc84bf9911104391fdf50d9fc0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Fix cloud-init host name
by oourfali＠redhat.com 26 Mar '14

26 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix cloud-init host name ...................................................................... restapi: Fix cloud-init host name When sending a request to start a VM using cloud-init the host name should be included using the "address" element, as follows: <cloud_init> <host> <address>the_host_name</address> </host> </cloud_init> But this is incorrectly documented in the RSDL metadata as follows: action.vm.initialization.cloud_init.hostname: 'xs:string' This induces wrong documentation in the Python SDK, which in turn induces a wrong behaviour of the CLI auto-completion. The right way to document this in the RSDL is the following: action.vm.initialization.cloud_init.host.address: 'xs:string' Change-Id: I5d3159cf476f881c1fe0e6955b1be44f69f94e58 Bug-Url: https://bugzilla.redhat.com/1080033 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6bafe304d82aa54f7b781b8a166681f82de4b602) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/26074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d3159cf476f881c1fe0e6955b1be44f69f94e58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: pki: enforce lock file permissions same as ca private key
by oourfali＠redhat.com 26 Mar '14

26 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: pki: enforce lock file permissions same as ca private key ...................................................................... pki: enforce lock file permissions same as ca private key Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075209 Change-Id: I89d1bee3c7fff1bae2ee555d556e35171bef612c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-enroll-request.sh 1 file changed, 30 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d1bee3c7fff1bae2ee555d556e35171bef612c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: better message on import template version
by oourfali＠redhat.com 26 Mar '14

26 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: better message on import template version ...................................................................... core: better message on import template version when trying to add a template version, which its base template is missing, the message you get is not clear. in this patch a better message provided. Change-Id: I9fbf2c45c03fe9838bf25be5529c93c322372b28 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073035 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fbf2c45c03fe9838bf25be5529c93c322372b28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in MigrateVDSCommand
by ofrenkel＠redhat.com 25 Mar '14

25 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in MigrateVDSCommand ...................................................................... core: minor cleanup in MigrateVDSCommand Change-Id: I55b4365d9a71a47b4a72f98bae649a363f43ef03 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 40 insertions(+), 34 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55b4365d9a71a47b4a72f98bae649a363f43ef03 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pythonlib: java: improve error when no jre is available
by sbonazzo＠redhat.com 25 Mar '14

25 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: pythonlib: java: improve error when no jre is available ...................................................................... pythonlib: java: improve error when no jre is available Change-Id: I01c5af5ff47e26f0f2cf13df2be99351758634ee Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/java.py 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c5af5ff47e26f0f2cf13df2be99351758634ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix popup text, when dashboard is accessed 1st time
by oourfali＠redhat.com 25 Mar '14

25 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix popup text, when dashboard is accessed 1st time ...................................................................... webadmin: Fix popup text, when dashboard is accessed 1st time Rephrase popup message when dashboard is not yet deployed. Change-Id: I2a18685754334ebbf181e8c647c33cbb7ad77ecf Bug-Url: https://bugzilla.redhat.com/1075948 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a18685754334ebbf181e8c647c33cbb7ad77ecf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetVmTemplatesByStoragePoolIdQuery did not return anyt...
by tjelinek＠redhat.com 25 Mar '14

25 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: GetVmTemplatesByStoragePoolIdQuery did not return anything ...................................................................... core: GetVmTemplatesByStoragePoolIdQuery did not return anything The problem was a regression introduced in 88756e3897ba467eb50055a7dda0c1afb11295d0 due to which an incorrect DB call was called. Fixed by implementing the proper DB call (getAllForStoragePool). Change-Id: I62627ca3a9942901abda1ee7522e8f0de1f29764 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M packaging/dbscripts/vm_templates_sp.sql 4 files changed, 33 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62627ca3a9942901abda1ee7522e8f0de1f29764 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: order of operations when deactivating the last master ...
by oourfali＠redhat.com 25 Mar '14

25 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: order of operations when deactivating the last master domain ...................................................................... core: order of operations when deactivating the last master domain When deactivating the master domain and there's no other domain to migrate the master to, the hsms can be disconnected from the pool only after the spm was stopped to avoid having them being disconnected from the pool in case that we failed to stop the spm which will cause them to move to non op as they won't have repoStats on the domains. Change-Id: I9d9dcf86a7a1f49175435807816a208d4506a7b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054108 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 21 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/26051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9dcf86a7a1f49175435807816a208d4506a7b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0