March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: set custom properties correctly on run once
by ahadas＠redhat.com 10 Mar '14

10 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: set custom properties correctly on run once ...................................................................... webadmin: set custom properties correctly on run once Fix run once flow such that the custom properties will be set from the CustomPropertySheet as they should be. Change-Id: I30bb6393a5b95e5ea6d0447e7f953e0f4830dc77 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java 2 files changed, 1 insertion(+), 16 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30bb6393a5b95e5ea6d0447e7f953e0f4830dc77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: build: ovirt-hosted-engine-setup-1.1.1
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.1.1 ...................................................................... build: ovirt-hosted-engine-setup-1.1.1 Change-Id: Ib2cf4fa9c900c9139639109b72c23ac762cf7201 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2cf4fa9c900c9139639109b72c23ac762cf7201 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: fix example in configuration file.
by iheim＠redhat.com 10 Mar '14

10 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: fix example in configuration file. ...................................................................... tools: fix example in configuration file. The SNMP_MANAGERS example contains space and no quotes. Users following this example will lose all but first snmp managers. Change-Id: I30de620597eba51a0955d0d6c5cd1c4232c1ab44 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1074431 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30de620597eba51a0955d0d6c5cd1c4232c1ab44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: [Fix] Template without migration downtime
by iheim＠redhat.com 10 Mar '14

10 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: [Fix] Template without migration downtime ...................................................................... webadmin: [Fix] Template without migration downtime Template is created with no default value for migration downtime, the screen does not close, it requires data. Change-Id: I478ad01793a9ff22f18d22eb775527252a2ca4b4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066617 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Omer Frenkel: Verified Michal Skrivanek: Verified -- To view, visit http://gerrit.ovirt.org/24709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478ad01793a9ff22f18d22eb775527252a2ca4b4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: support disable environment validations
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: support disable environment validations ...................................................................... packaging: build: support disable environment validations Change-Id: Ib37daa19b21b10cc0b1da9884c5abe40decd9445 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib37daa19b21b10cc0b1da9884c5abe40decd9445 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: fix example in configuration file.
by emesika＠redhat.com 10 Mar '14

10 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: fix example in configuration file. ...................................................................... tools: fix example in configuration file. The SNMP_MANAGERS example contains space and no quotes. Users following this example will lose all but first snmp managers. Change-Id: I30de620597eba51a0955d0d6c5cd1c4232c1ab44 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1074431 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved mooli tayer: Verified Objections: Sandro Bonazzola: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/25497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30de620597eba51a0955d0d6c5cd1c4232c1ab44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: remove mixed StringBuilder.append and +
by emesika＠redhat.com 10 Mar '14

10 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: remove mixed StringBuilder.append and + ...................................................................... tools: remove mixed StringBuilder.append and + Change-Id: I252e1cb04c97e1def77376c0268c6fc1b4d443a2 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I252e1cb04c97e1def77376c0268c6fc1b4d443a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: tools: snmp: fix 'minimal snmp configuration' section in con...
by sbonazzo＠redhat.com 09 Mar '14

09 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: snmp: fix 'minimal snmp configuration' section in conf file ...................................................................... tools: snmp: fix 'minimal snmp configuration' section in conf file key name has to be FILTER and not FILTERS. users using current example will not get any snmp notification. Change-Id: I0202abfd9c2d26e41d2073a293e27d983f7578f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072849 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/25420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0202abfd9c2d26e41d2073a293e27d983f7578f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: webadmin: [Labels] SetupNetwork emphasize unconfigured inter...
by sbonazzo＠redhat.com 09 Mar '14

09 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: webadmin: [Labels] SetupNetwork emphasize unconfigured interface ...................................................................... webadmin: [Labels] SetupNetwork emphasize unconfigured interface Network which is in fact not attached to the interface (but has the same label as the interface) looks like attached in Setup Networks dialogue. Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Bug-Url: https://bugzilla.redhat.com/1067928 Bug-Url: https://bugzilla.redhat.com/1065270 Bug-Url: https://bugzilla.redhat.com/1068267 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 7 files changed, 100 insertions(+), 31 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: wedamdin: NPE when removing label from interface/bond
by sbonazzo＠redhat.com 09 Mar '14

09 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: wedamdin: NPE when removing label from interface/bond ...................................................................... wedamdin: NPE when removing label from interface/bond When removing label from a nic with no 'network labels' attached to it there was NPE. Added safe check to fix this issue. Change-Id: I18619a212503731586c68dc414e51ae12e52fefa Bug-Url: https://bugzilla.redhat.com/1063762 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18619a212503731586c68dc414e51ae12e52fefa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0