April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Remove unused variable
by emesika＠redhat.com 02 Apr '14

02 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: Remove unused variable ...................................................................... engine: Remove unused variable Change-Id: I21af1c90a1ca6dce29fb6f9409b7b5059a48ff38 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/26245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21af1c90a1ca6dce29fb6f9409b7b5059a48ff38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: docs internal server error
by ecohen＠redhat.com 02 Apr '14

02 Apr '14

Einav Cohen has submitted this change and it was merged. Change subject: engine: docs internal server error ...................................................................... engine: docs internal server error - If you try to load a manual document in a locale that doesn't exist, the server would throw a 500 due to a problem in the setup of path of the DocsServlet. This patch fixes that issue. Change-Id: I3036d05e736a4bc2603423fb7041910a9daa1472 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083528 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3036d05e736a4bc2603423fb7041910a9daa1472 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add private c'tor to QuotaManager
by gchaplik＠redhat.com 02 Apr '14

02 Apr '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Add private c'tor to QuotaManager ...................................................................... engine: Add private c'tor to QuotaManager To enfoce the use of getInstance(), marked the c'tor as private Change-Id: I63ef8b265a87a517632c17cd4e38fde83ed47204 Bug-Url: none Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jiří Moskovčák: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/26359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63ef8b265a87a517632c17cd4e38fde83ed47204 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: skipping DOWN hosts in PM proxy selection
by oourfali＠redhat.com 02 Apr '14

02 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: skipping DOWN hosts in PM proxy selection ...................................................................... core: skipping DOWN hosts in PM proxy selection Hosts with DOWN state were not filtered out when no UP Host available and we are looking for Hosts in other statuses. This patch addresses this issue and filter out all Hosts with DOWN status. Change-Id: Ie12002cbdbf025d5e53b2283dee7b373dac2a0a4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073896 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie12002cbdbf025d5e53b2283dee7b373dac2a0a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: customization: fixed issue with log4j JRS patch
by ydary＠redhat.com 02 Apr '14

02 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: customization: fixed issue with log4j JRS patch ...................................................................... packaging: customization: fixed issue with log4j JRS patch Bug-Url: https://bugzilla.redhat.com/1083501 Change-Id: Ic87f7aaf9f3a7444845eb1b7bc8fb9b3f4c3d4c1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/jasper-war-patches/ce/900_004_props_change_logs_location.patch.in M packaging/jasper-war-patches/pro/900_004_props_change_logs_location.patch.in 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic87f7aaf9f3a7444845eb1b7bc8fb9b3f4c3d4c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Avoiding legacy health servlet usage
by sbonazzo＠redhat.com 02 Apr '14

02 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Avoiding legacy health servlet usage ...................................................................... Avoiding legacy health servlet usage Avoidind legacy health servlet usage to check engine health in favor of REST API. Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026723 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py 1 file changed, 30 insertions(+), 33 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce boot time field in VDS
by emesika＠redhat.com 02 Apr '14

02 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Introduce boot time field in VDS ...................................................................... core: Introduce boot time field in VDS Added boot time as long with seconds since epoch to VDS db record, VDS struct and REST API. Change-Id: I0ec679a4ce5ddfbc1735db380feab69eb3798ae6 Bug-Url: https://bugzilla.redhat.com/1070348 Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0170_add_boot_time_to_vds_statistics.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 13 files changed, 50 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Dima Kuznetsov: Verified -- To view, visit http://gerrit.ovirt.org/25880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ec679a4ce5ddfbc1735db380feab69eb3798ae6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: br16 report - added comments to queries
by ydary＠redhat.com 02 Apr '14

02 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br16 report - added comments to queries ...................................................................... reports: br16 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I84448da418837c6aae3a0a79d42ab072d0fd5c01 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/report3.jrxml.data 2 files changed, 663 insertions(+), 485 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84448da418837c6aae3a0a79d42ab072d0fd5c01 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-3.3]: build: ovirt-engine-dwh-3.3.5-rc
by ydary＠redhat.com 02 Apr '14

02 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.3.5-rc ...................................................................... build: ovirt-engine-dwh-3.3.5-rc Also added release notes Change-Id: Ib80272f5a18e426fc3f71952b0520431c9ccb2ad Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib80272f5a18e426fc3f71952b0520431c9ccb2ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: bin: add the host to a specific cluster
by sbonazzo＠redhat.com 02 Apr '14

02 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add the host to a specific cluster ...................................................................... bin: add the host to a specific cluster Fix bz #1059950 - Ask the user which cluster to use. Default cluster is 'Default' if exists. Otherwise, the default is engine_api.clusters.list()[0] Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Signed-off-by: Meital Bourvine <mbourvin(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Bug-Url: http://bugzilla.redhat.com/1059950 Bug-Url: http://bugzilla.redhat.com/1043906 --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 29 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <mbourvin(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Meital bourvine <meitalbourvine(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0