August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core:typo in power management health check warning
by oourfali＠redhat.com 29 Aug '14

29 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core:typo in power management health check warning ...................................................................... core:typo in power management health check warning Change-Id: I4f8fc5e2d0ab850208cf50cf411ed7a898ee3887 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129621 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f8fc5e2d0ab850208cf50cf411ed7a898ee3887 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fixing a missing fencing audit log message
by piotr.kliczewski＠gmail.com 29 Aug '14

29 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: fixing a missing fencing audit log message ...................................................................... core: fixing a missing fencing audit log message This patch fixes the message to the audit log where the Host is set to Connecting state. The patches addresses 1) fix the audit log key from VDS_HOST_IN_CONNECTING_STATE which had no message to VDS_HOST_NOT_RESPONDING_CONNECTING 2) add a flood rate to this audit log such that it will not logged in each network exception event 3) fix a minor issue in the regular engine log ( ${1} => {1} ) Change-Id: I33b683664a33fa27df283e0abc448eb6564b678e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070674 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33b683664a33fa27df283e0abc448eb6564b678e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Alignment issues in run once dialog
by piotr.kliczewski＠gmail.com 29 Aug '14

29 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal,webadmin: Alignment issues in run once dialog ...................................................................... userportal,webadmin: Alignment issues in run once dialog 2 issues: - cloud init / network: in FR locale did not fit in. Fixed by making the dialog big enough that everything fits in - display / SPICE copy paste and SPICE file trenasfer label did not fit in. Fixed by making the checkboxes' labels bigger (same approach as on new / edit VM dialog) Change-Id: I37cf4c8909301ac3da6d414d0021af68d221f994 Bug-Url: https://bugzilla.redhat.com/1123749 Bug-Url: https://bugzilla.redhat.com/1123237 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java 4 files changed, 21 insertions(+), 6 deletions(-) Approvals: Frank Kobzik: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37cf4c8909301ac3da6d414d0021af68d221f994 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: search by user and groups name when added via rest-api
by yzaslavs＠redhat.com 29 Aug '14

29 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: search by user and groups name when added via rest-api ...................................................................... aaa: search by user and groups name when added via rest-api Topic: AAA Change-Id: I76c5d7647d8dff5c9f2f67e42e094e883ac2164b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapQueryMetadataFactoryImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java 5 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c5d7647d8dff5c9f2f67e42e094e883ac2164b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
by derez＠redhat.com 28 Aug '14

28 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao ...................................................................... core: RemoveDiskSnapshot rollback - fetch disk by DiskDao RemoveDiskSnapshotTaskHandler -> * endWithFailure: Fetching a disk by imageGroupId should be done using DiskDao. * endRemoveSnapshotSingleDisk: update TaskGroupSuccess appropriately. Change-Id: I9b6d811a86c353087479de1fc25276be62df4bec Bug-Url: https://bugzilla.redhat.com/1134382 Bug-Url: https://bugzilla.redhat.com/1134434 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotTaskHandler.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b6d811a86c353087479de1fc25276be62df4bec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: soundcard not persisted on new instance type
by tnisan＠redhat.com 28 Aug '14

28 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: soundcard not persisted on new instance type ...................................................................... core: soundcard not persisted on new instance type The problem was that the sondcard was persisted only when there was a cluster. This is not the case for the instance type. Solved the same way as for the new instance type (sending null cluster version). Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751 Bug-Url: https://bugzilla.redhat.com/1124270 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Monitor should not crash when unexpected exception happens
by alitke＠redhat.com 28 Aug '14

28 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: Monitor should not crash when unexpected exception happens ...................................................................... Monitor should not crash when unexpected exception happens The monitor thread should report the crash to log, behave as if nothing was collected and try again in the next cycle. The unexpected exception might be triggered for example by a freshly finished migration. The guest monitor reads the /proc files that belong to the migrated process and they disappear as a result of qemu performing the post-migration cleanup. Change-Id: I318c55a3215df8ccaf4b0e2d16d1d9a3b06f9d1c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124595 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/32030 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Monitor.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/32030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I318c55a3215df8ccaf4b0e2d16d1d9a3b06f9d1c Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: packaging: setup: drop legacy 3.2 patch
by sbonazzo＠redhat.com 28 Aug '14

28 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: drop legacy 3.2 patch ...................................................................... packaging: setup: drop legacy 3.2 patch Change-Id: Ibeff28ec86c5efafeb67c9a20070275f17748d7f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D centos/oVirtLiveFiles/patches/0001-oVirtLive-patches.patch 1 file changed, 0 insertions(+), 91 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeff28ec86c5efafeb67c9a20070275f17748d7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi:Fix CRUD operations for iSCSI Storage connection.
by mlipchuk＠redhat.com 28 Aug '14

28 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. ...................................................................... restapi:Fix CRUD operations for iSCSI Storage connection. 1) renaming class BackendIscsiBondStorageServerConnection to BackendIscsiBondStorageConnectionResource to be compatible with the plural resource name 2) Fix remove and get operations for Storage Connection in IscsiBond 3) Adding appropriate tests for resource commands in REST. Usages: Get a list of Storage Connections contained in the iSCSI bond: Get /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/ Get a specific Storage Connection in the iSCSI bond: Get /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/ Adding a new Storage Connection to an existing iSCSI Bond: POST /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1 Accept: application/xml <storage_connection id="{connection_id}"></storage_connection> Remove a Storage Connection from the existing iSCSi Bond: DELETE /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/ HTTP/1.1 Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5 Bug-Url: https://bugzilla.redhat.com/1133896 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageServerConnection.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResourceTest.java 5 files changed, 288 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/31979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Initialize internal lists in IscsiBond
by mlipchuk＠redhat.com 28 Aug '14

28 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Initialize internal lists in IscsiBond ...................................................................... core: Initialize internal lists in IscsiBond Initialize the storage domains and the networks when fectching IscsiBond from query command, also adding a test to the query. Change-Id: I167b1c6d6c5f83022c18faad555c0ff2e6f1f44b Bug-Url: https://bugzilla.redhat.com/1133279 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetIscsiBondByIdQueryTest.java 3 files changed, 142 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/31859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I167b1c6d6c5f83022c18faad555c0ff2e6f1f44b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0