September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: do not display non password authn profiles within login
by yzaslavs＠redhat.com 11 Sep '14

11 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: do not display non password authn profiles within login ...................................................................... aaa: do not display non password authn profiles within login they are useless in this location. Topic: AAA Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java 6 files changed, 22 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup AddVmParameters constructors
by ahadas＠redhat.com 10 Sep '14

10 Sep '14

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup AddVmParameters constructors ...................................................................... core: cleanup AddVmParameters constructors In order to generalize AddVmParameters for AddVmCommand + AddVmFromTemplate + AddVmFromScratch, the list of disks and storage domain ID are removed from the arguments lists of the constructors. Those values can be set by using the setter methods when needed. Change-Id: I06f2de3db1b0559af4df04d0d158b10b8460c684 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 7 files changed, 20 insertions(+), 26 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06f2de3db1b0559af4df04d0d158b10b8460c684 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Report unreachable domain names when setting host as n...
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Report unreachable domain names when setting host as non operational ...................................................................... core: Report unreachable domain names when setting host as non operational When setting a host as non operational because an error reaching one storage domain, the audit log will now report the name of the unreachable storage domains Change-Id: I6b68d1c2a387c84e97137b27f00956870fd96357 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1116820 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b68d1c2a387c84e97137b27f00956870fd96357 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Data storage domain does not always activate when ...
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Data storage domain does not always activate when created ...................................................................... webadmin: Data storage domain does not always activate when created When importing an ISO storage domain without the activation flag and then immediately creating a data storage domain, the data storage domain is added in maintenance mode Bug-Url: https://bugzilla.redhat.com/1116572 Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: hooks: Add 02-sanlock-check into on-boot
by fabiand＠redhat.com 10 Sep '14

10 Sep '14

Fabian Deutsch has submitted this change and it was merged. Change subject: hooks: Add 02-sanlock-check into on-boot ...................................................................... hooks: Add 02-sanlock-check into on-boot Add 02-sanlock-check into on-boot to create sanlock user/group ifmissing during upgrade. Change-Id: I63101a8811978afe33b4152335e62bf5c3b54e00 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127122 Signed-off-by: hadong <hadong(a)redhat.com> --- M hooks/Makefile.am A hooks/on-boot/02-sanlock-check M ovirt-node-plugin-vdsm.spec.in 3 files changed, 29 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved Douglas Schilling Landgraf: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63101a8811978afe33b4152335e62bf5c3b54e00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: hadong <hadong0720(a)gmail.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix Maintenance Hosts dialog missing padding
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix Maintenance Hosts dialog missing padding ...................................................................... webadmin: fix Maintenance Hosts dialog missing padding Maintenance Hosts dialog missing left and right padding, on the second paragraph. Fixed. Change-Id: I66b05612c083228a8e7069282a167548ed39c92e Bug-Url: https://bugzilla.redhat.com/1139930 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66b05612c083228a8e7069282a167548ed39c92e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Data storage domain does not always activate when ...
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Data storage domain does not always activate when created ...................................................................... webadmin: Data storage domain does not always activate when created When importing an ISO storage domain without the activation flag and then immediately creating a data storage domain, the data storage domain is added in maintenance mode Bug-Url: https://bugzilla.redhat.com/1116572 Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: fixed spacing for grids
by awels＠redhat.com 10 Sep '14

10 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin, userportal: fixed spacing for grids ...................................................................... webadmin, userportal: fixed spacing for grids CSS for first columns in all grids was broken such that left padding wasn't applied. Fixed. Also added a bit more padding between cells to prevent text in adjacent cells from being 0 pixels apart. Also noticed that icons in grids (comment icon, VM circle icon, etc.) were not centered. Fixed. Change-Id: Id5a759b8208b17bb9378a8b3f3362c20ca02add9 Bug-Url: https://bugzilla.redhat.com/1131975 Bug-Url: https://bugzilla.redhat.com/1127674 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a759b8208b17bb9378a8b3f3362c20ca02add9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: check storage domains status on master deactivation
by amureini＠redhat.com 10 Sep '14

10 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: check storage domains status on master deactivation ...................................................................... core: check storage domains status on master deactivation When deactivating the master storage domain we should make sure that the other domains are not in transition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128824 Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix typo for QoS
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix typo for QoS ...................................................................... webadmin: Fix typo for QoS Fixed the "Write IOps" column from "Read IOps" -> "Write IOps". Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Bug-Url: https://bugzilla.redhat.com/1139731 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/32777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0