November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Host->General software sub tab
by awels＠redhat.com 20 Nov '15

20 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Host->General software sub tab ...................................................................... webadmin: Host->General software sub tab - Fixed issue with layout of host general software sub sub tab. This now takes the entire available width of the panel instead of 1/4 of the available size. Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281297 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: errata table sorting
by awels＠redhat.com 20 Nov '15

20 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: errata table sorting ...................................................................... webadmin: errata table sorting - Added sorting capabilities to the errata tables Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283117 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ErrataTableView.java 1 file changed, 33 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization
by piotr.kliczewski＠gmail.com 20 Nov '15

20 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization ...................................................................... webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization ActionGroup___CONNECT_TO_SERIAL_CONSOLE() was missing in LocalizedEnum. Change-Id: Iab20b9f8aa933528e0381b495c1adf973959a7eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281328 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Tomas Jelinek: Looks good to me, approved Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/48752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab20b9f8aa933528e0381b495c1adf973959a7eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: sercon: pass console specParams on device copy
by piotr.kliczewski＠gmail.com 20 Nov '15

20 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: sercon: pass console specParams on device copy ...................................................................... sercon: pass console specParams on device copy When we copy the devices of a VM, we forget to carry around the console device specParams. This aptch fixes that. Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Bug-Url: https://bugzilla.redhat.com/1280370 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine : Remove SessionDataContainer injection LoginOnBehalf...
by piotr.kliczewski＠gmail.com 20 Nov '15

20 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Remove SessionDataContainer injection LoginOnBehalfCommand ...................................................................... engine : Remove SessionDataContainer injection LoginOnBehalfCommand For 3.6 SessionDataContainer should still be used by calling getInstance. This is not relevant for master where SessionDataContainer has been made a bean. Change-Id: Ibae09c58f790042657a50b2aa5b4c3e85539053b Bug-Url: https://bugzilla.redhat.com/1264385 Bug-Url: https://bugzilla.redhat.com/1264391 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae09c58f790042657a50b2aa5b4c3e85539053b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: Copy host device spec params on template creation
by piotr.kliczewski＠gmail.com 20 Nov '15

20 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: backend: Copy host device spec params on template creation ...................................................................... backend: Copy host device spec params on template creation Without preserving the contents of host devices's spec params the devices of template (and VMs created from this template) will become unusable - invisible and unmodifiable to the UI. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281433 Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: relying on shared code from ovirt_setup_lib
by sbonazzo＠redhat.com 20 Nov '15

20 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: relying on shared code from ovirt_setup_lib ...................................................................... packaging: setup: relying on shared code from ovirt_setup_lib Relying on shared code from ovirt_setup_lib Change-Id: I884089c5674ab8042cc02fe46ab5a3ca3a599b97 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in D packaging/setup/ovirt_engine_setup/dialog.py M packaging/setup/ovirt_engine_setup/engine_common/database.py D packaging/setup/ovirt_engine_setup/hostname.py M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py M packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-common/dockerc/core.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/base/dialog/preview.py M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 36 files changed, 89 insertions(+), 631 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884089c5674ab8042cc02fe46ab5a3ca3a599b97 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: on cleanup connecting to docker only if we...
by piotr.kliczewski＠gmail.com 19 Nov '15

19 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: on cleanup connecting to docker only if we deployed ...................................................................... packaging: setup: on cleanup connecting to docker only if we deployed on engine-cleanup, enable the docker containers remove plugin only if in the setup phase we deployed at least one container. Bug-Url: https://bugzilla.redhat.com/1282880 Change-Id: I691c5d5459b559e23e4385c72d117c257377790d Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691c5d5459b559e23e4385c72d117c257377790d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: No up DC with cluster with permission message
by tjelinek＠redhat.com 19 Nov '15

19 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: No up DC with cluster with permission message ...................................................................... userportal: No up DC with cluster with permission message It fixes missleading message when one tries to create a VM in userportal without permissions for cluster. Previous message was: "Not available when no Data Center is up." which might not necessar be true. New message is "Not available when there is no Data Center up with Cluster you have permissions for." Change-Id: I0a3d5218a678f4d5862849698c90bbd0b035faa3 Bug-Url: https://bugzilla.redhat.com/1278271 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3d5218a678f4d5862849698c90bbd0b035faa3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: sercon: validate certs connecting to engine
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: sercon: validate certs connecting to engine ...................................................................... setup: sercon: validate certs connecting to engine When communicating with engine we need to specify CA certificate we trust. Moreover, the host name validation should be optionally disabled (e.g. if the server name is localhost) This patch extends the ovirt-vmconsole-list.py helper script accordingly. Bug-Url: https://bugzilla.redhat.com/1264479 Change-Id: I9ce552b84bd2c3c8c6c2dce6b8541ae9dba7abf5 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/conf/ovirt-vmconsole-proxy-helper.conf.in M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py 3 files changed, 116 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/46373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ce552b84bd2c3c8c6c2dce6b8541ae9dba7abf5 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0