Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.0.2
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Release 3.6.0.2
......................................................................
cli: Release 3.6.0.2
Change-Id: I5482e4fac7c24bde625637b9a1b3459643127a5c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
M setup.py
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48622
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5482e4fac7c24bde625637b9a1b3459643127a5c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: restapi: fixed option mapping errors
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: fixed option mapping errors
......................................................................
restapi: fixed option mapping errors
• when option name is not set, "null=abc" will be produced, which is
obviously wrong.
Change-Id: I98c4719e68eb63d708e9909e070bb329dfdba833
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47563
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98c4719e68eb63d708e9909e070bb329dfdba833
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi: Import VM - support volume type/format
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Import VM - support volume type/format
......................................................................
restapi: Import VM - support volume type/format
Adding support for changing the allocation policy of disks imported from
an export domain as part of importing a VM.
The caller can specify for each disks the format and allocation policy.
Note that "collapse_snapshots" should be true.
For example, to force one of the disks to be preallocated:
POST
/storagedomains/{storagedomain:id}/vms/{vm:id}/import
<action>
<storage_domain>
<name>mydata</name>
</storage_domain>
<cluster>
<name>mycluster</name>
</cluster>
<vm>
<disks>
<disk id="792f8ca8-3932-429b-9660-006ba144bc72">
<format>raw</format>
<sparse>false</sparse>
</disk>
</disks>
<snapshots>
<collapse_snapshots>true</collapse_snapshots>
</snapshots>
</vm>
</action>
Change-Id: I0cd0dc95bfb938d66e8e1ba1ad56116e4dc173f3
Bug-Url: https://bugzilla.redhat.com/998607
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
2 files changed, 70 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/48488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cd0dc95bfb938d66e8e1ba1ad56116e4dc173f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types
......................................................................
engine: Block Hotplug/unplug 'pci-passthrough' vNIC types
Bug-Url: https://bugzilla.redhat.com/1273486
Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 65 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix for required checkbox in manage network popup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix for required checkbox in manage network popup
......................................................................
webadmin: fix for required checkbox in manage
network popup
the fix will prevent mark network as required if
the network is not attached to the cluster.
Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4
Bug-Url: https://bugzilla.redhat.com/1200787
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
(cherry picked from commit ab2da3d3efd79caaa7293eeae6b5634837be750a)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: send custom properties for VFs
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: send custom properties for VFs
......................................................................
engine: send custom properties for VFs
Change-Id: I886b8beea6437ed09dc5a8e6c76be63c3eb83fcb
Bug-Url: https://bugzilla.redhat.com/1279775
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit 1cd65c564cfd315c25f95c1107b69cf92ef4985c)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I886b8beea6437ed09dc5a8e6c76be63c3eb83fcb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: 'passthrough' vnic should be automatically 'pci-pa...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type
......................................................................
webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type
Bug-Url: https://bugzilla.redhat.com/1269405
Bug-Url: https://bugzilla.redhat.com/1271912
Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseInterfaceCreatingManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
2 files changed, 44 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48604
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: correct size unit on export image view
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: correct size unit on export image view
......................................................................
webadmin: correct size unit on export image view
Disks -> Export Dialog:
'Actual Size' values should be converted using SizeUnit.GiB.
Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14
Bug-Url: https://bugzilla.redhat.com/1281288
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/48593
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: webadmin: adding custom bond validation to hostSetupNetwork
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: adding custom bond validation to hostSetupNetwork
......................................................................
webadmin: adding custom bond validation to
hostSetupNetwork
adding a non empty validaiton to custom mode.
Change-Id: I1c0722d8872a700c5d843a0a4784356794725b9b
Bug-Url: https://bugzilla.redhat.com/1167812
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml
4 files changed, 39 insertions(+), 24 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45013
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c0722d8872a700c5d843a0a4784356794725b9b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: db: format SQL files
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: format SQL files
......................................................................
db: format SQL files
Introduce basic SQL formatting and apply on all scripts in dbscripts
directory.
This is done in order to ease gerrit reviews on DB scripts and make code
more readable.
Main issues addressed
1) Making a change noticeable in a code line (for example splitting
column names, values and parameters each in a separate line
2) Code alignment
3) Keywords in uppercase
Work was mainly done using http://poorsql.com/
Next step would be to find a way to automate either formatting or
validation
See [1] for formatting rules applied in this patch
[1] http://www.ovirt.org/index.php?title=OVirt-DB-Issues/formatting
Change-Id: I19cc61bad1f11fcf9d7d2c5d2a55ced7758ee3da
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/action_version_map_sp.sql
M packaging/dbscripts/ad_groups_sp.sql
M packaging/dbscripts/affinity_groups_sp.sql
M packaging/dbscripts/all_disks_sp.sql
M packaging/dbscripts/async_tasks_sp.sql
M packaging/dbscripts/audit_log_sp.sql
M packaging/dbscripts/base_disks_sp.sql
M packaging/dbscripts/bookmarks_sp.sql
M packaging/dbscripts/business_entity_snapshot_sp.sql
M packaging/dbscripts/cluster_features_sp.sql
M packaging/dbscripts/cluster_policy_sp.sql
M packaging/dbscripts/command_entities_sp.sql
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/cpu_profiles_sp.sql
M packaging/dbscripts/create_dwh_views.sql
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/custom_actions_sp.sql
M packaging/dbscripts/disk_image_dynamic_sp.sql
M packaging/dbscripts/disk_images_sp.sql
M packaging/dbscripts/disk_lun_map_sp.sql
M packaging/dbscripts/disk_profiles_sp.sql
M packaging/dbscripts/drop_db.sql
M packaging/dbscripts/dwh_history_timekeeping_sp.sql
M packaging/dbscripts/dwh_translation_tables_sp.sql
M packaging/dbscripts/engine_backup_log_sp.sql
M packaging/dbscripts/engine_sessions_sp.sql
M packaging/dbscripts/event_sp.sql
M packaging/dbscripts/external_variable_sp.sql
M packaging/dbscripts/fence_agents_sp.sql
M packaging/dbscripts/gluster_georep_sp.sql
M packaging/dbscripts/gluster_hooks_sp.sql
M packaging/dbscripts/gluster_server_sp.sql
M packaging/dbscripts/gluster_services_sp.sql
M packaging/dbscripts/gluster_volume_snapshot_schedule_sp.sql
M packaging/dbscripts/gluster_volume_snapshot_sp.sql
M packaging/dbscripts/gluster_volumes_sp.sql
M packaging/dbscripts/host_device_sp.sql
M packaging/dbscripts/image_storage_domain_map_sp.sql
M packaging/dbscripts/images_sp.sql
M packaging/dbscripts/inst_sp.sql
M packaging/dbscripts/iscsi_bonds_sp.sql
M packaging/dbscripts/job_sp.sql
M packaging/dbscripts/libvirt_secrets_sp.sql
M packaging/dbscripts/mac_pools_sp.sql
M packaging/dbscripts/materialized_views_sp.sql
M packaging/dbscripts/multi_level_administration_sp.sql
M packaging/dbscripts/network_sp.sql
M packaging/dbscripts/numa_sp.sql
M packaging/dbscripts/policy_unit_sp.sql
M packaging/dbscripts/providers_sp.sql
M packaging/dbscripts/qos_sp.sql
M packaging/dbscripts/quota_sp.sql
M packaging/dbscripts/repo_files_meta_data_sp.sql
M packaging/dbscripts/snapshots_sp.sql
M packaging/dbscripts/storage_device_sp.sql
M packaging/dbscripts/storages_san_sp.sql
M packaging/dbscripts/storages_sp.sql
M packaging/dbscripts/system_statistics_sp.sql
M packaging/dbscripts/tags_sp.sql
M packaging/dbscripts/tags_vm_pool_map_sp.sql
M packaging/dbscripts/unregistered_OVF_data_sp.sql
M packaging/dbscripts/user_profiles_sp.sql
M packaging/dbscripts/user_sp.sql
M packaging/dbscripts/vdc_option_sp.sql
M packaging/dbscripts/vds_groups_sp.sql
M packaging/dbscripts/vds_kdump_status_sp.sql
M packaging/dbscripts/vds_sp.sql
M packaging/dbscripts/vds_spm_id_map_sp.sql
M packaging/dbscripts/vm_device_sp.sql
M packaging/dbscripts/vm_icons_sp.sql
M packaging/dbscripts/vm_jobs_sp.sql
M packaging/dbscripts/vm_pool_maps_sp.sql
M packaging/dbscripts/vm_pools_sp.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
76 files changed, 21,220 insertions(+), 15,989 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19cc61bad1f11fcf9d7d2c5d2a55ced7758ee3da
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months